| • mewoph | |
| Sep 10 2021, 4:50 PM |
| F34639490: Screen Shot 2021-09-10 at 9.54.41 AM.png | |
| Sep 10 2021, 4:57 PM |
| F34639486: Screen Shot 2021-09-10 at 9.49.23 AM.png | |
| Sep 10 2021, 4:50 PM |
List of steps to reproduce (step by step, including full links if applicable):
What happens?:
The editing toolbar doesn't have a bottom border.
What should have happened instead?:
The editing toolbar should have a bottom border.
Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
MediaWiki 1.37.0-alpha
VisualEditor 0.1.2
The toolbar has ve-ui-toolbar-empty class when it's not actually empty. VisualEditor recently updated styling for empty toolbar (no border, box-shadow). VE's determination is done in ve.ui.Toolbar.js via checking the length of toolbarGroups array. In the current implementation of Suggestions mode toolbar, we are initially this to an empty array and then setup the toolbar manually afterwards.
Change 720346 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):
[mediawiki/extensions/GrowthExperiments@master] Suggestions Mode: Set toolbarGroups so the toolbar isn't treated as empty
Change 720346 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Suggestions Mode: Set toolbarGroups so the toolbar isn't treated as empty
