Page MenuHomePhabricator
Create Task
Maniphest T290941

Preserve open/collapsed state of the accordion [M]
Closed, ResolvedPublic
Actions

Description

Motivation

Patrollers use IP Information frequently would prefer the state of the accordion preserved when they frequent different IP contributions pages or refresh a page - they saves them an extra click in expanding the accordion every time they land on the contributions page.

Tech Specs
  • On load, check if the user preference is set and set the accordion to that
  • On opening/closing the accordion, set a user preference for that accordion state
Acceptance criteria
  • When a user visits the contributions page for any IP address, the IP Information accordion should stay open or closed based on their previous preference.
  • If the user changes the state of the accordion, this should be the new "remembered" state of the accordion.

Details

SubjectRepoBranchLines +/-
Save user preference for infobox statemediawiki/extensions/IPInfomaster+25 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Niharika created this task.Sep 14 2021, 12:52 AM
• Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.
ARamirez_WMF renamed this task from Preserve open/collapsed state of the accordion to Preserve open/collapsed state of the accordion [M].Sep 29 2021, 4:32 PM
ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.
STran renamed this task from Preserve open/collapsed state of the accordion [M] to Preserve open/collapsed state of the accordion.Sep 29 2021, 4:42 PM
STran updated the task description. (Show Details)
ARamirez_WMF renamed this task from Preserve open/collapsed state of the accordion to Preserve open/collapsed state of the accordion [M].Sep 29 2021, 4:43 PM
STran claimed this task.Oct 11 2021, 2:59 PM
STran moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.
STran edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.
STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
gerritbot added a comment.Oct 11 2021, 3:43 PM

Change 730017 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/IPInfo@master] Save user preference for infobox state

https://gerrit.wikimedia.org/r/730017

gerritbot added a project: Patch-For-Review.Oct 11 2021, 3:43 PM
STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Oct 11 2021, 3:53 PM
phuedx moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Oct 18 2021, 11:47 AM
gerritbot added a comment.Oct 18 2021, 12:05 PM

Change 730017 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Save user preference for infobox state

https://gerrit.wikimedia.org/r/730017

STran mentioned this in rEIPI4b28fe6e3055: Save user preference for infobox state.Oct 18 2021, 12:06 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 18 2021, 12:11 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.5; 2021-10-19).Oct 18 2021, 3:00 PM
phuedx mentioned this in T267235: Add performance instrumentation to IP Info extension [M].Oct 18 2021, 5:15 PM
• imaigwilo subscribed.EditedOct 25 2021, 4:49 PM

Verified that:

    • Opening/closing the accordion, set a user preference for that accordion state
    • When a user visits the contributions page for any IP address, the IP Information accordion stays open or closed based on their previous preference.
    • When the user changes the state of the accordion, that became the new "remembered" state of the accordion when the user refreshes the page or view any IP contribution pages
  • Tested on Chrome, Firefox, Safari, IE, Edge, and Opera.

Issue:
On IE when IP info has been collapsed, when screen is refresh IP info is open. Does not persist well in IE.

Screen shots of open/collapsed state:
https://en.wikipedia.beta.wmflabs.org/wiki/Special:Contributions/31.10.149.140

Screen Shot 2021-10-25 at 12.02.32 AM.png (1×2 px, 557 KB)
Screen Shot 2021-10-25 at 12.50.47 PM.png (1×2 px, 598 KB)

• imaigwilo moved this task from QA/Testing 🐞 to Done: Q2 2021-22 on the Anti-Harassment (The Letter Song) board.Oct 25 2021, 4:51 PM
• Niharika added a comment.Nov 3 2021, 5:12 AM

On IE when IP info has been collapsed, when screen is refresh IP info is open. Does not persist well in IE.

@imaigwilo can you file a task for this bug please? We may not prioritize it right now but good to have the bug documented.

• imaigwilo added a comment.Nov 3 2021, 1:55 PM

@Niharika I have created the task for the bug.
Thank you.

• imaigwilo added a subtask: T294914: Preserve open/collapsed state of the accordion Fails in IE [L].Nov 3 2021, 1:58 PM
phuedx moved this task from Backlog to In Progress on the IP Info board.Nov 5 2021, 4:38 PM
• Niharika closed this task as Resolved.Nov 8 2021, 7:04 PM
• Niharika moved this task from In Progress to Closed on the IP Info board.
• Niharika closed subtask T294914: Preserve open/collapsed state of the accordion Fails in IE [L] as Resolved.Feb 17 2022, 1:47 AM
Tchanders mentioned this in T304430: Use localStorage instead of a user preference for saving whether the infobox is expanded or collapsed.Mar 22 2022, 3:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL