Error: Call to a member function getMimeType() on null
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	hashar
	Sep 14 2021, 2:31 PM

Description

Error

mwversion: 1.37.0-wmf.21
reqId: dcc6cdfe-2652-44a9-a9c8-a6fafb850b83
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

[{reqId}] {exception_url}   Error: Call to a member function getMimeType() on null

exception.trace

from /srv/mediawiki/php-1.37.0-wmf.21/extensions/PageImages/includes/Hooks/SearchResultProvideThumbnailHookHandler.php(100)
#0 /srv/mediawiki/php-1.37.0-wmf.21/extensions/PageImages/includes/Hooks/SearchResultProvideThumbnailHookHandler.php(122): PageImages\Hooks\SearchResultProvideThumbnailHookHandler->getThumbnails(array, integer)
#1 /srv/mediawiki/php-1.37.0-wmf.21/extensions/PageImages/includes/Hooks/SearchResultProvideThumbnailHookHandler.php(141): PageImages\Hooks\SearchResultProvideThumbnailHookHandler->doSearchResultProvideThumbnail(array, array)
#2 /srv/mediawiki/php-1.37.0-wmf.21/includes/HookContainer/HookContainer.php(338): PageImages\Hooks\SearchResultProvideThumbnailHookHandler::onSearchResultProvideThumbnail(array, array)
#3 /srv/mediawiki/php-1.37.0-wmf.21/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#4 /srv/mediawiki/php-1.37.0-wmf.21/includes/HookContainer/HookRunner.php(3250): MediaWiki\HookContainer\HookContainer->run(string, array)
#5 /srv/mediawiki/php-1.37.0-wmf.21/includes/Rest/Handler/SearchHandler.php(299): MediaWiki\HookContainer\HookRunner->onSearchResultProvideThumbnail(array, array)
#6 /srv/mediawiki/php-1.37.0-wmf.21/includes/Rest/Handler/SearchHandler.php(328): MediaWiki\Rest\Handler\SearchHandler->buildThumbnailsFromPageIdentities(array)
#7 /srv/mediawiki/php-1.37.0-wmf.21/includes/Rest/Router.php(403): MediaWiki\Rest\Handler\SearchHandler->execute()
#8 /srv/mediawiki/php-1.37.0-wmf.21/includes/Rest/Router.php(330): MediaWiki\Rest\Router->executeHandler(MediaWiki\Rest\Handler\SearchHandler)
#9 /srv/mediawiki/php-1.37.0-wmf.21/includes/Rest/EntryPoint.php(165): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#10 /srv/mediawiki/php-1.37.0-wmf.21/includes/Rest/EntryPoint.php(130): MediaWiki\Rest\EntryPoint->execute()
#11 /srv/mediawiki/php-1.37.0-wmf.21/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#12 /srv/mediawiki/w/rest.php(3): require(string)
#13 {main}

Impact

It might well break the search drop list? A request to https://fr.wikipedia.org/w/rest.php/v1/search/title?q=circu&limit=10 yields empty content after roughly 35 seconds.

Similar ones based on the URL being called:

Wiki	Search term(s)
frwiki	circ circu circuit holde
frwiktionary	co
ptwiki	cobre
euwiki	h
srwiki	pla plan

I guess cause some thumbnail have faults?

Notes

The first event was at Sep 13th 2021 19:57:55 UTC for frwiki with the query royaume des.

Histogram of events in Kibana:

Details

Request URL: https://fr.wikipedia.org/w/rest.php/v1/search/title?q=*&limit=*

Subject	Repo	Branch	Lines +/-
Check $thumb->isError() before trying to use it	mediawiki/extensions/PageImages	wmf/1.37.0-wmf.23	+1 -1
Check $thumb->isError() before trying to use it	mediawiki/extensions/PageImages	wmf/1.37.0-wmf.21	+1 -1
Check $thumb->isError() before trying to use it	mediawiki/extensions/PageImages	wmf/1.37.0-wmf.22	+1 -1
Check $thumb->isError() before trying to use it	mediawiki/extensions/PageImages	REL1_37	+1 -1
Check $thumb->isError() before trying to use it	mediawiki/extensions/PageImages	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T291014: Terminate all implicit use of VipsScaler code from Wikimedia production so we can remove it without breaking things this time
T291010: MediaWiki refuses to generate thumbnail URLs for large PNGs and TIFFs with "Error creating thumbnail: File with dimensions greater than 100 MP"
T290759: Undeploy VipsScaler from Wikimedia wikis
Mentioned Here: T290759: Undeploy VipsScaler from Wikimedia wikis

Event Timeline

hashar created this task.Sep 14 2021, 2:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2021, 2:31 PM

Might be related T290759:

19:52 	<jforrester@deploy1002> 	Synchronized wmf-config/InitialiseSettings.php: T290759 Undeploy VipsScaler: I – Disable on all wikis (duration: 00m 57s)

That was to drop https://www.mediawiki.org/wiki/VipsScaler which was to generate thumbnails.

The code choke at when trying to get a thumbnail mimetype although one apparently got returned:

includes/Hooks/SearchResultProvideThumbnailHookHandler.php

 82         $files = $this->getFileNamesForPageTitles( $pagesByPageId )
 83             + $this->getFileNamesForFileTitles( $titleFilesByPageId );
 84 
 85         $res = [];
 86         foreach ( $files as $pageId => $fileName ) {
 87             $file = $this->repoGroup->findFile( $fileName );
 88             if ( !$file ) {
 89                 continue;
 90             }
 91             $thumb = $file->transform( [ 'width' => $size , 'height' => $size ] );
 92             if ( !$thumb ) {
 93                 continue;
 94             }
 95 
 96             $localPath = $thumb->getLocalCopyPath();
 97             $thumbSize = $localPath && file_exists( $localPath ) ? filesize( $localPath ) : null;
 98 
 99             $res[$pageId] = new SearchResultThumbnail(
100                 $thumb->getFile()->getMimeType(),    # <--------------------------
101                 $thumbSize,
102                 $thumb->getWidth(),
103                 $thumb->getHeight(),
104                 null,
105                 wfExpandUrl( $thumb->getUrl(), PROTO_RELATIVE ),
106                 $fileName
107             );

hashar mentioned this in T290759: Undeploy VipsScaler from Wikimedia wikis.Sep 14 2021, 2:47 PM

In T290759#7349872, @Legoktm wrote:

For vips specifically, I looked through exec.log before bringing it up that the only invocations of vips in the past 30 days was from Special:VipsTest.

Did we miss this? Or is it just happenstance and this wasn't going through Vips?

It definitely was not shelling out to vips (unless we're missing entries from exec.log). I'm having a hard time tracing all the file logic... VipsScaler hooks into BitmapHandlerTransform, which is called in TransformationalImageHandler::doTransform(). But even then, it shouldn't affect the response of File::transform.

I do think PageImages needs to check $thumb->isError() first, and that might do the trick?

Change 721027 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/extensions/PageImages@master] Check $thumb->isError() before trying to use it

https://gerrit.wikimedia.org/r/721027

gerritbot added a project: Patch-For-Review.Sep 14 2021, 4:56 PM

Change 721027 merged by jenkins-bot:

[mediawiki/extensions/PageImages@master] Check $thumb->isError() before trying to use it

https://gerrit.wikimedia.org/r/721027

Change 720857 had a related patch set uploaded (by Jforrester; author: Legoktm):

[mediawiki/extensions/PageImages@REL1_37] Check $thumb->isError() before trying to use it

https://gerrit.wikimedia.org/r/720857

Change 720858 had a related patch set uploaded (by Jforrester; author: Legoktm):

[mediawiki/extensions/PageImages@wmf/1.37.0-wmf.23] Check $thumb->isError() before trying to use it

https://gerrit.wikimedia.org/r/720858

Change 720859 had a related patch set uploaded (by Jforrester; author: Legoktm):

[mediawiki/extensions/PageImages@wmf/1.37.0-wmf.22] Check $thumb->isError() before trying to use it

https://gerrit.wikimedia.org/r/720859

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 14 2021, 6:00 PM

Change 720857 merged by jenkins-bot:

[mediawiki/extensions/PageImages@REL1_37] Check $thumb->isError() before trying to use it

https://gerrit.wikimedia.org/r/720857

Change 720865 had a related patch set uploaded (by Jforrester; author: Legoktm):

[mediawiki/extensions/PageImages@wmf/1.37.0-wmf.21] Check $thumb->isError() before trying to use it

https://gerrit.wikimedia.org/r/720865

Change 720859 abandoned by Jforrester:

[mediawiki/extensions/PageImages@wmf/1.37.0-wmf.22] Check $thumb->isError() before trying to use it

Reason:

We didn't deploy wmf.22.

https://gerrit.wikimedia.org/r/720859

Legoktm mentioned this in T291010: MediaWiki refuses to generate thumbnail URLs for large PNGs and TIFFs with "Error creating thumbnail: File with dimensions greater than 100 MP".Sep 14 2021, 9:49 PM

VipsScaler is back for now, we'll make sure this doesn't regress when removing it again.

AntiCompositeNumber subscribed.Sep 15 2021, 1:17 AM

Looks fixed to me. Thank you @Legoktm for the quick fixes!

Legoktm mentioned this in T291014: Terminate all implicit use of VipsScaler code from Wikimedia production so we can remove it without breaking things this time.Sep 20 2021, 7:01 AM

Change 720865 abandoned by Jforrester:

[mediawiki/extensions/PageImages@wmf/1.37.0-wmf.21] Check $thumb->isError() before trying to use it

Reason:

wmf.21 isn't deployed anywhere any more.

https://gerrit.wikimedia.org/r/720865

Krinkle moved this task from Untriaged to Sep 2021 on the Wikimedia-production-error board.Mar 14 2022, 4:24 PM

Change 720858 abandoned by Jforrester:

[mediawiki/extensions/PageImages@wmf/1.37.0-wmf.23] Check $thumb->isError() before trying to use it

Reason:

Clearly we didn't deploy this. :-)

https://gerrit.wikimedia.org/r/720858

Error: Call to a member function getMimeType() on nullClosed, ResolvedPublicPRODUCTION ERRORActions

Description

Error

Impact

Notes

Details

Related Objects

Event Timeline

Error: Call to a member function getMimeType() on null
Closed, ResolvedPublicPRODUCTION ERROR
Actions