Page MenuHomePhabricator

Migrate orchestrator/evaluator responses to reply with result envelopes including meta-data map type
Closed, ResolvedPublic

Description

Before, Z22 is of type Z1,Z5|Z24 [i.e. An anything plus an error or void]
After, Z22 is of type Z1,Z883(Z6,Z1) [i.e. An anything plus a Z883 = Typed map of string=>anything]

✅ Set-up
  • Add / modify relevant function-schemata methods to support new Z22 format (in which Z22K2 is a Z883 / Map instead of a Z5 / Error)
  • Alter function-orchestrator to handle either old or new Z22 format coming from the evaluator. (Orchestrator should use the new Z22 format throughout, but must return the old format to its callers.)
  • Alter MW PHP API to handle either old or new Z22 format coming from the orchestrator (but still return the old format to callers).
  • Alter MW Vue layer to handle either old or new Z22 format coming from the PHP layer.
✅ Switch-over
  • Update function-schemata to use map-based responseEnvelopes internally (but still supports basic responseEnvelopes)
  • Update relevant JSON & YAML files in function-schemata
  • Alter function-evaluator to respond with a map object instead of a direct Z5 or Z24.
  • Alter function-orchestrator to respond with a map object instead of a direct Z5 or Z24.
  • Alter MW PHP API to respond with a map object instead of a direct Z5 or Z24.
✅ Clean-up
  • Ensure that no function-schemata test code/cases employ the old format
  • Ensure that no function-evaluator test code/cases employ the old format
  • Ensure that no function-orchestrator test code/cases employ the old format
  • Ensure that no PHP test code/cases employ the old format
  • Ensure that no Vue test code/cases employ the old format
  • Drop back-compat. code in function-evaluator
  • Drop back-compat. code in function-orchestrator
  • Drop back-compat. code in MW PHP API
  • Drop back-compat. code in MW Vue code
  • Drop back-compat. code in function-schemata

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikiLambdamaster+4 -3
mediawiki/services/function-evaluatormaster+1 -1
mediawiki/services/function-orchestratormaster+1 -1
mediawiki/tools/wikilambda-climaster+1 -1
mediawiki/services/function-schematamaster+6 -147
mediawiki/services/function-orchestratormaster+6 -4
mediawiki/services/function-evaluatormaster+0 -158
mediawiki/extensions/WikiLambdamaster+14 -23
mediawiki/extensions/WikiLambdamaster+1 -74
mediawiki/extensions/WikiLambdamaster+2 -25
mediawiki/extensions/WikiLambdamaster+9 -40
mediawiki/services/function-orchestratormaster+2 -2
mediawiki/services/function-orchestratormaster+1 -3
mediawiki/services/function-orchestratormaster+26 -12
mediawiki/services/function-evaluatormaster+1 -1
mediawiki/services/function-orchestratormaster+19 -32
mediawiki/services/function-orchestratormaster+1 -1
mediawiki/extensions/WikiLambdamaster+1 -1
mediawiki/services/function-schematamaster+9 -0
mediawiki/services/function-schematamaster+99 -10
mediawiki/services/function-orchestratormaster+12 -0
mediawiki/extensions/WikiLambdamaster+27 -3
mediawiki/extensions/WikiLambdamaster+2 -2
mediawiki/extensions/WikiLambdamaster+220 -29
mediawiki/services/function-evaluatormaster+27 -2
mediawiki/services/function-evaluatormaster+39 -6
mediawiki/services/function-evaluatormaster+921 -85
mediawiki/services/function-orchestratormaster+1 -1
mediawiki/services/function-evaluatormaster+1 -1
mediawiki/extensions/WikiLambdamaster+1 -1
mediawiki/services/function-schematamaster+38 -14
mediawiki/services/function-schematamaster+5 -5
mediawiki/services/function-orchestratormaster+1 -1
mediawiki/services/function-evaluatormaster+1 -1
mediawiki/services/function-schematamaster+20 -10
mediawiki/services/function-orchestratormaster+591 -3
mediawiki/services/function-orchestratormaster+517 -64
mediawiki/services/function-evaluatormaster+1 -1
mediawiki/extensions/WikiLambdamaster+1 -1
mediawiki/services/function-orchestratormaster+44 -0
mediawiki/services/function-orchestratormaster+1 -1
mediawiki/services/function-schematamaster+481 -55
Show related patches Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 797340 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (e9afd51)

https://gerrit.wikimedia.org/r/797340

Change 790384 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (e9afd51)

https://gerrit.wikimedia.org/r/790384

Change 790383 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (e9afd51)

https://gerrit.wikimedia.org/r/790383

Change 797340 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (e9afd51)

https://gerrit.wikimedia.org/r/797340

Change 795936 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Alter function-evaluator to respond with a map-based Z22

https://gerrit.wikimedia.org/r/795936

DMartin-WMF changed the task status from Open to In Progress.May 24 2022, 6:13 PM

Change 799017 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-evaluator@master] Record initial execution metrics in Z22

https://gerrit.wikimedia.org/r/799017

Change 799017 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Record initial execution metrics in Z22

https://gerrit.wikimedia.org/r/799017

Change 800313 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-evaluator@master] Add test statements to ensure Z22K2 is ZMap

https://gerrit.wikimedia.org/r/800313

Change 800313 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Add test statements to ensure Z22K2 is ZMap

https://gerrit.wikimedia.org/r/800313

Change 801970 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Vue ResponseEnvelope component handles map-based Z22

https://gerrit.wikimedia.org/r/801970

Change 792276 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZResponseEnvelope: Cope with Maps as well as Errors

https://gerrit.wikimedia.org/r/792276

Change 803619 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Rename "error" to "metadata" in performFunctionCall

https://gerrit.wikimedia.org/r/803619

Change 803619 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Rename "error" to "metadata" in performFunctionCall

https://gerrit.wikimedia.org/r/803619

Change 801970 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Vue ResponseEnvelope component handles map-based Z22

https://gerrit.wikimedia.org/r/801970

Change 804487 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-orchestrator@master] Add empty tail (K2 property) to test case input

https://gerrit.wikimedia.org/r/804487

Change 804490 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-schemata@master] Make getError and getZMapValue handle canonical form

https://gerrit.wikimedia.org/r/804490

Change 804487 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Add empty tail (K2 property) to test case input

https://gerrit.wikimedia.org/r/804487

Change 804737 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-schemata@master] Add tests for getZMapValue

https://gerrit.wikimedia.org/r/804737

Change 804742 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-orchestrator@master] Ensure testing employs map-based Z22

https://gerrit.wikimedia.org/r/804742

Change 804490 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Make getError and getZMapValue handle canonical form

https://gerrit.wikimedia.org/r/804490

Change 804737 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Add tests for getZMapValue

https://gerrit.wikimedia.org/r/804737

Change 805128 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (3cdf1cd)

https://gerrit.wikimedia.org/r/805128

Change 805129 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (3cdf1cd)

https://gerrit.wikimedia.org/r/805129

Change 805130 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (3cdf1cd)

https://gerrit.wikimedia.org/r/805130

Change 805129 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (3cdf1cd)

https://gerrit.wikimedia.org/r/805129

Change 805130 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (3cdf1cd)

https://gerrit.wikimedia.org/r/805130

Change 805128 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (3cdf1cd)

https://gerrit.wikimedia.org/r/805128

Change 804742 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Ensure testing employs map-based Z22

https://gerrit.wikimedia.org/r/804742

Change 805236 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-orchestrator@master] Remove unnecessary testing calls to makeMappedResultEnvelope

https://gerrit.wikimedia.org/r/805236

Change 805236 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Remove unnecessary testing calls to makeMappedResultEnvelope

https://gerrit.wikimedia.org/r/805236

Change 805500 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-orchestrator@master] Make orchestrate() return map-based Z22

https://gerrit.wikimedia.org/r/805500

Change 805500 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Make orchestrate() return map-based Z22

https://gerrit.wikimedia.org/r/805500

Change 806357 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-orchestrator@master] Remove values of "benjamin" flag in calls to getError()

https://gerrit.wikimedia.org/r/806357

Change 806357 abandoned by Genoveva Galarza:

[mediawiki/services/function-orchestrator@master] Remove values of "benjamin" flag in calls to getError()

Reason:

These changes are included in the already merged change ID Id423081089788bab489a21477bc70f1d731cdd43

https://gerrit.wikimedia.org/r/806357

Change 841795 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Drop use of non-ZMap Z22 creation in PHP tests

https://gerrit.wikimedia.org/r/841795

Change 841999 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] [WIP] Drop old-style Z22 support

https://gerrit.wikimedia.org/r/841999

Change 841795 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Drop use of non-ZMap Z22 creation in PHP tests

https://gerrit.wikimedia.org/r/841795

Change 842997 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Drop old-style (non-ZTypedMap) Z22 support in Vue layer

https://gerrit.wikimedia.org/r/842997

Change 842998 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Remove Vue layer functions obsoleted by use of metadata dialog

https://gerrit.wikimedia.org/r/842998

Change 842997 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Drop old-style (non-ZTypedMap) Z22 support in Vue layer

https://gerrit.wikimedia.org/r/842997

Change 842998 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Remove Vue layer functions obsoleted by use of metadata dialog

https://gerrit.wikimedia.org/r/842998

Change 841999 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZResponseEnvelope.php: Drop old-style (non-ZTypedMap) Z22 support

https://gerrit.wikimedia.org/r/841999

Change 854654 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-evaluator@master] Remove test files with a Z5 as value of Z22K2

https://gerrit.wikimedia.org/r/854654

Change 854656 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-orchestrator@master] Remove back-compat code allowing Z5 value for Z22K2

https://gerrit.wikimedia.org/r/854656

Change 854654 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Remove test files with a Z5 as value of Z22K2

https://gerrit.wikimedia.org/r/854654

Change 854656 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Remove back-compat code allowing Z5 value for Z22K2

https://gerrit.wikimedia.org/r/854656

Change 855167 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-schemata@master] Remove back-compat. code for old-style Z22

https://gerrit.wikimedia.org/r/855167

Change 855167 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Remove back-compat. code for old-style Z22

https://gerrit.wikimedia.org/r/855167

Change 856657 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (671adc7)

https://gerrit.wikimedia.org/r/856657

Change 856658 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (671adc7)

https://gerrit.wikimedia.org/r/856658

Change 856659 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (671adc7)

https://gerrit.wikimedia.org/r/856659

Change 856660 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (671adc7)

https://gerrit.wikimedia.org/r/856660

Change 856660 merged by jenkins-bot:

[mediawiki/tools/wikilambda-cli@master] Update function-schemata sub-module to HEAD (671adc7)

https://gerrit.wikimedia.org/r/856660

Change 856658 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (671adc7)

https://gerrit.wikimedia.org/r/856658

Change 856659 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (671adc7)

https://gerrit.wikimedia.org/r/856659

Change 856657 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (671adc7)

https://gerrit.wikimedia.org/r/856657

Jdforrester-WMF updated the task description. (Show Details)