Add RiskScorer for Ingenico to SmashPig
Closed, ResolvedPublic
Actions

Description

This should work like the RiskScorer for Adyen, taking an API response, consulting a lookup table, and giving a numerical score for AVS and CVV results.

This will be used in the pending transaction resolver created in T291223 so that we don't have to rely on DonationInterface's AVS/CVV scores.

As preparation for deployment, copy (and reformat) the current Ingenico risk scores from the payments LocalSettings file to the private ingenico/main.yaml SmashPig settings file.

Details

Subject	Repo	Branch	Lines +/-
Map tokens to RecurringPaymentToken field	wikimedia/fundraising/SmashPig	master	+7 -0
Use risk scorer for Ingenico hosted checkout status	wikimedia/fundraising/SmashPig	master	+77 -2
Move RiskScorer to PaymentProvider namespace	wikimedia/fundraising/SmashPig	master	+2 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T276183 Epic: Automatically send status 800 on prior donors stopped at 600
		Resolved		None	T291230 Add RiskScorer for Ingenico to SmashPig

Event Timeline

Ejegg created this task.Sep 16 2021, 11:06 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2021, 11:06 PM

Ejegg updated the task description. (Show Details)Sep 16 2021, 11:11 PM

Ejegg updated the task description. (Show Details)Sep 16 2021, 11:16 PM

Ejegg mentioned this in T291223: Add PendingTransaction::resolve API call that replicates Ingenico orphan rectifier.Sep 16 2021, 11:26 PM

Ejegg added a parent task: T276183: Epic: Automatically send status 800 on prior donors stopped at 600.Sep 16 2021, 11:37 PM

• DStrine moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Sep 20 2021, 7:43 PM

• DStrine added a project: fundraising sprint Roller Toaster.

• DStrine triaged this task as Medium priority.Sep 21 2021, 7:29 PM

XenoRyet added a project: fundraising sprint Screaming Goats Yelling Zoo.Sep 28 2021, 7:51 PM

XenoRyet added a project: Fundraising Sprint Technical debt house of horrors.Oct 12 2021, 8:19 PM

Looks like the Adyen\RiskScorer code is already pretty generic - we can just move it to a common namespace and add the default map to the Ingenico yaml

XenoRyet added a project: fundraising sprint Universal Cereal Bus.Oct 26 2021, 8:11 PM

Change 735428 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Move RiskScorer to Core namespace

https://gerrit.wikimedia.org/r/735428

gerritbot added a project: Patch-For-Review.Oct 28 2021, 6:47 PM

Ejegg moved this task from Backlog to Doing on the fundraising sprint Universal Cereal Bus board.Oct 28 2021, 8:21 PM

Change 735447 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Use risk scorer for Ingenico hosted checkout status

https://gerrit.wikimedia.org/r/735447

Ejegg moved this task from Doing to Review on the fundraising sprint Universal Cereal Bus board.Oct 28 2021, 8:34 PM

Change 735464 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Map tokens to RecurringPaymentToken field