Page MenuHomePhabricator

Core tests failing - "PHP Deprecated" output instead of PHPUnit deprecation
Closed, ResolvedPublic

Description

See https://gerrit.wikimedia.org/r/c/mediawiki/core/+/705477 which is an empty patch failing tests
https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php72-docker/63124/console

04:43:51 INFO:quibble.commands:>>> Start: PHPUnit unit tests
04:43:51 INFO:quibble.commands:PHPUnit unit tests
04:43:51 INFO:quibble.commands:composer phpunit:unit -- --exclude-group Broken,ParserFuzz,Stub --log-junit /workspace/log/junit-unit.xml
04:43:51 > phpunit --colors=always --testsuite=core:unit,extensions:unit,skins:unit '--exclude-group' 'Broken,ParserFuzz,Stub' '--log-junit' '/workspace/log/junit-unit.xml'
04:43:52 PHPUnit 8.5.21 by Sebastian Bergmann and contributors.
04:43:52 
04:43:52 ............................................PHP Deprecated:  Use of $wgDummy1 was deprecated in MediaWiki 1.30. [Called from PHPUnit\Framework\TestCase::runTest in /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php at line 1472] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:52 F..............    59 / 10177 (  0%)
04:43:52 ...........................................................   118 / 10177 (  1%)
04:43:52 ...........................................................   177 / 10177 (  1%)
04:43:52 ...........................................................   236 / 10177 (  2%)
04:43:52 ...........................................................   295 / 10177 (  2%)
04:43:52 ...........................................................   354 / 10177 (  3%)
04:43:52 ...........................................................   413 / 10177 (  4%)
04:43:52 ...........................................................   472 / 10177 (  4%)
04:43:52 ...........................................................   531 / 10177 (  5%)
04:43:52 ...........................................................   590 / 10177 (  5%)
04:43:52 ...........................................................   649 / 10177 (  6%)
04:43:52 ...........................................................   708 / 10177 (  6%)
04:43:52 ...........................................................   767 / 10177 (  7%)
04:43:52 ...........................................................   826 / 10177 (  8%)
04:43:52 ...........................................................   885 / 10177 (  8%)
04:43:52 ...........................................................   944 / 10177 (  9%)
04:43:52 ...........................................................  1003 / 10177 (  9%)
04:43:52 ...........................................................  1062 / 10177 ( 10%)
04:43:52 .....................................PHP Deprecated:  Hook FooActionComplete was deprecated in MediaWiki 1.35 but is registered in fake-extension.json in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:52 F.....................  1121 / 10177 ( 11%)
04:43:52 ...........................................................  1180 / 10177 ( 11%)
04:43:52 ...........................................................  1239 / 10177 ( 12%)
04:43:52 ...........................................................  1298 / 10177 ( 12%)
04:43:52 ...........................................................  1357 / 10177 ( 13%)
04:43:52 ...........................................................  1416 / 10177 ( 13%)
04:43:52 ...........................................................  1475 / 10177 ( 14%)
04:43:52 ...........................................................  1534 / 10177 ( 15%)
04:43:52 ...........................................................  1593 / 10177 ( 15%)
04:43:52 ...........................................................  1652 / 10177 ( 16%)
04:43:52 ...........................................................  1711 / 10177 ( 16%)
04:43:52 ...........................................................  1770 / 10177 ( 17%)
04:43:52 ...........................................................  1829 / 10177 ( 17%)
04:43:52 ...........................................................  1888 / 10177 ( 18%)
04:43:52 ...........................................................  1947 / 10177 ( 19%)
04:43:52 ...........................................................  2006 / 10177 ( 19%)
04:43:52 ...........................................................  2065 / 10177 ( 20%)
04:43:53 ...........................................................  2124 / 10177 ( 20%)
04:43:53 ...........................................................  2183 / 10177 ( 21%)
04:43:53 ...........................................................  2242 / 10177 ( 22%)
04:43:53 ...........................................................  2301 / 10177 ( 22%)
04:43:53 ...........................................................  2360 / 10177 ( 23%)
04:43:53 ...........................................................  2419 / 10177 ( 23%)
04:43:53 ...........................................................  2478 / 10177 ( 24%)
04:43:53 ...........................................................  2537 / 10177 ( 24%)
04:43:53 ...............................................PHP Deprecated:  Deprecated cross-wiki access to MediaWiki\Revision\RevisionRecord. Expected: the local wiki, Actual: 'acmewiki'. Pass expected $wikiId. [Called from MediaWiki\Revision\RevisionRecord::getId in /workspace/src/includes/Revision/RevisionRecord.php at line 280] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:53 F..FPHP Deprecated:  Deprecated cross-wiki access to MediaWiki\Revision\RevisionRecord. Expected: the local wiki, Actual: 'acmewiki'. Pass expected $wikiId. [Called from MediaWiki\Revision\RevisionRecord::getPageId in /workspace/src/includes/Revision/RevisionRecord.php at line 336] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:53 ..PHP Deprecated:  Deprecated cross-wiki access to MediaWiki\Revision\RevisionRecord. Expected: the local wiki, Actual: 'acmewiki'. Pass expected $wikiId. [Called from MediaWiki\Revision\RevisionRecord::getParentId in /workspace/src/includes/Revision/RevisionRecord.php at line 298] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:53 F.....  2596 / 10177 ( 25%)
04:43:53 ...........................................................  2655 / 10177 ( 26%)
04:43:53 ...........................PHP Deprecated:  Deprecated cross-wiki access to MediaWiki\Revision\RevisionRecord. Expected: the local wiki, Actual: 'acmewiki'. Pass expected $wikiId. [Called from MediaWiki\Revision\RevisionRecord::getId in /workspace/src/includes/Revision/RevisionRecord.php at line 280] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:53 F..PHP Deprecated:  Deprecated cross-wiki access to MediaWiki\Revision\RevisionRecord. Expected: the local wiki, Actual: 'acmewiki'. Pass expected $wikiId. [Called from MediaWiki\Revision\RevisionRecord::getPageId in /workspace/src/includes/Revision/RevisionRecord.php at line 336] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:53 F..PHP Deprecated:  Deprecated cross-wiki access to MediaWiki\Revision\RevisionRecord. Expected: the local wiki, Actual: 'acmewiki'. Pass expected $wikiId. [Called from MediaWiki\Revision\RevisionRecord::getParentId in /workspace/src/includes/Revision/RevisionRecord.php at line 298] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:53 F.........................  2714 / 10177 ( 26%)
04:43:53 ...........................................................  2773 / 10177 ( 27%)
04:43:53 ................FPHP Deprecated:  Deprecated cross-wiki access to MediaWiki\Revision\RevisionRecord. Expected: the local wiki, Actual: 'acmewiki'. Pass expected $wikiId. [Called from MediaWiki\Revision\RevisionRecord::getId in /workspace/src/includes/Revision/RevisionRecord.php at line 280] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:53 ..PHP Deprecated:  Deprecated cross-wiki access to MediaWiki\Revision\RevisionRecord. Expected: the local wiki, Actual: 'acmewiki'. Pass expected $wikiId. [Called from MediaWiki\Revision\RevisionRecord::getPageId in /workspace/src/includes/Revision/RevisionRecord.php at line 336] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:53 F..PHP Deprecated:  Deprecated cross-wiki access to MediaWiki\Revision\RevisionRecord. Expected: the local wiki, Actual: 'acmewiki'. Pass expected $wikiId. [Called from MediaWiki\Revision\RevisionRecord::getParentId in /workspace/src/includes/Revision/RevisionRecord.php at line 298] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:53 F....................................  2832 / 10177 ( 27%)
04:43:53 ........................................PHP Deprecated:  Deprecated cross-wiki access to MediaWiki\Revision\RevisionRecord. Expected: the local wiki, Actual: 'acmewiki'. Pass expected $wikiId. [Called from MediaWiki\Revision\RevisionRecord::getId in /workspace/src/includes/Revision/RevisionRecord.php at line 280] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:53 F..FPHP Deprecated:  Deprecated cross-wiki access to MediaWiki\Revision\RevisionRecord. Expected: the local wiki, Actual: 'acmewiki'. Pass expected $wikiId. [Called from MediaWiki\Revision\RevisionRecord::getPageId in /workspace/src/includes/Revision/RevisionRecord.php at line 336] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:53 ..PHP Deprecated:  Deprecated cross-wiki access to MediaWiki\Revision\RevisionRecord. Expected: the local wiki, Actual: 'acmewiki'. Pass expected $wikiId. [Called from MediaWiki\Revision\RevisionRecord::getParentId in /workspace/src/includes/Revision/RevisionRecord.php at line 298] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:53 F............  2891 / 10177 ( 28%)
04:43:53 ...........................................................  2950 / 10177 ( 28%)
04:43:53 ...........................................................  3009 / 10177 ( 29%)
04:43:53 ...........................................................  3068 / 10177 ( 30%)
04:43:53 ...........................................................  3127 / 10177 ( 30%)
04:43:53 ...........................................................  3186 / 10177 ( 31%)
04:43:53 ...............................................FPHP Deprecated:  Use of MediaWiki\Block\AbstractBlock::getTarget was deprecated in MediaWiki 1.37. [Called from MediaWiki\Tests\Unit\Block\AbstractBlockTest::testGetTarget_deprecated in /workspace/src/tests/phpunit/unit/includes/block/AbstractBlockTest.php at line 23] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:53 PHP Deprecated:  Use of MediaWiki\Block\AbstractBlock::getTargetAndType was deprecated in MediaWiki 1.37. [Called from MediaWiki\Tests\Unit\Block\AbstractBlockTest::testGetTargetAndType_deprecated in /workspace/src/tests/phpunit/unit/includes/block/AbstractBlockTest.php at line 36] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:53 PHP Deprecated:  Use of MediaWiki\Block\AbstractBlock::getTarget was deprecated in MediaWiki 1.37. [Called from MediaWiki\Block\AbstractBlock::getTargetAndType in /workspace/src/includes/block/AbstractBlock.php at line 325] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:53 F..........  3245 / 10177 ( 31%)
04:43:53 ...........................................................  3304 / 10177 ( 32%)
04:43:53 ...........................................................  3363 / 10177 ( 33%)
04:43:53 ...........................................................  3422 / 10177 ( 33%)
04:43:53 .............................................FPHP Deprecated:  Deprecated cross-wiki access to class@anonymous in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:53 FPHP Deprecated:  Deprecated cross-wiki access to class@anonymous in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:53 PHP Deprecated:  Deprecated cross-wiki access to class@anonymous in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:53 F...........  3481 / 10177 ( 34%)
04:43:53 ..FPHP Deprecated:  Use of TEST get 'test_property' was deprecated in MediaWiki DEPRECATED_VERSION. [Called from DeprecatablePropertyArrayTest::{closure} in /workspace/src/tests/phpunit/unit/includes/debug/DeprecatablePropertyArrayTest.php at line 39] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:53 FPHP Deprecated:  Use of TEST get 'callback' was deprecated in MediaWiki DEPRECATED_VERSION. [Called from DeprecatablePropertyArrayTest::{closure} in /workspace/src/tests/phpunit/unit/includes/debug/DeprecatablePropertyArrayTest.php at line 45] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:53 FPHP Deprecated:  Use of TEST exists 'test_property' was deprecated in MediaWiki DEPRECATED_VERSION. [Called from DeprecatablePropertyArrayTest::{closure} in /workspace/src/tests/phpunit/unit/includes/debug/DeprecatablePropertyArrayTest.php at line 51] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:53 PHP Deprecated:  Use of TEST unset 'test_property' was deprecated in MediaWiki DEPRECATED_VERSION. [Called from DeprecatablePropertyArrayTest::{closure} in /workspace/src/tests/phpunit/unit/includes/debug/DeprecatablePropertyArrayTest.php at line 57] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:53 F.....................................................  3540 / 10177 ( 34%)
04:43:53 ...........................................................  3599 / 10177 ( 35%)
04:43:53 ...........................................................  3658 / 10177 ( 35%)
04:43:53 ...........................................................  3717 / 10177 ( 36%)
04:43:53 .......................................SS..................  3776 / 10177 ( 37%)
04:43:53 ...........................................................  3835 / 10177 ( 37%)
04:43:53 ...........................................................  3894 / 10177 ( 38%)
04:43:53 ...........................................................  3953 / 10177 ( 38%)
04:43:53 ...........................................................  4012 / 10177 ( 39%)
04:43:53 ...........................................................  4071 / 10177 ( 40%)
04:43:53 ...........................................................  4130 / 10177 ( 40%)
04:43:53 ...........................................................  4189 / 10177 ( 41%)
04:43:53 ...........................................................  4248 / 10177 ( 41%)
04:43:54 ...........................................................  4307 / 10177 ( 42%)
04:43:54 ...........................................................  4366 / 10177 ( 42%)
04:43:54 ...........................................................  4425 / 10177 ( 43%)
04:43:54 ...........................................................  4484 / 10177 ( 44%)
04:43:54 ...........................................................  4543 / 10177 ( 44%)
04:43:54 ...........................................................  4602 / 10177 ( 45%)
04:43:54 ...........................................................  4661 / 10177 ( 45%)
04:43:54 ...........................................................  4720 / 10177 ( 46%)
04:43:54 ...........................................................  4779 / 10177 ( 46%)
04:43:54 ...........................................................  4838 / 10177 ( 47%)
04:43:54 ...........................................................  4897 / 10177 ( 48%)
04:43:54 ...........................................................  4956 / 10177 ( 48%)
04:43:54 ...........................................................  5015 / 10177 ( 49%)
04:43:54 ...........................................................  5074 / 10177 ( 49%)
04:43:54 ...........................................................  5133 / 10177 ( 50%)
04:43:54 ...........................................................  5192 / 10177 ( 51%)
04:43:54 ...........................................................  5251 / 10177 ( 51%)
04:43:54 ...........................................................  5310 / 10177 ( 52%)
04:43:54 ...........................................................  5369 / 10177 ( 52%)
04:43:54 ...........................................................  5428 / 10177 ( 53%)
04:43:54 ...........................................................  5487 / 10177 ( 53%)
04:43:54 ...........................................................  5546 / 10177 ( 54%)
04:43:54 ...........................................................  5605 / 10177 ( 55%)
04:43:54 ...........................................................  5664 / 10177 ( 55%)
04:43:54 ...........................................................  5723 / 10177 ( 56%)
04:43:54 ...........................................................  5782 / 10177 ( 56%)
04:43:54 ...........................................................  5841 / 10177 ( 57%)
04:43:54 ...........................................................  5900 / 10177 ( 57%)
04:43:54 ...........................................................  5959 / 10177 ( 58%)
04:43:54 ...........................................................  6018 / 10177 ( 59%)
04:43:54 ...........................................................  6077 / 10177 ( 59%)
04:43:54 ...........................................................  6136 / 10177 ( 60%)
04:43:54 ...........................................................  6195 / 10177 ( 60%)
04:43:54 ...........................................................  6254 / 10177 ( 61%)
04:43:54 ...........................................................  6313 / 10177 ( 62%)
04:43:54 ...........................................................  6372 / 10177 ( 62%)
04:43:54 ...........................................................  6431 / 10177 ( 63%)
04:43:54 ...........................................................  6490 / 10177 ( 63%)
04:43:54 ...........................................................  6549 / 10177 ( 64%)
04:43:54 ...........................................................  6608 / 10177 ( 64%)
04:43:54 ...........................................................  6667 / 10177 ( 65%)
04:43:54 ...........................................................  6726 / 10177 ( 66%)
04:43:54 .......................PHP Deprecated:  Use of Wikimedia\Rdbms\Database::update called with empty $conds was deprecated in MediaWiki 1.35. [Called from DatabaseSQLTest::testUpdateEmptyCondition in /workspace/src/tests/phpunit/unit/includes/libs/rdbms/database/DatabaseSQLTest.php at line 524] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:54 FPHP Deprecated:  Use of Wikimedia\Rdbms\Database::update called with empty $conds was deprecated in MediaWiki 1.35. [Called from DatabaseSQLTest::testUpdateEmptyCondition in /workspace/src/tests/phpunit/unit/includes/libs/rdbms/database/DatabaseSQLTest.php at line 524] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:54 FPHP Deprecated:  Use of Wikimedia\Rdbms\Database::update called with empty $conds was deprecated in MediaWiki 1.35. [Called from DatabaseSQLTest::testUpdateEmptyCondition in /workspace/src/tests/phpunit/unit/includes/libs/rdbms/database/DatabaseSQLTest.php at line 524] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:54 F.................................  6785 / 10177 ( 66%)
04:43:54 ...........................................................  6844 / 10177 ( 67%)
04:43:54 ...........................................................  6903 / 10177 ( 67%)
04:43:54 ...........................................................  6962 / 10177 ( 68%)
04:43:54 ...........................................................  7021 / 10177 ( 68%)
04:43:54 ...........................................................  7080 / 10177 ( 69%)
04:43:54 ...........................................................  7139 / 10177 ( 70%)
04:43:54 ...........................................................  7198 / 10177 ( 70%)
04:43:54 ...........................................................  7257 / 10177 ( 71%)
04:43:55 ...........................................................  7316 / 10177 ( 71%)
04:43:55 ...........................................................  7375 / 10177 ( 72%)
04:43:55 ...........................................................  7434 / 10177 ( 73%)
04:43:56 ...........................................................  7493 / 10177 ( 73%)
04:43:56 ...........................................................  7552 / 10177 ( 74%)
04:43:56 ...........................................................  7611 / 10177 ( 74%)
04:43:56 ...........................................................  7670 / 10177 ( 75%)
04:43:56 ...........................................................  7729 / 10177 ( 75%)
04:43:56 ...........................................................  7788 / 10177 ( 76%)
04:43:56 ...........................................................  7847 / 10177 ( 77%)
04:43:56 ...........................................................  7906 / 10177 ( 77%)
04:43:56 ...........................................................  7965 / 10177 ( 78%)
04:43:56 ...........................................................  8024 / 10177 ( 78%)
04:43:56 ...........................................................  8083 / 10177 ( 79%)
04:43:56 ...........................................................  8142 / 10177 ( 80%)
04:43:56 ...........................................................  8201 / 10177 ( 80%)
04:43:56 ...........................................................  8260 / 10177 ( 81%)
04:43:56 ...........................................................  8319 / 10177 ( 81%)
04:43:56 ...........................................................  8378 / 10177 ( 82%)
04:43:56 ...........................................................  8437 / 10177 ( 82%)
04:43:56 ...........................................................  8496 / 10177 ( 83%)
04:43:56 ...........................................................  8555 / 10177 ( 84%)
04:43:57 ...........................................................  8614 / 10177 ( 84%)
04:43:57 ...........................................................  8673 / 10177 ( 85%)
04:43:57 ...........................................................  8732 / 10177 ( 85%)
04:43:57 ...........................................................  8791 / 10177 ( 86%)
04:43:57 ...........................................................  8850 / 10177 ( 86%)
04:43:57 ...........................................................  8909 / 10177 ( 87%)
04:43:57 ...........................................................  8968 / 10177 ( 88%)
04:43:57 ...........................................................  9027 / 10177 ( 88%)
04:43:57 ...........................................................  9086 / 10177 ( 89%)
04:43:57 ...........................................................  9145 / 10177 ( 89%)
04:43:57 ...........................................................  9204 / 10177 ( 90%)
04:43:57 ...........................................................  9263 / 10177 ( 91%)
04:43:57 ...........................................................  9322 / 10177 ( 91%)
04:43:57 ...........................................................  9381 / 10177 ( 92%)
04:43:57 ...........................................................  9440 / 10177 ( 92%)
04:43:57 ...........................................................  9499 / 10177 ( 93%)
04:43:57 ...........................................................  9558 / 10177 ( 93%)
04:43:57 ..............................................PHP Deprecated:  Use of MediaWiki\User\UserIdentityValue::getActorId was deprecated in MediaWiki 1.36. [Called from UserIdentityValueTest::testGetActorIdLocalUIVForeignParam in /workspace/src/tests/phpunit/unit/includes/user/UserIdentityValueTest.php at line 19] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:57 FPHP Deprecated:  Use of MediaWiki\User\UserIdentityValue::getActorId was deprecated in MediaWiki 1.36. [Called from UserIdentityValueTest::testGetActorIdDeprecated in /workspace/src/tests/phpunit/unit/includes/user/UserIdentityValueTest.php at line 29] in /workspace/src/includes/debug/MWDebug.php on line 375
04:43:57 F...........  9617 / 10177 ( 94%)
04:43:57 ...........................................................  9676 / 10177 ( 95%)
04:43:57 ...........................................................  9735 / 10177 ( 95%)
04:43:57 ...........................................................  9794 / 10177 ( 96%)
04:43:57 ...........................................................  9853 / 10177 ( 96%)
04:43:57 ...........................................................  9912 / 10177 ( 97%)
04:43:57 ...........................................................  9971 / 10177 ( 97%)
04:43:57 ........................................................... 10030 / 10177 ( 98%)
04:43:57 ........................................................... 10089 / 10177 ( 99%)
04:43:57 ........................................................... 10148 / 10177 ( 99%)
04:43:57 .............................                               10177 / 10177 (100%)
04:43:57 
04:43:57 You should really speed up these slow tests (>50ms)...
04:43:57  1. 525ms to run Argon2PasswordTest:testPartialConfig
04:43:57  2. 378ms to run Pbkdf2PasswordTest:testCrypt with data set #0
04:43:57  3. 375ms to run Pbkdf2PasswordFallbackTest:testCrypt with data set #0
04:43:57  4. 181ms to run BcryptPasswordTest:testCrypt with data set #0
04:43:57  5. 141ms to run LayeredParameterizedPasswordTest:testLargeLayeredPartialUpdate
04:43:57  6. 74ms to run LayeredParameterizedPasswordTest:testHashing with data set #0
04:43:57  7. 65ms to run DatabaseSQLTest:testInsertSelectBatching
04:43:57  8. 50ms to run MediaWiki\Tests\HookContainer\HookRunnerTest:testAllMethodsInheritedFromInterface with data set "MediaWiki\HookContainer\HookRunner"
04:43:57 
04:43:57 
04:43:57 Time: 6.34 seconds, Memory: 181.40 MB
04:43:57 
04:43:57 There were 28 failures:
04:43:57 
04:43:57 1) DeprecatedGlobalTest::testWarning
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 2) MediaWiki\HookContainer\HookContainerTest::testEmitDeprecationWarnings
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 3) MediaWiki\Tests\Unit\Revision\MutableRevisionRecordTest::testGetIdTriggerDeprecatedWarning
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 4) MediaWiki\Tests\Unit\Revision\MutableRevisionRecordTest::testGetPageIdTriggerDeprecatedWarning
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 5) MediaWiki\Tests\Unit\Revision\MutableRevisionRecordTest::testGetParentIdTriggerDeprecatedWarning
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 6) MediaWiki\Tests\Unit\Revision\RevisionArchiveRecordTest::testGetIdTriggerDeprecatedWarning
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 7) MediaWiki\Tests\Unit\Revision\RevisionArchiveRecordTest::testGetPageIdTriggerDeprecatedWarning
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 8) MediaWiki\Tests\Unit\Revision\RevisionArchiveRecordTest::testGetParentIdTriggerDeprecatedWarning
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 9) MediaWiki\Tests\Unit\Revision\RevisionStoreCacheRecordTest::testGetIdTriggerDeprecatedWarning
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 10) MediaWiki\Tests\Unit\Revision\RevisionStoreCacheRecordTest::testGetPageIdTriggerDeprecatedWarning
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 11) MediaWiki\Tests\Unit\Revision\RevisionStoreCacheRecordTest::testGetParentIdTriggerDeprecatedWarning
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 12) MediaWiki\Tests\Unit\Revision\RevisionStoreRecordTest::testGetIdTriggerDeprecatedWarning
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 13) MediaWiki\Tests\Unit\Revision\RevisionStoreRecordTest::testGetPageIdTriggerDeprecatedWarning
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 14) MediaWiki\Tests\Unit\Revision\RevisionStoreRecordTest::testGetParentIdTriggerDeprecatedWarning
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 15) MediaWiki\Tests\Unit\Block\AbstractBlockTest::testGetTarget_deprecated
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 16) MediaWiki\Tests\Unit\Block\AbstractBlockTest::testGetTargetAndType_deprecated
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 17) MediaWiki\Tests\Unit\DAO\WikiAwareEntityTraitTest::testDeprecateInvalidCrossWikiMismatch with data set "acme-noacme" ('acmewiki', 'noacmewiki')
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 18) MediaWiki\Tests\Unit\DAO\WikiAwareEntityTraitTest::testDeprecateInvalidCrossWikiMismatch with data set "local-acme" (false, 'acmewiki')
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 19) MediaWiki\Tests\Unit\DAO\WikiAwareEntityTraitTest::testDeprecateInvalidCrossWikiMismatch with data set "acme-local" ('amewiki', false)
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 20) DeprecatablePropertyArrayTest::testDeprecationWarning with data set "get" (Closure Object (...), 'TEST get 'test_property'')
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 21) DeprecatablePropertyArrayTest::testDeprecationWarning with data set "get, callback" (Closure Object (...), 'TEST get 'callback'')
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 22) DeprecatablePropertyArrayTest::testDeprecationWarning with data set "exists" (Closure Object (...), 'TEST exists 'test_property'')
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 23) DeprecatablePropertyArrayTest::testDeprecationWarning with data set "unset" (Closure Object (...), 'TEST unset 'test_property'')
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 24) DatabaseSQLTest::testUpdateEmptyCondition with data set #0 (array('table', array('text', 'text2'), null))
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 25) DatabaseSQLTest::testUpdateEmptyCondition with data set #1 (array('table', array('field = other', 'text2'), array()))
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 26) DatabaseSQLTest::testUpdateEmptyCondition with data set #2 (array('table', array('field = other', 'text2'), ''))
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 27) UserIdentityValueTest::testGetActorIdLocalUIVForeignParam
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 28) UserIdentityValueTest::testGetActorIdDeprecated
04:43:57 Failed asserting that exception of type "PHPUnit\Framework\Error\Deprecated" is thrown.
04:43:57 
04:43:57 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108
04:43:57 
04:43:57 FAILURES!
04:43:57 Tests: 10177, Assertions: 28557, Failures: 28, Skipped: 2.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 triaged this task as Unbreak Now! priority.Sat, Sep 25, 8:48 AM
DannyS712 moved this task from Unsorted to Reports on the User-DannyS712 board.

I compared the raw text output of a good build ( https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php72-docker/63121/console ) versus a failing one ( https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php72-docker/63124/console ). Cleaned up the few variant bits like the CI agent hostname, build number etc. One of the difference that stands out:

- PHPUnit 8.5.20 by Sebastian Bergmann and contributors.
+ PHPUnit 8.5.21 by Sebastian Bergmann and contributors.

And that is the sole dependency that has changed when running composer install.

Changelog from https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-8.5.md#8521---2021-09-25

Changed

  • PHPUnit no longer converts PHP deprecations to exceptions by default (configure convertDeprecationsToExceptions="true" to enable this)
  • The PHPUnit XML configuration file generator now configures convertDeprecationsToExceptions="true"

Fixed

#4772: TestDox HTML report not displayed correctly when browser has custom colour settings

That comes from https://github.com/sebastianbergmann/phpunit/commit/fac02620f6b38ae54d47fe840e0095e68226a56c

So either pin with <8.5.21 or add that convertDeprecationsToExceptions setting which sounds like a feature we definitely want.

Change 723688 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] PHPUnit: enable convertDeprecationsToExceptions

https://gerrit.wikimedia.org/r/723688

Change 723668 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/core@master] phpunit: explicitly fail on deprecation

https://gerrit.wikimedia.org/r/723668

Change 723668 abandoned by Hashar:

[mediawiki/core@master] phpunit: explicitly fail on deprecation

Reason:

In favor of https://gerrit.wikimedia.org/r/723688 by DannyS712 ;)

https://gerrit.wikimedia.org/r/723668

Change 723688 merged by jenkins-bot:

[mediawiki/core@master] PHPUnit: enable convertDeprecationsToExceptions

https://gerrit.wikimedia.org/r/723688

Change 723693 had a related patch set uploaded (by Zabe; author: DannyS712):

[mediawiki/core@REL1_37] PHPUnit: enable convertDeprecationsToExceptions

https://gerrit.wikimedia.org/r/723693

Change 723695 had a related patch set uploaded (by Zabe; author: DannyS712):

[mediawiki/core@REL1_36] PHPUnit: enable convertDeprecationsToExceptions

https://gerrit.wikimedia.org/r/723695

Change 723696 had a related patch set uploaded (by Zabe; author: DannyS712):

[mediawiki/core@REL1_35] PHPUnit: enable convertDeprecationsToExceptions

https://gerrit.wikimedia.org/r/723696

One of the difference that stands out:

- PHPUnit 8.5.20 by Sebastian Bergmann and contributors.
+ PHPUnit 8.5.21 by Sebastian Bergmann and contributors.

Changelog from https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-8.5.md#8521---2021-09-25

Changed

  • PHPUnit no longer converts PHP deprecations to exceptions by default (configure convertDeprecationsToExceptions="true" to enable this)
  • The PHPUnit XML configuration file generator now configures convertDeprecationsToExceptions="true"

Fixed

#4772: TestDox HTML report not displayed correctly when browser has custom colour settings

That comes from https://github.com/sebastianbergmann/phpunit/commit/fac02620f6b38ae54d47fe840e0095e68226a56c

For more context about the sudden change, there was a discussion on the php-internals list about "BC breaking changes in PHP 8.1". In response to that discussion, Sebastian Bergmann said (in https://externals.io/message/116127#116154) that:

The next releases of PHPUnit 8.5 and PHPUnit 9.5 will change this.

Change 723696 merged by jenkins-bot:

[mediawiki/core@REL1_35] PHPUnit: enable convertDeprecationsToExceptions

https://gerrit.wikimedia.org/r/723696

Change 723695 merged by jenkins-bot:

[mediawiki/core@REL1_36] PHPUnit: enable convertDeprecationsToExceptions

https://gerrit.wikimedia.org/r/723695

Change 723693 merged by jenkins-bot:

[mediawiki/core@REL1_37] PHPUnit: enable convertDeprecationsToExceptions

https://gerrit.wikimedia.org/r/723693

Zabe assigned this task to DannyS712.

CI passes again.

For more context about the sudden change, there was a discussion on the php-internals list about "BC breaking changes in PHP 8.1". In response to that discussion, Sebastian Bergmann said (in https://externals.io/message/116127#116154) that:

The next releases of PHPUnit 8.5 and PHPUnit 9.5 will change this.

Thank you for the context!

@Zabe & @DannyS712 thank you for the backports!

Change 723703 had a related patch set uploaded (by Zabe; author: DannyS712):

[mediawiki/core@wmf/1.38.0-wmf.1] PHPUnit: enable convertDeprecationsToExceptions

https://gerrit.wikimedia.org/r/723703

Change 723703 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.1] PHPUnit: enable convertDeprecationsToExceptions

https://gerrit.wikimedia.org/r/723703