Page MenuHomePhabricator
Create Task
Maniphest T291824

Notification icon missing on cx skin
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
santhosh
Authored By
• Jpita
Sep 27 2021, 11:33 AM
Tags
Referenced Files
F34671680: Screenshot 2021-10-04 at 14.10.27.png
Oct 4 2021, 12:13 PM
F34671676: Screenshot 2021-10-04 at 14.11.40.png
Oct 4 2021, 12:13 PM
F34671678: Screenshot 2021-10-04 at 14.11.33.png
Oct 4 2021, 12:13 PM
F34659185: image.png
Sep 27 2021, 11:33 AM
F34659183: image.png
Sep 27 2021, 11:33 AM
F34659187: image.png
Sep 27 2021, 11:33 AM
Subscribers
Aklapper
• Jpita
Pginer-WMF

Description

we're missing the notification icon on cx/sx

cx skinvectorvector legacy
image.png (136×446 px, 5 KB)
image.png (186×596 px, 6 KB)
image.png (98×394 px, 5 KB)

Details

SubjectRepoBranchLines +/-
CX Skin: Fix missing icons in toolbarmediawiki/extensions/ContentTranslationmaster+0 -1
Customize query in gerrit

Event Timeline

• Jpita created this task.Sep 27 2021, 11:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2021, 11:33 AM
Pginer-WMF renamed this task from issue on cx skin to Notification icon missing on cx skin.Sep 27 2021, 11:35 AM
Pginer-WMF triaged this task as Medium priority.
Pginer-WMF edited projects, added ContentTranslation; removed SectionTranslation.
Pginer-WMF added a project: Language-Team (Language-2021-July-September).
gerritbot added a comment.Sep 27 2021, 12:00 PM

Change 724048 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX Skin: Fix missing icons in toolbar

https://gerrit.wikimedia.org/r/724048

gerritbot added a project: Patch-For-Review.Sep 27 2021, 12:00 PM
santhosh claimed this task.Sep 27 2021, 12:01 PM
gerritbot added a comment.Sep 27 2021, 12:23 PM

Change 724048 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX Skin: Fix missing icons in toolbar

https://gerrit.wikimedia.org/r/724048

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 27 2021, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 27 2021, 1:11 PM
Nikerabbit moved this task from Quarter Backlog to Needs QA on the Language-Team (Language-2021-July-September) board.Sep 28 2021, 7:50 AM
Pginer-WMF edited projects, added Language-Team (Language-2021-October-December); removed Language-Team (Language-2021-July-September).Oct 1 2021, 12:31 PM
Pginer-WMF moved this task from Quarter Backlog to Needs QA on the Language-Team (Language-2021-October-December) board.
• Jpita moved this task from Needs QA to Pending input for QA on the Language-Team (Language-2021-October-December) board.EditedOct 4 2021, 12:13 PM

cx skin looks a bit different from both legacy vector and new vector, is this ok @Pginer-WMF ?

cxlegacy vectornew vector
Screenshot 2021-10-04 at 14.11.40.png (138×414 px, 10 KB)
Screenshot 2021-10-04 at 14.11.33.png (84×362 px, 10 KB)
Screenshot 2021-10-04 at 14.10.27.png (184×492 px, 10 KB)
Pginer-WMF added a comment.Oct 4 2021, 12:18 PM
In T291824#7398182, @Jpita wrote:

cx skin looks a bit different from both legacy vector and new vector, is this ok @Pginer-WMF ?

cxlegacy vectornew vector
Screenshot 2021-10-04 at 14.11.40.png (138×414 px, 10 KB)
Screenshot 2021-10-04 at 14.11.33.png (84×362 px, 10 KB)
Screenshot 2021-10-04 at 14.10.27.png (184×492 px, 10 KB)

The ideal would be to converge towards the new vector over time. But that can be done in future tickets. For now, I think it makes sense to keep the task focused on restoring the missing functionality even if it is not aligned with the latest desktop improvements.

• Jpita moved this task from Pending input for QA to Done on the Language-Team (Language-2021-October-December) board.Oct 4 2021, 12:37 PM
Pginer-WMF closed this task as Resolved.Oct 4 2021, 2:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits