Description

Steps to reproduce

Enable live preview on multilingual Wikisource.
Go to a page using Hungarian interface language, e.g. https://wikisource.org/w/index.php?title=Foobar&action=edit&uselang=hu
Click preview.

Actual result

The preview note contains a line break, caused by a paragraph with comment .

Expected result

The preview note doesn’t contain any line breaks, just like when not using the live preview.

Additional information

Multilingual Wikisource is set to be special in rOMWC wmf-config/config/sourceswiki.yaml, so its main namespace is in $wgExtraSignatureNamespaces (although it makes no sense, since it’s a content project, and its main namespace contains works, not dicussions…).

Details

	Subject	Repo	Branch	Lines +/-
	Set interface flag when parsing 'previewnote' for live preview	mediawiki/core	master	+2 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		matmarex	T291833 Fix regressions caused by DiscussionTools page transformations
Resolved		matmarex	T291601 Re-evaluate Message 'interface' and 'title' flags for messages bundled via load.php, remove "Dwimmerlaik"
Resolved	BUG REPORT	ppelberg	T291949 Line break in live preview note

Event Timeline

Tacsipacsi created this task.Sep 28 2021, 2:02 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 28 2021, 2:02 PM

Change 724484 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Set interface flag when parsing 'previewnote' for live preview

https://gerrit.wikimedia.org/r/724484

gerritbot added a project: Patch-For-Review.Sep 28 2021, 5:57 PM

This would also be fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/724170, or by fixing T291601.

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Sep 28 2021, 5:59 PM

Change 724484 merged by jenkins-bot:

[mediawiki/core@master] Set interface flag when parsing 'previewnote' for live preview

https://gerrit.wikimedia.org/r/724484

Maintenance_bot removed a project: Patch-For-Review.Sep 28 2021, 8:10 PM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Sep 28 2021, 9:00 PM

I'm not planning to backport, it seems like a trivial problem.

EAkinloose subscribed.Oct 5 2021, 3:37 PM

This works fine. Result is as expected:

Screenshot 2021-10-06 at 18.05.52.png (1×2 px, 518 KB)

EAkinloose edited projects, added Verified; removed Editing QA.Oct 6 2021, 5:09 PM

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.

matmarex added a parent task: T291601: Re-evaluate Message 'interface' and 'title' flags for messages bundled via load.php, remove "Dwimmerlaik".Oct 12 2021, 3:48 PM

matmarex removed a parent task: T291833: Fix regressions caused by DiscussionTools page transformations.

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Oct 18 2021, 4:41 AM

ppelberg closed this task as Resolved.Nov 6 2021, 1:10 AM

ppelberg claimed this task.

	F34676317: Screenshot 2021-10-06 at 18.05.52.png
	Oct 6 2021, 5:06 PM

	F34660541: DT preview note with line break.png
	Sep 28 2021, 2:02 PM

	F34660543: DT preview note without line break.png
	Sep 28 2021, 2:02 PM

Line break in live preview noteClosed, ResolvedPublicBUG REPORTActions