Page MenuHomePhabricator

Line break in live preview note
Closed, ResolvedPublicBUG REPORT


Steps to reproduce

  1. Enable live preview on multilingual Wikisource.
  2. Go to a page using Hungarian interface language, e.g.
  3. Click preview.

Actual result

  1. The preview note contains a line break, caused by a paragraph with comment <!-- DiscussionTools addDiscussionTools called -->.
    DT preview note with line break.png (398×665 px, 55 KB)

Expected result

  1. The preview note doesn’t contain any line breaks, just like when not using the live preview.
    DT preview note without line break.png (400×665 px, 59 KB)

Additional information

  • Multilingual Wikisource is set to be special in rOMWC wmf-config/config/sourceswiki.yaml, so its main namespace is in $wgExtraSignatureNamespaces (although it makes no sense, since it’s a content project, and its main namespace contains works, not dicussions…).

Event Timeline

Change 724484 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Set interface flag when parsing 'previewnote' for live preview

Change 724484 merged by jenkins-bot:

[mediawiki/core@master] Set interface flag when parsing 'previewnote' for live preview

matmarex added a project: Editing QA.

I'm not planning to backport, it seems like a trivial problem.

This works fine. Result is as expected:

Screenshot 2021-10-06 at 18.05.52.png (1×2 px, 518 KB)

ppelberg claimed this task.