Page MenuHomePhabricator
Create Task
Maniphest T292107

Regression: Search within pages flushed left
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
ovasileva
Authored By
Jdlrobson
Sep 29 2021, 6:59 PM
Tags
Referenced Files
F34707512: Screen Shot 2021-10-22 at 6.59.19 PM.png
Oct 23 2021, 2:01 AM
F34707514: Screen Shot 2021-10-22 at 6.57.12 PM.png
Oct 23 2021, 2:01 AM
F34707511: Screen Shot 2021-10-22 at 6.57.53 PM.png
Oct 23 2021, 2:01 AM
F34707513: Screen Shot 2021-10-22 at 6.59.40 PM.png
Oct 23 2021, 2:01 AM
F34702217: Screen Shot 2021-10-20 at 1.21.54 PM.png
Oct 20 2021, 8:26 PM
F34702216: Screen Shot 2021-10-20 at 1.21.01 PM.png
Oct 20 2021, 8:26 PM
F34702218: Screen Shot 2021-10-20 at 1.20.23 PM.png
Oct 20 2021, 8:26 PM
F34677698: Screen Shot 2021-10-07 at 10.12.02 AM.png
Oct 7 2021, 5:14 PM
View All 12 Files
Subscribers
Aklapper
• alexhollender_WMF
bwang
Edtadros
Edu
Jdlrobson
• nray
ovasileva

Description

Actual:

Screen Shot 2021-09-29 at 11.54.23 AM.png (642×902 px, 86 KB)

Expected:

Screen Shot 2021-09-29 at 11.59.52 AM.png (540×788 px, 38 KB)

Seen on mediawki.org

Will be on en.wikipedia.org on Thursday

QA Results - Beta

ACStatusDetails
1✅T292107#7407264

QA Results - Prod

ACStatusDetails
1✅T292107#7452859

Details

SubjectRepoBranchLines +/-
Remove whitespace to right of search input in overlaymediawiki/skins/MinervaNeuemaster+5 -2
Fix search within pages alignmentmediawiki/extensions/MobileFrontendwmf/1.38.0-wmf.2+13 -8
Fix search within pages alignmentmediawiki/extensions/MobileFrontendmaster+13 -8
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Sep 29 2021, 6:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 29 2021, 6:59 PM
Jdlrobson updated the task description. (Show Details)Sep 29 2021, 7:00 PM
gerritbot added a comment.Sep 29 2021, 7:00 PM

Change 724819 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Fix search within pages alignment

https://gerrit.wikimedia.org/r/724819

gerritbot added a project: Patch-For-Review.Sep 29 2021, 7:00 PM
ovasileva triaged this task as High priority.Sep 29 2021, 9:37 PM
ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.
Jdlrobson assigned this task to • nray.Sep 30 2021, 2:31 PM
Jdlrobson moved this task from Needs Analysis to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edu subscribed.Sep 30 2021, 5:05 PM
gerritbot added a comment.Sep 30 2021, 5:58 PM

Change 724819 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Fix search within pages alignment

https://gerrit.wikimedia.org/r/724819

gerritbot added a comment.Sep 30 2021, 6:05 PM

Change 724979 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@wmf/1.38.0-wmf.2] Fix search within pages alignment

https://gerrit.wikimedia.org/r/724979

gerritbot added a comment.Sep 30 2021, 6:34 PM

Change 724979 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@wmf/1.38.0-wmf.2] Fix search within pages alignment

https://gerrit.wikimedia.org/r/724979

Stashbot added a comment.Sep 30 2021, 7:07 PM

Mentioned in SAL (#wikimedia-operations) [2021-09-30T19:07:51Z] <thcipriani@deploy1002> Synchronized php-1.38.0-wmf.2/extensions/MobileFrontend: Backport: [[gerrit:724979|Fix search within pages alignment (T292107)]] (duration: 01m 09s)

Jdlrobson reassigned this task from • nray to Edtadros.Sep 30 2021, 8:41 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson added a subscriber: • nray.
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Oct 1 2021, 5:21 PM
Edtadros reassigned this task from Edtadros to Jdlrobson.Oct 7 2021, 2:40 AM
Edtadros moved this task from QA to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros subscribed.

Test Result - Beta

Status: ❌ Fail
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

❌ AC1: In MinervaNeue, the search icon should not be flush left.

This looks right in Mobile View:

en.m.wikipedia.beta.wmflabs.org_w_index.php_title=Dog&useskin=minerva(iPhone 11 Pro Max).png (2×1 px, 642 KB)

But not in desktop Minerva:

Screen Shot 2021-10-06 at 7.33.32 PM.png (685×1 px, 169 KB)

Edtadros updated the task description. (Show Details)Oct 7 2021, 2:41 AM
Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Oct 7 2021, 5:14 PM

In January 2021 it looked like:

Screen Shot 2021-10-07 at 10.12.02 AM.png (504×820 px, 54 KB)

So I think search within pages is flushed left correctly here. I'll add a follow up for the random whitespace.

gerritbot added a comment.Oct 7 2021, 5:41 PM

Change 727436 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Remove whitespace to right of search input in overlay

https://gerrit.wikimedia.org/r/727436

Jdlrobson removed Jdlrobson as the assignee of this task.Oct 7 2021, 5:43 PM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
bwang claimed this task.Oct 12 2021, 3:10 PM
gerritbot added a comment.Oct 12 2021, 4:50 PM

Change 727436 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove whitespace to right of search input in overlay

https://gerrit.wikimedia.org/r/727436

Jdlrobson reassigned this task from bwang to Edtadros.Oct 12 2021, 4:55 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson added a subscriber: bwang.
ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.5; 2021-10-19); removed MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Oct 12 2021, 5:00 PM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Oct 20 2021, 8:26 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: In MinervaNeue, the search icon should not (see T292107#7409577) be flush left.

Screen Shot 2021-10-20 at 1.21.01 PM.png (2×1 px, 547 KB)

Screen Shot 2021-10-20 at 1.21.54 PM.png (2×1 px, 589 KB)

Screen Shot 2021-10-20 at 1.20.23 PM.png (2×2 px, 610 KB)

Edtadros reassigned this task from Edtadros to ovasileva.Oct 23 2021, 2:01 AM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: In MinervaNeue, the search icon should not (see T292107#7409577) be flush left.

Screen Shot 2021-10-22 at 6.57.53 PM.png (2×1 px, 904 KB)

Screen Shot 2021-10-22 at 6.59.19 PM.png (2×1 px, 904 KB)

Screen Shot 2021-10-22 at 6.59.40 PM.png (2×1 px, 962 KB)

Screen Shot 2021-10-22 at 6.57.12 PM.png (2×1 px, 971 KB)

Edtadros updated the task description. (Show Details)Oct 23 2021, 2:02 AM
ovasileva closed this task as Resolved.Oct 28 2021, 2:06 PM

Looks good!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL