Page MenuHomePhabricator

Regression: Search within pages flushed left
Closed, ResolvedPublicBUG REPORT

Description

Actual:

Screen Shot 2021-09-29 at 11.54.23 AM.png (642×902 px, 86 KB)

Expected:

Screen Shot 2021-09-29 at 11.59.52 AM.png (540×788 px, 38 KB)

Seen on mediawki.org

Will be on en.wikipedia.org on Thursday

QA Results - Beta

ACStatusDetails
1T292107#7407264

QA Results - Prod

ACStatusDetails
1T292107#7452859

Event Timeline

Change 724819 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Fix search within pages alignment

https://gerrit.wikimedia.org/r/724819

Change 724819 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Fix search within pages alignment

https://gerrit.wikimedia.org/r/724819

Change 724979 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@wmf/1.38.0-wmf.2] Fix search within pages alignment

https://gerrit.wikimedia.org/r/724979

Change 724979 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@wmf/1.38.0-wmf.2] Fix search within pages alignment

https://gerrit.wikimedia.org/r/724979

Mentioned in SAL (#wikimedia-operations) [2021-09-30T19:07:51Z] <thcipriani@deploy1002> Synchronized php-1.38.0-wmf.2/extensions/MobileFrontend: Backport: [[gerrit:724979|Fix search within pages alignment (T292107)]] (duration: 01m 09s)

Edtadros added a subscriber: Edtadros.

Test Result - Beta

Status: ❌ Fail
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

❌ AC1: In MinervaNeue, the search icon should not be flush left.

This looks right in Mobile View:

en.m.wikipedia.beta.wmflabs.org_w_index.php_title=Dog&useskin=minerva(iPhone 11 Pro Max).png (2×1 px, 642 KB)

But not in desktop Minerva:

Screen Shot 2021-10-06 at 7.33.32 PM.png (685×1 px, 169 KB)

In January 2021 it looked like:

Screen Shot 2021-10-07 at 10.12.02 AM.png (504×820 px, 54 KB)

So I think search within pages is flushed left correctly here. I'll add a follow up for the random whitespace.

Change 727436 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Remove whitespace to right of search input in overlay

https://gerrit.wikimedia.org/r/727436

Change 727436 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove whitespace to right of search input in overlay

https://gerrit.wikimedia.org/r/727436

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: In MinervaNeue, the search icon should not (see T292107#7409577) be flush left.

Screen Shot 2021-10-20 at 1.21.01 PM.png (2×1 px, 547 KB)

Screen Shot 2021-10-20 at 1.21.54 PM.png (2×1 px, 589 KB)

Screen Shot 2021-10-20 at 1.20.23 PM.png (2×2 px, 610 KB)

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: In MinervaNeue, the search icon should not (see T292107#7409577) be flush left.

Screen Shot 2021-10-22 at 6.57.53 PM.png (2×1 px, 904 KB)

Screen Shot 2021-10-22 at 6.59.19 PM.png (2×1 px, 904 KB)

Screen Shot 2021-10-22 at 6.59.40 PM.png (2×1 px, 962 KB)

Screen Shot 2021-10-22 at 6.57.12 PM.png (2×1 px, 971 KB)