Page MenuHomePhabricator
Create Task
Maniphest T292557

Sticky header: Add user page link to user menu in sticky header
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Background

The sticky header should provide access to the user page

Acceptance criteria

  • Add user page link into the sticky header within the user menu

Prototype

https://di-community-round-2.web.app/Audre_Lorde

QA Results - Beta

ACStatusDetails
1✅T292557#7475283

QA Results - Prod

ACStatusDetails
1✅T292557#7495867

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Sticky header: Add user page link to user menu in sticky headermediawiki/skins/Vectormaster+15 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

ovasileva created this task.Oct 5 2021, 4:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2021, 4:45 PM
ovasileva triaged this task as High priority.Oct 5 2021, 4:45 PM
ovasileva mentioned this in T289816: Sticky header: Add user menu to sticky header.
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Oct 5 2021, 4:58 PM
Jdlrobson subscribed.

This is a one line change added to the right place:

$('#p-personal-sticky-header .user-links-collapsible-item').removeClass('user-links-collapsible-item')
XanonymusX subscribed.Oct 5 2021, 9:21 PM
ovasileva updated the task description. (Show Details)Oct 6 2021, 4:43 PM
ovasileva set the point value for this task to 2.
ovasileva moved this task from Upcoming to Ready for Development on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdlrobson claimed this task.Oct 6 2021, 8:15 PM
Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdlrobson removed Jdlrobson as the assignee of this task.Oct 14 2021, 3:00 PM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Oct 14 2021, 5:01 PM

Change 730858 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Sticky header: Add user page link to user menu in sticky header

https://gerrit.wikimedia.org/r/730858

gerritbot added a project: Patch-For-Review.Oct 14 2021, 5:01 PM
Jdrewniak claimed this task.Oct 15 2021, 11:06 PM
Jdlrobson moved this task from Code Review to Blocked on Others on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Oct 21 2021, 1:07 AM
Jdlrobson moved this task from Blocked on Others to Code Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Oct 21 2021, 4:13 PM
Jdrewniak reassigned this task from Jdrewniak to Edtadros.Oct 21 2021, 5:16 PM
Jdrewniak moved this task from Code Review to QA on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Jdrewniak subscribed.
gerritbot added a comment.Oct 21 2021, 5:39 PM

Change 730858 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Sticky header: Add user page link to user menu in sticky header

https://gerrit.wikimedia.org/r/730858

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Oct 21 2021, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 21 2021, 6:10 PM
XanonymusX added a comment.Oct 24 2021, 3:12 PM

While testing this on beta, I was wondering whether users might start to expect finding the user page also inside the regular user menu, once they are used to the user menu of the sticky header. I honestly find the current design with the separate user page link to be less intuitive, so maybe it is worth considering a more consistent solution (involving also the notification icons, probably).

Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.Nov 2 2021, 4:44 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: User page link is present in sticky header within the user menu

Screen Recording 2021-11-02 at 9.43.07 AM.mov.gif (910×814 px, 577 KB)

Edtadros updated the task description. (Show Details)Nov 2 2021, 4:53 PM
ovasileva added a parent task: T292304: [Goal] Deploy sticky header to pilot wikis.Nov 3 2021, 2:38 PM
Edtadros reassigned this task from Edtadros to ovasileva.Nov 10 2021, 2:24 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-FY-2021-22) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: User page link is present in sticky header within the user menu

Screen Recording 2021-11-10 at 6.23.31 AM.mov.gif (950×930 px, 1 MB)

Edtadros updated the task description. (Show Details)Nov 10 2021, 2:26 PM
ovasileva closed this task as Resolved.Nov 11 2021, 10:42 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits