Page MenuHomePhabricator

Full screen map fails to handle style elements in caption text properly
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Go here
  • Click on the map

What happens?:
The text along the bottom is "Map of Pomona College's campus[130][131] .mw-parser-output .div-col{margin-top:0.3em;column-width:30em}.mw-parser-output..."

What should have happened instead?:
It should display just "Map of Pomona College's campus[130][131]" or something else that's not spilling out the inner guts of the code.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
First reported at en-WP VPT here

Event Timeline

Usually this is caused by using Node.textContent where HTMLElement.innerText should be used.

Pikne renamed this task from Mapframe lightbox fails to handle style elements properly to Full screen map fails to handle style elements in caption text properly.Oct 6 2021, 11:04 AM
Pikne edited projects, added Maps (Kartographer); removed Maps.
Pikne added subscribers: Framawiki, Pikne, TheDJ and 2 others.

Change 730333 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/Kartographer@master] Map dialog should not show TemplateStyles contents

https://gerrit.wikimedia.org/r/730333

Change 730333 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Map dialog should not copy TemplateStyles CSS from captions

https://gerrit.wikimedia.org/r/730333

TheDJ claimed this task.