Page MenuHomePhabricator
Create Task
Maniphest T293335

Cannot convert undefined or null to object when trying to restorePageState
Closed, DuplicatePublicPRODUCTION ERROR
Actions

Description

Error

at https://commons.wikimedia.org/w/load.php?lang=en&modules=jquery%2Cmediasearch&skin=vector&version=1in2g:229:431
at a.restorePageState https://commons.wikimedia.org/w/load.php?lang=en&modules=jquery%2Cmediasearch&skin=vector&version=1in2g:229:401
at <anonymous>:292:566
at <anonymous>:294:59
at <anonymous>:294:39
at a._withCommit <anonymous>:295:563
at a.commit <anonymous>:294:14

normalized_message
Cannot convert undefined or null to object
Impact
  • There should not be any UI impact, apart from errors being triggered on production
Notes

The error is triggered when an user does NOT have any information stored in session storage (mw-mediasearch).

Details

SubjectRepoBranchLines +/-
Refactor the URI.querymediawiki/extensions/MediaSearchwmf/1.38.0-wmf.5+684 -187
Refactor the URI.querymediawiki/extensions/MediaSearchwmf/1.38.0-wmf.4+684 -187
Cannot convert undefined or null to object on restorePageStatemediawiki/extensions/MediaSearchmaster+6 -5
Refactor the URI.querymediawiki/extensions/MediaSearchmaster+684 -187
Customize query in gerrit

Related Objects

Event Timeline

SimoneThisDot created this task.Oct 14 2021, 9:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 14 2021, 9:11 AM
SimoneThisDot moved this task from Incoming to Doing on the Structured-Data-Backlog (Current Work) board.Oct 14 2021, 9:12 AM
gerritbot added a comment.Oct 14 2021, 9:29 AM

Change 730715 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@master] Cannot convert undefined or null to object on restorePageState

https://gerrit.wikimedia.org/r/730715

gerritbot added a project: Patch-For-Review.Oct 14 2021, 9:29 AM
SimoneThisDot moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Oct 14 2021, 9:29 AM
gerritbot added a comment.Oct 19 2021, 1:01 AM

Change 730208 had a related patch set uploaded (by Seddon; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@master] Refactor the URI.query

https://gerrit.wikimedia.org/r/730208

gerritbot added a comment.Oct 19 2021, 10:43 AM

Change 730208 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Refactor the URI.query

https://gerrit.wikimedia.org/r/730208

gerritbot added a comment.Oct 19 2021, 1:56 PM

Change 730715 abandoned by Simone Cuomo:

[mediawiki/extensions/MediaSearch@master] Cannot convert undefined or null to object on restorePageState

Reason:

This has already been fixed with the https://phabricator.wikimedia.org/T291392

https://gerrit.wikimedia.org/r/730715

SimoneThisDot added a comment.Oct 19 2021, 1:56 PM

This has been fixed as part of https://phabricator.wikimedia.org/T291392

SimoneThisDot closed this task as a duplicate of T291392: Refactor the URI.query.Oct 19 2021, 1:56 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 19 2021, 2:10 PM
gerritbot added a comment.Oct 19 2021, 6:08 PM

Change 731961 had a related patch set uploaded (by Urbanecm; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.4] Refactor the URI.query

https://gerrit.wikimedia.org/r/731961

gerritbot added a project: Patch-For-Review.Oct 19 2021, 6:08 PM

Change 731962 had a related patch set uploaded (by Urbanecm; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.5] Refactor the URI.query

https://gerrit.wikimedia.org/r/731962

gerritbot added a comment.Oct 19 2021, 6:34 PM

Change 731961 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.4] Refactor the URI.query

https://gerrit.wikimedia.org/r/731961

gerritbot added a comment.Oct 19 2021, 6:34 PM

Change 731962 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.5] Refactor the URI.query

https://gerrit.wikimedia.org/r/731962

Stashbot added a comment.Oct 19 2021, 6:45 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-19T18:45:27Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.4/extensions/MediaSearch/: 694580a: c02e301: MediaSearch backports(T291392, T293335, T291392, T291622, T293554) (duration: 01m 03s)

Stashbot mentioned this in T291622: [M] CheckForMore always return true.Oct 19 2021, 6:45 PM
Stashbot mentioned this in T293554: Switching tabs in MediaSearch does not re-query the search.
Stashbot mentioned this in T291392: Refactor the URI.query.

Mentioned in SAL (#wikimedia-operations) [2021-10-19T18:46:30Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.5/extensions/MediaSearch/: a84a675: 3231578: MediaSearch backports (T291392, T293335, T291392, T291622, T293554) (duration: 01m 03s)

Maintenance_bot removed a project: Patch-For-Review.Oct 19 2021, 7:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL