Page MenuHomePhabricator

[M] CheckForMore always return true
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • search for a value that return nothing in some instance or one with just a few entry
  • Go to the mediaType without entry / or browse to the last page of it

What happens?:
the "checkForMore" vuex store object should return false when no more values are set

What should have happened instead?:

  • The "checkForMore" should have returned true and no search should have been made

Additional Info
THe code has currently being writted to expect "NULL" if there are no new entry and "undefined" on the first load. Currently erven after we search the continue is still being set to Undefined and not NULL

Event Timeline

CBogen renamed this task from CheckForMore always return true to [M] CheckForMore always return true.Oct 6 2021, 4:49 PM

Change 727328 had a related patch set uploaded (by Seddon; author: Seddon):

[mediawiki/extensions/MediaSearch@master] CheckForMore needs to return null

https://gerrit.wikimedia.org/r/727328

Change 727328 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] CheckForMore needs to return null

https://gerrit.wikimedia.org/r/727328

Change 730208 had a related patch set uploaded (by Seddon; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@master] Refactor the URI.query

https://gerrit.wikimedia.org/r/730208

Change 730208 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Refactor the URI.query

https://gerrit.wikimedia.org/r/730208

Change 731961 had a related patch set uploaded (by Urbanecm; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.4] Refactor the URI.query

https://gerrit.wikimedia.org/r/731961

Change 731962 had a related patch set uploaded (by Urbanecm; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.5] Refactor the URI.query

https://gerrit.wikimedia.org/r/731962

Change 731961 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.4] Refactor the URI.query

https://gerrit.wikimedia.org/r/731961

Change 731962 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.5] Refactor the URI.query

https://gerrit.wikimedia.org/r/731962

Mentioned in SAL (#wikimedia-operations) [2021-10-19T18:45:27Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.4/extensions/MediaSearch/: 694580a: c02e301: MediaSearch backports(T291392, T293335, T291392, T291622, T293554) (duration: 01m 03s)

Mentioned in SAL (#wikimedia-operations) [2021-10-19T18:46:30Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.5/extensions/MediaSearch/: a84a675: 3231578: MediaSearch backports (T291392, T293335, T291392, T291622, T293554) (duration: 01m 03s)

Etonkovidova claimed this task.
Etonkovidova added a subscriber: Etonkovidova.

From the UI point of view, all works as expected.