Page MenuHomePhabricator
Create Task
Maniphest T291622

[M] CheckForMore always return true
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • search for a value that return nothing in some instance or one with just a few entry
  • Go to the mediaType without entry / or browse to the last page of it

What happens?:
the "checkForMore" vuex store object should return false when no more values are set

What should have happened instead?:

  • The "checkForMore" should have returned true and no search should have been made

Additional Info
THe code has currently being writted to expect "NULL" if there are no new entry and "undefined" on the first load. Currently erven after we search the continue is still being set to Undefined and not NULL

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MediaSearchwmf/1.38.0-wmf.5+684 -187Refactor the URI.query
mediawiki/extensions/MediaSearchwmf/1.38.0-wmf.4+684 -187Refactor the URI.query
mediawiki/extensions/MediaSearchmaster+684 -187Refactor the URI.query
mediawiki/extensions/MediaSearchmaster+5 -5CheckForMore needs to return null
Customize query in gerrit

Related Objects

Event Timeline

SimoneThisDot created this task.Sep 23 2021, 11:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 23 2021, 11:11 AM
CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Oct 4 2021, 4:30 PM
CBogen renamed this task from CheckForMore always return true to [M] CheckForMore always return true.Oct 6 2021, 4:49 PM
CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.
gerritbot added a comment.Oct 7 2021, 12:35 PM

Change 727328 had a related patch set uploaded (by Seddon; author: Seddon):

[mediawiki/extensions/MediaSearch@master] CheckForMore needs to return null

https://gerrit.wikimedia.org/r/727328

gerritbot added a project: Patch-For-Review.Oct 7 2021, 12:35 PM
Seddon moved this task from Ready for Development to Code Review on the Structured-Data-Backlog (Current Work) board.Oct 7 2021, 12:37 PM
gerritbot added a comment.Oct 11 2021, 11:36 AM

Change 727328 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] CheckForMore needs to return null

https://gerrit.wikimedia.org/r/727328

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.4; 2021-10-12).Oct 11 2021, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 11 2021, 12:10 PM
Seddon moved this task from Code Review to Verify on Production on the Structured-Data-Backlog (Current Work) board.Oct 15 2021, 12:48 PM
SimoneThisDot mentioned this in T293554: Switching tabs in MediaSearch does not re-query the search.Oct 18 2021, 3:31 PM
gerritbot added a comment.Oct 19 2021, 1:29 AM

Change 730208 had a related patch set uploaded (by Seddon; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@master] Refactor the URI.query

https://gerrit.wikimedia.org/r/730208

gerritbot added a project: Patch-For-Review.Oct 19 2021, 1:29 AM
gerritbot added a comment.Oct 19 2021, 10:43 AM

Change 730208 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Refactor the URI.query

https://gerrit.wikimedia.org/r/730208

gerritbot added a comment.Oct 19 2021, 6:08 PM

Change 731961 had a related patch set uploaded (by Urbanecm; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.4] Refactor the URI.query

https://gerrit.wikimedia.org/r/731961

gerritbot added a comment.Oct 19 2021, 6:08 PM

Change 731962 had a related patch set uploaded (by Urbanecm; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.5] Refactor the URI.query

https://gerrit.wikimedia.org/r/731962

gerritbot added a comment.Oct 19 2021, 6:34 PM

Change 731961 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.4] Refactor the URI.query

https://gerrit.wikimedia.org/r/731961

gerritbot added a comment.Oct 19 2021, 6:34 PM

Change 731962 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.5] Refactor the URI.query

https://gerrit.wikimedia.org/r/731962

Stashbot mentioned this in T293335: Cannot convert undefined or null to object when trying to restorePageState.Oct 19 2021, 6:45 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-19T18:45:27Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.4/extensions/MediaSearch/: 694580a: c02e301: MediaSearch backports(T291392, T293335, T291392, T291622, T293554) (duration: 01m 03s)

Stashbot mentioned this in T291392: Refactor the URI.query.Oct 19 2021, 6:45 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-19T18:46:30Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.5/extensions/MediaSearch/: a84a675: 3231578: MediaSearch backports (T291392, T293335, T291392, T291622, T293554) (duration: 01m 03s)

Etonkovidova closed this task as Resolved.Oct 20 2021, 1:31 AM
Etonkovidova claimed this task.
Etonkovidova added a subscriber: Etonkovidova.

From the UI point of view, all works as expected.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL