Bottom of the sites (where license and privacy policy resides) are not full width as the top. The content has been reduced to a fixed with, but the site content should be full width.
Should it be full width, it not part of the content.
Description
Description
Details
Details
Related Objects
Related Objects
Event Timeline
Comment Actions
Looking at https://commons.wikimedia.org/wiki/File:Annotated_Wikipedia_Vector_interface_(logged-out).png , when reading a short article (short enough that the vertical space needed by the entire sidebar is higher than the vertical space needed by the article), I'd need to get the idea to scroll down and pass quite some white space, in order to e.g. see legal information in the footer.
Comment Actions
Change 802662 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/Vector@master] Make footer take up full width
Comment Actions
Change 802662 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Make footer take up full width
Comment Actions
This can be tested along with the other in progress grids work here:
https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?vectorgrid=1
Comment Actions
@Jdlrobson looking mostly good. there seems to be a bug where if I don't have the sidebar open the footer is hidden once I get down to 1000px wide:
| sidebar open | sidebar closed |
|---|---|
 |  |
Comment Actions
Change 805232 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/Vector@master] Don't hide footer < 1000px when sidebar closed
Comment Actions
Change 805232 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Layout: Don't hide footer < 1000px when sidebar closed
Comment Actions
Can skip QA as the grid will be QAed in T303484.
The design review link is:
https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?vectorgrid=1
For now we are just checking the footer behaviour.
Please move to needs more review or sign off aft.
Comment Actions
Seems nice. Once we have this, I think that the problem with sitenotice and globalnotice should also be reviewed, as this is not part of the page content, but of the site: https://phabricator.wikimedia.org/T293390
Comment Actions
(This can now be design reviewed on the beta cluster). We're targeting a deploy date of the Monday 18th.
Comment Actions
Good change! And now... should we think about a really interesting footer? Most of the websites have it with a different background color, and we could have there columns with extra information (more visible copyright, sister projects, some of the buttons that are going to disappear from the sidebar...