| ovasileva | |
| Oct 15 2021, 5:39 PM |
| F34736747: Screen Shot 2021-11-07 at 7.26.07 AM.png | |
| Nov 7 2021, 3:26 PM |
| F34736745: Screen Shot 2021-11-07 at 7.24.28 AM.png | |
| Nov 7 2021, 3:24 PM |
| F34715086: Screenshot NWE user menu 2021-10-29.jpg | |
| Oct 29 2021, 10:45 AM |
| F34690321: Screen Shot 2021-10-15 at 12.38.18 PM.png | |
| Oct 15 2021, 5:39 PM |
What happens?:
Translations and uploaded media links appear blue
What should have happened instead?:
Styling should be the same for all links within the user menu
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T293507#7487930 |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T293507#7487932 |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Use addPortletLink for injecting links | mediawiki/extensions/ContentTranslation | master | +22 -8 |
Change 730920 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/extensions/ContentTranslation@master] Use addPortletLink for injecting links
@ovasileva raised in our morning meeting that we want to make sure this gets fixed ASAP so I will likely need to backport the change to at least one branch this week. If this could make the branch cut for this week's train, that would be greatly appreciated.
Change 730920 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Use addPortletLink for injecting links
Seems to be fixed now! However, if I open a page with the VE or NWE, both these links are displayed double:
EDIT: Additionally, anytime I exit the VE again without refreshing the page, the double links will remain in the menu. Repeating this, I can achieve an indefinite number of such links in the user menu.
Can you open a bug for ContentTranslation? It seems like the hook it's using is firing more than once. It should only be doing this once at the start.
Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA
Test Artifact(s):
Steps to reproduce
Go to https://en.wikipedia.org/wiki/Main_Page with legacy vector turned off
Select user menu
✅ AC1: Translations and uploaded media links should not appear blue and styling should be the same for all links within the user menu
Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA
Test Artifact(s):
Steps to reproduce
Go to https://en.wikipedia.org/wiki/Main_Page with legacy vector turned off
Select user menu
✅ AC1: Translations and uploaded media links should not appear blue and styling should be the same for all links within the user menu
