Drop wb_changes_dispatch table in production
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lucas_Werkmeister_WMDE
	Oct 22 2021, 1:49 PM

Description

Context: T291829: Drop wb_changes_dispatch table; the table was used in the old change dispatching system, which we no longer use. (You can see that the chd_touched column is frozen in time, not updated since 2021-10-04.)

ALTERs to run: DROP TABLE wb_changes_dispatch;
- or maybe something like RENAME TABLE wb_changes_dispatch TO T294121_DROP_wb_changes_dispatch; wait for a bit to ensure that nothing is trying to use the table; then DROP TABLE T294121_DROP_wb_changes_dispatch – if you want to be extra safe
Where to run those changes: wikibaserepo.dblist
- commonswiki
- testcommonswiki
- testwikidatawiki
- wikidatawiki
When to run those changes: At any time
If the schema change is backwards compatible: Yes
If the schema change has been tested already on some of the test/beta wikis: Yes, dropped via update.php in Beta

Related Objects
Search...

Status	Assigned	Task
Resolved	karapayneWMDE	T291830 Post Dispatch Changes Migration Checklist
Resolved	Lucas_Werkmeister_WMDE	T291829 Drop wb_changes_dispatch table
Resolved	Ladsgroup	T294121 Drop wb_changes_dispatch table in production

Event Timeline

Lucas_Werkmeister_WMDE created this task.Oct 22 2021, 1:49 PM

Michael merged a task: T294114: Please drop wb_changes_dispatch table in wikidatawiki and testwikidatawiki.Oct 22 2021, 1:53 PM

This is not a Schema-change-in-production or Schema-change so removing this tag. We use those tags for changes on the schema of our tables and this is a drop.
We'll rename the table first indeed, that's our usual procedure to make double sure nothing reads/writes
I assume this is ready to go anytime then?

Ah, damn, I skipped straight past that part 🤦 https://wikitech.wikimedia.org/wiki/Schema_changes#What_is_not_a_schema_change

@Michael suggested waiting until the change to drop the table has been deployed to production (next week’s train), as an added precaution. But otherwise this should be ready to go, I think.

Sure, we can wait, no rush!
Thanks

Michael moved this task from Backlog to Later/External on the Wikibase change dispatching scripts to jobs board.Oct 22 2021, 2:34 PM

• Marostegui claimed this task.Oct 25 2021, 4:27 AM

@Lucas_Werkmeister_WMDE was this released past week? Can this be done anytime now?

• Marostegui reassigned this task from • Marostegui to Ladsgroup.Nov 3 2021, 12:11 PM

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptNov 3 2021, 12:11 PM

The .ibd file hasn't been touched for a month now:

ladsgroup@db1104:/srv/sqldata/wikidatawiki$ ls -l | grep -i wb_changes_dis
-rw-rw---- 1 mysql mysql         2188 Feb  8  2021 wb_changes_dispatch.frm
-rw-rw---- 1 mysql mysql     14680064 Oct  4 16:28 wb_changes_dispatch.ibd

I go rename it in a replica.

Ladsgroup moved this task from Ready to In progress on the DBA board.Nov 3 2021, 6:02 PM

Mentioned in SAL (#wikimedia-operations) [2021-11-03T18:08:32Z] <Amir1> ran set session sql_log_bin=0; RENAME TABLE wb_changes_dispatch TO T294121_DROP_wb_changes_dispatch; on db1111 (T294121)

I renamed the table in db1111 (one of replicas). We wait a couple of days and then drop the whole thing.

Given how small the table is I would suggest to take a quick mysqldump before dropping it (I can help with that!)

Done

root@cumin1001:/home/ladsgroup/T291829# ls -lh
total 64K
-rw-r--r-- 1 root root 2.3K Nov  4 12:07 commonswiki_wb_changes_dispatch.sql
-rw-r--r-- 1 root root 2.3K Nov  4 12:07 testcommonswiki_wb_changes_dispatch.sql
-rw-r--r-- 1 root root 2.7K Nov  4 12:06 testwikidatawiki_wb_changes_dispatch.sql
-rw-r--r-- 1 root root  50K Nov  4 12:05 wikidatawiki_wb_changes_dispatch.sql

If there are no errors on logstash in the last few days - we can probably go ahead and delete this in production.
The tables are small enough that it can be done thru replication but always using DROP TABLE IF EXISTS

I looked in logstash and I don't see any errors. It's still not written anything yet. Moving forward to dropping it.

Ladsgroup updated the task description. (Show Details)Nov 8 2021, 9:01 AM

Ladsgroup updated the task description. (Show Details)Nov 8 2021, 9:03 AM

Ladsgroup moved this task from In progress to Done on the DBA board.

@Ladsgroup remember to also delete (if you haven't already) the renamed tables on db1111.

In T294121#7488440, @Marostegui wrote:

@Ladsgroup remember to also delete (if you haven't already) the renamed tables on db1111.

I renamed it back first and then let it ran on master with replication. The Lazy Way.

Good! Then good to close I think!

Done ^^

Thank you both <3

Maintenance_bot moved this task from Incoming to Done on the User-Ladsgroup board.Nov 8 2021, 10:15 AM

Drop wb_changes_dispatch table in productionClosed, ResolvedPublicActions

Description

Related ObjectsSearch...

Event Timeline

Drop wb_changes_dispatch table in production
Closed, ResolvedPublic
Actions

Related Objects
Search...