Page MenuHomePhabricator

Citoid's "change reference type" button missing with new template editor sidebar
Closed, ResolvedPublic3 Estimated Story Points

Description

Steps to reproduce:

  • Make sure you have both Cite and Citoid enabled.
  • In VisualEditor, add a citation via the "Cite" dropdown. Add some value and click "apply changes".
  • Edit the same citation again.
  • With the old sidebar there will be a button to "change reference type" at the bottom of the dialog. (Note: This was broken and fixed via T293280.)
  • This button is missing with the new sidebar.

Event Timeline

thiemowmde set the point value for this task to 3.Oct 27 2021, 8:30 AM

Noticing that we might want to disable the "add new template" and "add wikitext" keyboard shortcuts in the citation dialog.

When we show the "other actions" toolbar, the "hide options" button will become visible even with large window sizes where we would have hidden otherwise. Should we make this invisible?

image.png (463×980 px, 54 KB)

Change 734938 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Show the \"other actions\" toolbar when unknown buttons are available

https://gerrit.wikimedia.org/r/734938

awight moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2021-10-27 board.

Change 735301 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Still hide mode button unless in small screen mode

https://gerrit.wikimedia.org/r/735301

Change 734938 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Show the \"other actions\" toolbar when unknown buttons are available

https://gerrit.wikimedia.org/r/734938

Change 735301 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Still hide mode button unless in small screen mode

https://gerrit.wikimedia.org/r/735301

When we show the "other actions" toolbar, the "hide options" button will become visible even with large window sizes where we would have hidden otherwise. Should we make this invisible?

Yes, I don't think this button should be visible on larger screens.

Change 735301 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Still hide mode button unless in small screen mode

Seems like this has already been done?

Change 735301 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Still hide mode button unless in small screen mode

Seems like this has already been done?

For those playing at home: yes we went ahead with this, thanks for the approval! Will demo next week, or you can check it out on the beta cluster ahead of time.

thiemowmde claimed this task.
thiemowmde moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-10-27 board.