Page MenuHomePhabricator
Create Task
Maniphest T294783

Exclude permanently blocked users from DiscussionTools' username suggestion list API results
Closed, ResolvedPublic
Actions

Description

  1. Open the reply tool
  2. Type '@' the start typing a username that is permanently blocked

Expected:
The username should never be suggested (unless you have typed in the full name), e.g. if there is a blocked user called User:Blocked_user and I type @blocked u, it should not suggest Blocked user

Users who have commented in the thread will still be suggested as those names are not fetched from the API.

Details

SubjectRepoBranchLines +/-
UsernameCompletion: Filter out users with indefinite sitewide blocks from API resultsmediawiki/extensions/DiscussionToolswmf/1.38.0-wmf.6+11 -5
UsernameCompletion: Filter out users with indefinite sitewide blocks from API resultsmediawiki/extensions/DiscussionToolsmaster+11 -5
Customize query in gerrit

Related Objects

Event Timeline

ppelberg created this task.Nov 1 2021, 5:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 1 2021, 5:24 PM
ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.Nov 1 2021, 5:25 PM
gerritbot added a comment.Nov 1 2021, 5:25 PM

Change 735989 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] UsernameCompletion: Filter out users with indefinite sitewide blocks from API results

https://gerrit.wikimedia.org/r/735989

gerritbot added a project: Patch-For-Review.Nov 1 2021, 5:25 PM
gerritbot added a comment.Nov 1 2021, 11:10 PM

Change 735989 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] UsernameCompletion: Filter out users with indefinite sitewide blocks from API results

https://gerrit.wikimedia.org/r/735989

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.7; 2021-11-02).Nov 2 2021, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 2 2021, 12:10 AM
ppelberg moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.Nov 2 2021, 1:29 AM
matmarex mentioned this in T25310: Global suppression does not work properly when the target has already been locally blocked.Nov 2 2021, 5:40 PM
gerritbot added a comment.Nov 2 2021, 5:45 PM

Change 736250 had a related patch set uploaded (by Bartosz Dziewoński; author: Esanders):

[mediawiki/extensions/DiscussionTools@wmf/1.38.0-wmf.6] UsernameCompletion: Filter out users with indefinite sitewide blocks from API results

https://gerrit.wikimedia.org/r/736250

gerritbot added a project: Patch-For-Review.Nov 2 2021, 5:45 PM
gerritbot added a comment.Nov 2 2021, 5:55 PM

Change 736250 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.38.0-wmf.6] UsernameCompletion: Filter out users with indefinite sitewide blocks from API results

https://gerrit.wikimedia.org/r/736250

Stashbot added a comment.Nov 2 2021, 5:59 PM

Mentioned in SAL (#wikimedia-operations) [2021-11-02T17:59:32Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.6/extensions/DiscussionTools/modules/dt-ve/dt.ui.UsernameCompletionAction.js: 494af124b95e2eabff94fde79aed6b6f6f81feab: UsernameCompletion: Filter out users with indefinite sitewide blocks from API results (T294783) (duration: 00m 55s)

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.6; 2021-10-26); removed MW-1.38-notes (1.38.0-wmf.7; 2021-11-02).Nov 2 2021, 6:00 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Nov 2 2021, 6:03 PM
matmarex edited projects, added Editing QA; removed Patch-For-Review.
• Esanders updated the task description. (Show Details)Nov 3 2021, 5:18 PM
• Esanders updated the task description. (Show Details)
• Esanders updated the task description. (Show Details)
• Esanders renamed this task from Exclude permanently blocked users from DiscussionTools' username suggestion list to Exclude permanently blocked users from DiscussionTools' username suggestion list API results.Nov 3 2021, 10:47 PM
• Esanders updated the task description. (Show Details)
Ryasmeen edited projects, added Verified; removed Editing QA.Nov 3 2021, 11:08 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Nov 4 2021, 3:24 PM
ppelberg mentioned this in T295211: Filter by block status in "Allusers" API.Nov 5 2021, 11:52 PM
ppelberg mentioned this in T219931: Users of Special:Block must get the options just right in order to be able to select the "Hide username from edits and lists" option.Nov 6 2021, 12:15 AM
ppelberg closed this task as Resolved.Nov 6 2021, 12:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits