In fact, this table of contents does not appear in all articles or in all languages at the same time. Example : https://fr.wikivoyage.org/wiki/Spa in French or https://pl.wikivoyage.org/wiki/Spa in Polish has not table and https://en.wikivoyage.org/wiki/Spa_(Belgium) in English has a table.

Could someone please provide a link to an English WV page which has no table; or a French/Polish page which has a table, as the title here says "all language Wikivoyages" (plural)? So far I've only managed to see the problem on English WV which makes me think that something could be special about https://en.wikivoyage.org/wiki/Template:Pagebanner there.

(Note to myself: Both French WV and English WV are in group 1 and on the same 1.38.0-wmf.7 software version.)

https://fr.wikivoyage.org/wiki/Li%C3%A8ge in French and English has a table but not in other languages. I have tried to found an article in English without a table but without success

@Omondi , @Aklapper ,
the issue is on the pagebanner extension.
The reason why you didn't see it:

• on fr:voy is just because of cache. Now I've purged the page and you can see it
• on pl:voy is because they DON'T use the extension, so pl:voy is not affected.

The issue is on it:voy as well, but temporary I've patched both it:voy & en:voy with this script:

$(document).ready(function(e) {
	$(".ext-wpb-pagebanner").parent().parent().find("#toc").hide();
});

that hide the standard TOC when a pagebanner (generated by the extension) is present.

What is "the pagebanner extension" exactly?

@Aklapper This one: https://www.mediawiki.org/wiki/Extension:WikidataPageBanner

The Spa article on fr.voy seems to have a table now. Clicking random articles on the French Wikivoyage, I can't seem to find any article without the table of contents.

@SHB2000 see my clarification above

@cscott WikidataPageBanner is using Parser internals in its code. I'm surprised it worked this long without problems :-( https://gerrit.wikimedia.org/g/mediawiki/extensions/WikidataPageBanner/+/162a33836470e9dfab9501a9602b5edc1b67140e/includes/WikidataPageBanner.php#210 I am going to see if I can make that a bit nicer. Is there an elegant way for extensions to disable table of contents on a page to provide their own? Perhaps, WikidataPageBanner should be setting __NOTOC__ on all pages.

Workarounds:

• __NOTOC__ should work as a workaround here, provided __FORCETOC__ is not called.
• Add #toc { display: none; } to MediaWiki:Common.css

I'd recommend Wikivoyage communities use __NOTOC__ regardless of what we end up with here.

Note, it's Thursday so unfortunately a fix will likely have to wait until next week but I'll make sure that gets prioritized.

In T295003#7480877, @Omondi wrote:

https://fr.wikivoyage.org/wiki/Li%C3%A8ge in French and English has a table but not in other languages. I have tried to found an article in English without a table but without success

@Omondi it looks like French Wikipedia is calling __FORCETOC__ in https://fr.wikivoyage.org/w/index.php?title=Mod%C3%A8le:Banni%C3%A8re_page&action=edit removing that should address this problem for you.

@Andyrom75 let me know if adding __NOTOC__ to https://en.wikivoyage.org/w/index.php?title=Template:pagebanner is not practical.

@Jdlrobson is not possible to use the suggested CSS on MediaWiki:Common.css because it will affect ALL the pages, not only the ones that use the banner. That's why, the applied temporary patch use a dynamic JS that looks first for the ext-wpb-pagebanner class, introduced by the extension.
As well is not possible to use __NOTOC__ because it will hide also the custom banner menu (the one that replace the standard TOC)

Change 737088 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikidataPageBanner@master] WikidataPageBanner should disable table of contents using public functions

https://gerrit.wikimedia.org/r/737088

Change 737088 merged by jenkins-bot:

[mediawiki/extensions/WikidataPageBanner@master] WikidataPageBanner should disable table of contents using public functions

https://gerrit.wikimedia.org/r/737088

Change 737075 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikidataPageBanner@wmf/1.38.0-wmf.7] WikidataPageBanner should disable table of contents using public functions

https://gerrit.wikimedia.org/r/737075

Does someone know if there was a specific code change in the Parser that triggered this issue in WDPageBanner? Asking as T295187 is another recent ToC issue...

Change 737075 merged by jenkins-bot:

[mediawiki/extensions/WikidataPageBanner@wmf/1.38.0-wmf.7] WikidataPageBanner should disable table of contents using public functions

https://gerrit.wikimedia.org/r/737075

Mentioned in SAL (#wikimedia-operations) [2021-11-08T19:39:31Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.7/extensions/WikidataPageBanner/includes/WikidataPageBanner.php: 2c74457b26e0d288a371fd76bcb91b697554f9fd: WikidataPageBanner should disable table of contents using public functions (T295003) (duration: 00m 55s)

Thanks @Jdlrobson! I've removed the patch several hours ago on it:voy and checked now to avoid cache issues; all works correctly. I've just removed the patch in en:voy and asked fr:voy & ru:voy to do the same. Without comments from their side I would say that we can close the ticket within tomorrow.

Thanks for confirming @Andyrom75 that's super helpful.

@Jdlrobson you can successfully close this ticket. Thanks a lot for your quick support!

Test Result - Beta

Status: ✅ PASS
Environment: beta wikivoyage
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Visit https://en.wikivoyage.beta.wmflabs.org/wiki/Salzburg
✅ AC1: Expected: The vertical table of contents should not be present in the page. It should be present inside the banner image at the top of the page as a horizontal bar.

@Jdlrobson I've noticed another strange behavior. As previously mentioned, when visualizing an article everything is fine now, but during the preview the standard TOC is still visible. This is quite annoying because "what we see is NOT what we get" after publishing the content.
Do you want me to open another ticket or can this bug managed here with the same ticket?

Let me know

@Andyrom75 a new bug would be great. When reporting it could you mention which of the editors are impacted (e.g. VisualEditor, ?action=edit, mobile editor)?
I'm sadly out for the next 2 weeks so won't be able to look for at these for a while, but please add cscott to the ticket as he can likely help in the interim.

@Jdlrobson just opened T295632 as requested. If you can, give a quick look to be sure that as been correctly opened.