Due to our new selector, mw-body-content rules are applied twice:
https://en.wikipedia.beta.wmflabs.org/wiki/Abraham_Lincoln?veaction=edit
| Editor | Expected font size (read mode) |
|---|---|
 |  |
Caused by patches on T287733
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Revert "Fix font size in editor preview" | mediawiki/skins/Vector | master | +0 -6 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Release | jeena | T293950 1.38.0-wmf.9 deployment blockers | ||
| Resolved | ppelberg | T295712 Font-size in VE too small |
Event Timeline
Comment Actions
We can:
- remove mw-body-content from VE surfaces on desktop, but other parts of the code expect the selector to be there, e.g. .mw-body-content p.ve-ce-branchNode-newSlug {
- add another exception to the hack in Vector, increase the specificity again e.g. .mw-body-content:not( #mw-content-text ):not( .ve-ui-surface )
- abandon this hack in Vector as a non-starter, leaving previews and diffs broken for another week, and try to get back to a state where we just have one simple selector for content styles (mw-body-content).
Comment Actions
Change 738937 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/skins/Vector@master] Revert \"Fix font size in editor preview\"
Comment Actions
Given this is a train blocker, I'm reverting the Vector change, and we'll have to live with the broken previews for another week or so.
Comment Actions
Change 738937 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Revert \"Fix font size in editor preview\"
