Page MenuHomePhabricator

Font-size in VE too small
Closed, ResolvedPublic

Description

Due to our new selector, mw-body-content rules are applied twice:
https://en.wikipedia.beta.wmflabs.org/wiki/Abraham_Lincoln?veaction=edit

EditorExpected font size (read mode)
image.png (2×3 px, 1 MB)
image.png (2×3 px, 1 MB)

Caused by patches on T287733

Event Timeline

Esanders triaged this task as Unbreak Now! priority.Nov 15 2021, 5:51 PM

Blocking the train so it doesn't get past beta

We can:

  • remove mw-body-content from VE surfaces on desktop, but other parts of the code expect the selector to be there, e.g. .mw-body-content p.ve-ce-branchNode-newSlug {
  • add another exception to the hack in Vector, increase the specificity again e.g. .mw-body-content:not( #mw-content-text ):not( .ve-ui-surface )
  • abandon this hack in Vector as a non-starter, leaving previews and diffs broken for another week, and try to get back to a state where we just have one simple selector for content styles (mw-body-content).

Change 738937 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/Vector@master] Revert \"Fix font size in editor preview\"

https://gerrit.wikimedia.org/r/738937

Given this is a train blocker, I'm reverting the Vector change, and we'll have to live with the broken previews for another week or so.

Change 738937 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Revert \"Fix font size in editor preview\"

https://gerrit.wikimedia.org/r/738937

Hello, train conductor here. Is this still blocking the train?

@jeena No, the revert above has resolved the issue.

ppelberg claimed this task.