Page MenuHomePhabricator

Initial scroll incorrect for new VE template dialog
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Visit a page on de.wikipedia.org
  • Enter the Visual Editor
  • Insert the Literatur template.

What happens?:
The dialog is scrolled close to the bottom of the content.

image.png (907×929 px, 269 KB)

What should have happened instead?:
Should have been scrolled to the very top.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Based on feedback originally reported here: https://de.wikipedia.org/wiki/Wikipedia_Diskussion:Technische_W%C3%BCnsche/Topw%C3%BCnsche/Verbesserungen_im_Vorlagendialog_des_VisualEditors#Merkw%C3%BCrdige_Fokussierung

Event Timeline

Lena_WMDE set the point value for this task to 3.
Lena_WMDE added a subscriber: Lena_WMDE.

Timeboxed to 3 points

Change 745545 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Don't scroll to template parameters while the dialog loads

https://gerrit.wikimedia.org/r/745545

Change 745545 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Don't scroll to template parameters while the dialog loads

https://gerrit.wikimedia.org/r/745545

Change 754476 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Fix dead scroll code in template dialog

https://gerrit.wikimedia.org/r/754476