Page MenuHomePhabricator
Create Task
Maniphest T297424

Reduce LBFactory::rollbackPrimaryChanges() callers in core
Closed, ResolvedPublic
Actions

Description

Core callers should be moved to things like cancelable atomic sections where possible. Only a select few entry point methods should invoke this function.

Details

SubjectRepoBranchLines +/-
filerepo: make FileDeleteForm use cancelAtomic() instead of rollbackPrimaryChangesmediawiki/coremaster+2 -3
revisiondelete: make RevDelList use cancelAtomic() instead of rollbackPrimaryChangesmediawiki/coremaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

aaron created this task.Dec 9 2021, 7:19 PM
Restricted Application added projects: Performance-Team, Platform Engineering. · View Herald TranscriptDec 9 2021, 7:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle moved this task from Untriaged to Wiring for MediaWiki on the MediaWiki-libs-Rdbms board.Dec 9 2021, 11:50 PM
Krinkle claimed this task.Dec 13 2021, 7:34 PM
Krinkle reassigned this task from Krinkle to aaron.
Krinkle triaged this task as Medium priority.
Krinkle moved this task from Inbox, needs triage to Doing: Prio Interrupt on the Performance-Team board.
Krinkle added parent tasks: T281451: Wikimedia\Rdbms\DBTransactionError: Transaction round stage must be 'cursory' (not 'within-rollback-callbacks'), T293859: Wikimedia\Rdbms\DBTransactionStateError: Cannot execute query ... while transaction status is ERROR (after PHP timeout).
Krinkle subscribed.
gerritbot added a comment.Dec 15 2021, 4:20 AM

Change 747228 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] revisiondelete: make RevDelList use cancelAtomic() instead of rollbackPrimaryChanges

https://gerrit.wikimedia.org/r/747228

gerritbot added a project: Patch-For-Review.Dec 15 2021, 4:20 AM

Change 747229 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] filerepo: make FileDeleteForm use cancelAtomic() instead of rollbackPrimaryChanges

https://gerrit.wikimedia.org/r/747229

gerritbot added a comment.Feb 21 2022, 5:15 PM

Change 747228 merged by jenkins-bot:

[mediawiki/core@master] revisiondelete: make RevDelList use cancelAtomic() instead of rollbackPrimaryChanges

https://gerrit.wikimedia.org/r/747228

gerritbot added a comment.Feb 21 2022, 5:15 PM

Change 747229 merged by jenkins-bot:

[mediawiki/core@master] filerepo: make FileDeleteForm use cancelAtomic() instead of rollbackPrimaryChanges

https://gerrit.wikimedia.org/r/747229

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.23; 2022-02-21).Feb 21 2022, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 21 2022, 6:10 PM
aaron closed this task as Resolved.Mar 15 2022, 8:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits