Page MenuHomePhabricator

Invert or Avoid Expanding Function Calls before Returning from Orchestrator to avoid shipping huge expanded calls to the user
Closed, ResolvedPublic

Description

Some function calls (particularly expansion of generic types) can and should be undone before the orchestrator returns to the frontend.

The most natural way to do this will be to use the cache: we store the input and output of a function call, then see if certain outputs (specifically Z1K1s) are still present in the ZObject. We can then replace those elements of the ZObject with their unexpanded equivalents.

Event Timeline

One option also is to replace a expanded type with the Z4K1 (that's one of the reasons why Z4K1 exists)

Jdforrester-WMF renamed this task from Invert Certain Function Calls before Returning from Orchestrator to Invert Certain Function Calls before Returning from Orchestrator to avoid shipping huge expanded calls to the user.Aug 2 2022, 4:56 PM
cmassaro renamed this task from Invert Certain Function Calls before Returning from Orchestrator to avoid shipping huge expanded calls to the user to Invert or Avoid Expanding Function Calls before Returning from Orchestrator to avoid shipping huge expanded calls to the user.Oct 5 2022, 3:19 PM

Change 845066 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Do not permanently expand types when validating.

https://gerrit.wikimedia.org/r/845066

Change 845066 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Do not permanently expand types when validating.

https://gerrit.wikimedia.org/r/845066

Change 850524 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] tests: Update expected expansions of Z831s

https://gerrit.wikimedia.org/r/850524

Change 850524 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] tests: Update expected expansions of Z831s

https://gerrit.wikimedia.org/r/850524

Change 853541 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@REL1_39] tests: Update expected expansions of Z831s

https://gerrit.wikimedia.org/r/853541

Change 853541 merged by Jforrester:

[mediawiki/extensions/WikiLambda@REL1_39] tests: Update expected expansions of Z831s

https://gerrit.wikimedia.org/r/853541