Page MenuHomePhabricator

Wrong clickable area for special homepage modules
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
The user is taken to the server-side rendered view of that module not benefiting from the already loaded JS modules

What should have happened instead?:
The area should not be clickable at all as it is miss leading and doesn't take advantage of the pre-loaded modules

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc: I think this error has been around for a long time

Screenshot 2021-12-16 at 12.56.54.png (1×2 px, 218 KB)

Server-side link click area
Screenshot 2021-12-16 at 12.56.04.png (1×3 px, 638 KB)

Client-side click area (blue + green)
Screenshot 2021-12-16 at 12.56.24.png (1×3 px, 522 KB)

Notes

The fix is easy by changing some CSS styles. I suggest using bottom margins instead of top + vertical padding on the container or use a flex + gap approach. However I was thinking if as a general pattern it would be more benefitial to re-write all client-side links when the JS is loaded so we don't ever run into this kind of issue for a module that has a full-JS experience. It could be done in this task or another.

Event Timeline

@Sgs: Assuming this task is about the GrowthExperiments-Homepage code project, hence adding that project tag so other people who don't know or don't care about team tags can also find this task when searching via projects. Please set appropriate project tags when possible. Thanks!

@Sgs: Assuming this task is about the GrowthExperiments-Homepage code project, hence adding that project tag so other people who don't know or don't care about team tags can also find this task when searching via projects. Please set appropriate project tags when possible. Thanks!

I didn't know we had such tag, I will do it in the future. Ty!

@RHo In the current implementation of the Special:Homepage there's a left margin set to 8px in the main group modules whereas the right margin is set to 0 in the sidebar ones. I think we might not need the left margin at all as per designs in figma. Could you confirm we can remove this margin?

Screenshot 2021-12-17 at 12.10.24.png (2×2 px, 1 MB)

Change 748105 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Homepage: avoid invisible link click area on mobile

https://gerrit.wikimedia.org/r/748105

@RHo In the current implementation of the Special:Homepage there's a left margin set to 8px in the main group modules whereas the right margin is set to 0 in the sidebar ones. I think we might not need the left margin at all as per designs in figma. Could you confirm we can remove this margin?

Screenshot 2021-12-17 at 12.10.24.png (2×2 px, 1 MB)

Confirmed, thanks for catching this and fixing it @Sgs!

Change 748105 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Homepage: avoid invisible link click area on mobile

https://gerrit.wikimedia.org/r/748105