Page MenuHomePhabricator
Create Task
Maniphest T298002

Visual diff crashes on table in list
Closed, ResolvedPublic
Actions

Description

As reported at https://www.mediawiki.org/w/index.php?title=Topic:Wipxdpeb19bsrb33&action=history, the following diff crashes:

https://nl.wikipedia.org/wiki/special:diff/60191909

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (4b2339f6e)mediawiki/extensions/VisualEditormaster+3 -1
List diff: Improve handling of complex changesVisualEditor/VisualEditormaster+106 -35
Customize query in gerrit

Event Timeline

Esanders created this task.Dec 19 2021, 1:36 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 19 2021, 1:36 AM
gerritbot added a comment.Dec 19 2021, 1:37 AM

Change 748317 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] List diff: Improve handling of complex changes

https://gerrit.wikimedia.org/r/748317

gerritbot added a project: Patch-For-Review.Dec 19 2021, 1:37 AM
PatchDemoBot added a comment.Dec 19 2021, 2:07 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/20c616f72e/w/

Esanders added a comment.Dec 19 2021, 2:12 PM

https://patchdemo.wmflabs.org/wikis/20c616f72e/w/index.php?title=Special:UserLogin&returnto=Explosiegrens&returntoquery=type%3Drevision%26diff%3D34%26oldid%3D33%26diffmode%3Dvisual

(log in as Patch Demo to enable visual diff)

• BilalShirwani closed this task as a duplicate of T298058: [Impact Analysis] Evaluate Impact of Mobile Reply and New Discussion Tools.Dec 21 2021, 12:02 AM
Zabe reopened this task as Open.Dec 21 2021, 12:16 AM
gerritbot added a comment.Dec 21 2021, 1:13 PM

Change 748317 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] List diff: Improve handling of complex changes

https://gerrit.wikimedia.org/r/748317

Maintenance_bot removed a project: Patch-For-Review.Dec 21 2021, 2:10 PM
matmarex added a project: Editing-team (Kanban Board).Dec 21 2021, 7:20 PM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
gerritbot added a comment.Dec 21 2021, 7:25 PM

Change 749255 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (4b2339f6e)

https://gerrit.wikimedia.org/r/749255

gerritbot added a project: Patch-For-Review.Dec 21 2021, 7:25 PM
gerritbot added a comment.Dec 21 2021, 7:51 PM

Change 749255 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (4b2339f6e)

https://gerrit.wikimedia.org/r/749255

matmarex edited projects, added Editing QA; removed Patch-For-Review.Dec 21 2021, 8:00 PM
matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.
EAkinloose subscribed.Dec 22 2021, 7:35 PM

All good now. Error in the console is gone as well. See

Screenshot 2021-12-22 at 20.33.19.png (2×2 px, 622 KB)

EAkinloose edited projects, added Verified; removed Editing QA.Dec 22 2021, 7:36 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
Esanders renamed this task from Visual diff crashes on list in table to Visual diff crashes on table in list.Jan 19 2022, 1:35 AM
Esanders moved this task from Backlog to In progress on the VisualEditor-VisualDiffs board.Jan 19 2022, 1:40 AM
• ppelberg closed this task as Resolved.Jan 21 2022, 4:22 AM
• ppelberg claimed this task.
PatchDemoBot added a comment.Jan 26 2022, 3:05 PM

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/20c616f72e/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL