Page MenuHomePhabricator

Clean up zh/zh-* namespace aliases in operations/mediawiki-config /wmf-config/InitialiseSettings.php
Closed, ResolvedPublic

Description

Clean up zh/zh-* namespace aliases in operations/mediawiki-config /wmf-config/InitialiseSettings.php .

These namespace aliases are already added to the extension itself, so removing those duplicates from /wmf-config/InitialiseSettings.php would be fine.

Event Timeline

Winston_Sung changed the task status from Open to In Progress.Dec 25 2021, 10:58 AM
Winston_Sung created this task.

Change 747913 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[operations/mediawiki-config@master] Revert \"Add zh-hans and zh-hant translation of Module and Module_talk aliases\" for I9b40319d374143668a2666b42f59a3799d041afc

https://gerrit.wikimedia.org/r/747913

InitialiseSettings.php seems to affected by the related changeset. Can the title be updated to reflect?

@RhinosF1
As you can see in below tasks and changes, none of the canonical namespace name changed: only

  • resorting by namespace ID

and

  • remove the namespace name translations that have merged to the extensions.

Module and Module_talk namespace: T286105 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Scribunto/+/702950
Topic namepace: T296190 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Flow/+/738404

They're related.

For example, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Scribunto/+/702950

/* Below set the canonical namespace name for zh, which prevent being fallback to zh-hans */
$namespaceNames['zh'] = [
	828 => 'Module',
	829 => 'Module_talk',
];

/* Below set the namespace name in variant, which will be fetch in zh via https://gerrit.wikimedia.org/g/mediawiki/core/+/f9ef38f6a5f49d72516027d19248e9bdfa2d7bf7/includes/language/Language.php#726 */
$namespaceNames['zh-hans'] = [
	828 => '模块',
	829 => '模块讨论',
];

$namespaceAliases['zh-hans'] = [
	'模块' => 828,
	'模组' => 828,
	'模块对话' => 829,
	'模块讨论' => 829,
	'模组对话' => 829,
	'模组讨论' => 829,
];

/* Below set the namespace name in variant, which will be fetch in zh via https://gerrit.wikimedia.org/g/mediawiki/core/+/f9ef38f6a5f49d72516027d19248e9bdfa2d7bf7/includes/language/Language.php#726 */
$namespaceNames['zh-hant'] = [
	828 => '模組',
	829 => '模組討論',
];

$namespaceAliases['zh-hant'] = [
	'模組' => 828,
	'模塊' => 828,
	'模組對話' => 829,
	'模組討論' => 829,
	'模塊對話' => 829,
	'模塊討論' => 829,
];

No you're editing a file and the task says a different one. The task should reflect what's actually happening and the change been made. I understand why the change is being done but I'm bothered about what file you're editing and why the file is a different one.

Oh. I think I copied the wrong file name. I'll update it.

Winston_Sung renamed this task from Clean up zh/zh-* namespace aliases in operations/mediawiki-config /wmf-config/CommonSettings.php to Clean up zh/zh-* namespace aliases in operations/mediawiki-config /wmf-config/InitialiseSettings.php.Dec 25 2021, 12:22 PM
Winston_Sung updated the task description. (Show Details)

Change 776031 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[operations/mediawiki-config@master] Rearrange zh namespace names and namespace aliases

https://gerrit.wikimedia.org/r/776031

Change 747913 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "Add zh-hans and zh-hant translation of Module and Module_talk aliases"

https://gerrit.wikimedia.org/r/747913

Mentioned in SAL (#wikimedia-operations) [2022-04-06T08:09:55Z] <kharlan@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:747913|Revert "Add zh-hans and zh-hant translation of Module and Module_talk aliases" (T286291 T298308 T165593 T286105)]] (duration: 00m 56s)

Change 776031 merged by jenkins-bot:

[operations/mediawiki-config@master] Rearrange zh namespace names and namespace aliases

https://gerrit.wikimedia.org/r/776031

Mentioned in SAL (#wikimedia-operations) [2022-04-06T13:51:48Z] <kartik@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:776031|Rearrange zh namespace names and namespace aliases (T286291 T298308)]] (duration: 00m 53s)