Page MenuHomePhabricator
Create Task
Maniphest T298328

Use WAN cache instead of local cluster cache in GrowthExperiments
Closed, ResolvedPublic
Actions

Description

@Ladsgroup said in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/748827/7#message-1bdd570f88402cd35eec06bb64cf04b740ab558c:

The cache for MentorPageMentorManager is ObjectCache::getLocalClusterInstance. LocalCluster cache is a terrible and niche cache that is being deprecated.

I reviewed cache uses in areas of GrowthExperiments I'm responsible for, and I do not see any benefits of using a local cluster cache. Let move to the WAN cache, which seems to be a better fit for what we're doing.

Classes to fix
  • MentorStore
  • DatabaseMenteeOverviewDataProvider
  • WikiPageConfigLoader
  • AqsEditInfoService

Details

SubjectRepoBranchLines +/-
WikiPageConfigLoader: Stop using local cluster cachemediawiki/extensions/GrowthExperimentsmaster+70 -58
AqsEditInfoService: Do not use local cluster cachemediawiki/extensions/GrowthExperimentsmaster+48 -39
MentorStore: Stop using local cluster cachemediawiki/extensions/GrowthExperimentsmaster+57 -66
DatabaseMenteeOverviewDataProvider: Use WAN cache instead of local cluster cachemediawiki/extensions/GrowthExperimentsmaster+14 -30
Customize query in gerrit

Event Timeline

Urbanecm_WMF created this task.Dec 26 2021, 9:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 26 2021, 9:37 PM
Urbanecm_WMF claimed this task.Dec 26 2021, 9:38 PM
Urbanecm_WMF triaged this task as Low priority.
Urbanecm_WMF added a project: User-Urbanecm_WMF (Engineering).

I'll upload patches for areas of code I maintain.

gerritbot added a comment.Dec 26 2021, 9:42 PM

Change 749920 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] DatabaseMenteeOverviewDataProvider: Use WAN cache instead of local cluster cache

https://gerrit.wikimedia.org/r/749920

gerritbot added a project: Patch-For-Review.Dec 26 2021, 9:42 PM
Urbanecm_WMF moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 26 2021, 9:42 PM
gerritbot added a comment.Dec 27 2021, 4:28 PM

Change 749920 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] DatabaseMenteeOverviewDataProvider: Use WAN cache instead of local cluster cache

https://gerrit.wikimedia.org/r/749920

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Dec 27 2021, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 27 2021, 5:10 PM
Tgr subscribed.Dec 27 2021, 5:15 PM

More specifically, cluster-local caches which rely on invalidation won't work correctly once Wikimedia switches to multi-DC (as the WAN cache sends invalidation accross DCs and the cluster-local cache doesn't). For caches which don't need invalidation, I think the behavior is identical (they use the same memcached servers) other than WAN cache having a different PHP handler offering slightly different functionality (and not implementing BagOStuff, which is one of the more annoying design choices around MediaWiki caching IMO).

kostajh moved this task from In Progress to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 4 2022, 12:08 PM
kostajh subscribed.

I think we're done with this task? @Urbanecm_WMF if so please close it out.

Urbanecm_WMF moved this task from QA to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.EditedJan 4 2022, 9:45 PM

@kostajh We still use the local cluster cache in a bunch of places:

  • AqsEditInfoService
  • DatabaseMentorStore
  • WikiPageConfigLoader

Moving to In progress.

gerritbot added a comment.Jan 4 2022, 9:55 PM

Change 751505 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] MentorStore: Stop using local cluster cache

https://gerrit.wikimedia.org/r/751505

gerritbot added a project: Patch-For-Review.Jan 4 2022, 9:55 PM
gerritbot added a comment.Jan 10 2022, 2:49 AM

Change 751505 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] MentorStore: Stop using local cluster cache

https://gerrit.wikimedia.org/r/751505

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.17; 2022-01-10); removed MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Jan 10 2022, 3:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 10 2022, 3:10 AM
Urbanecm_WMF updated the task description. (Show Details)Jan 25 2022, 1:25 AM
Urbanecm_WMF changed the task status from Open to In Progress.Jan 31 2022, 11:33 AM
Urbanecm_WMF moved this task from Backlog to In progress on the User-Urbanecm_WMF (Engineering) board.Feb 12 2022, 7:43 PM
kostajh added a comment.Apr 6 2022, 1:28 PM
In T298328#7597192, @Urbanecm_WMF wrote:

@kostajh We still use the local cluster cache in a bunch of places:

  • AqsEditInfoService
  • DatabaseMentorStore
  • WikiPageConfigLoader

Moving to In progress.

Hi @Urbanecm_WMF, is this one still in progress?

gerritbot added a comment.Apr 7 2022, 6:37 AM

Change 778196 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] AqsEditInfoService: Do not use local cluster cache

https://gerrit.wikimedia.org/r/778196

gerritbot added a project: Patch-For-Review.Apr 7 2022, 6:37 AM
Urbanecm_WMF added a comment.Apr 7 2022, 7:47 AM
In T298328#7835232, @kostajh wrote:
In T298328#7597192, @Urbanecm_WMF wrote:

@kostajh We still use the local cluster cache in a bunch of places:

  • AqsEditInfoService
  • DatabaseMentorStore
  • WikiPageConfigLoader

Moving to In progress.

Hi @Urbanecm_WMF, is this one still in progress?

Yes, sorry, I thought I uploaded some patches for following up. Turns out I did not :). Thanks for the reminder. Done.

kostajh updated the task description. (Show Details)Apr 26 2022, 12:39 PM
gerritbot added a comment.Apr 26 2022, 1:01 PM

Change 778196 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] AqsEditInfoService: Do not use local cluster cache

https://gerrit.wikimedia.org/r/778196

Maintenance_bot removed a project: Patch-For-Review.Apr 26 2022, 1:32 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.10; 2022-05-02).Apr 26 2022, 2:00 PM
kostajh added a comment.Jun 24 2022, 9:58 AM

@Urbanecm_WMF is WikiPageConfigLoader the last one that needs to be done?

MShilova_WMF subscribed.Jul 27 2022, 2:05 PM

@Urbanecm_WMF , tagging you again in case you missed the last comment from Kosta.

Urbanecm_WMF removed a project: User-Urbanecm_WMF (Engineering).Aug 11 2022, 10:38 AM
Urbanecm_WMF added a comment.Aug 11 2022, 4:21 PM
In T298328#8108238, @MShilova_WMF wrote:

@Urbanecm_WMF , tagging you again in case you missed the last comment from Kosta.

Thanks @MShilova_WMF!

In T298328#8025322, @kostajh wrote:

@Urbanecm_WMF is WikiPageConfigLoader the last one that needs to be done?

I think so!

gerritbot added a comment.Sep 4 2022, 5:56 AM

Change 829297 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] WikiPageConfigLoader: Stop using local cluster cache

https://gerrit.wikimedia.org/r/829297

gerritbot added a project: Patch-For-Review.Sep 4 2022, 5:56 AM
Urbanecm_WMF moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 4 2022, 5:56 AM
gerritbot added a comment.Sep 11 2022, 8:53 PM

Change 829297 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] WikiPageConfigLoader: Stop using local cluster cache

https://gerrit.wikimedia.org/r/829297

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.1; 2022-09-12).Sep 11 2022, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 11 2022, 9:30 PM
Urbanecm_WMF closed this task as Resolved.Sep 13 2022, 3:37 PM
Urbanecm_WMF removed a subscriber: MShilova_WMF.Jul 31 2023, 6:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL