Page MenuHomePhabricator

Do not mark edits as minor by default on new section or new page creation
Closed, ResolvedPublic


Author: craig.wenger

Under My preferences->Editing, there is an option to 'Mark all edits minor by default'. However, this is rarely or possibly never desirable when the edit is initiated by the user clicking the 'New section' tab on discussion pages. I recommend an enhancement whereby either (1) the user is not able to mark the edit as minor when clicking the 'New section' tab, or (2) the minor edit checkbox is unchecked by default, regardless of user preferences, after clicking the 'New section' tab.

Version: unspecified
Severity: enhancement



Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 11:33 PM
bzimport set Reference to bz27860.
bzimport added a subscriber: Unknown Object (MLST).

jp.posma wrote:


This patch hides the minor edit checkbox when editing a new page or new section, and makes sure it cannot be enabled by injecting the form value in HTML.


This just introduces new problems. There's no reason why users should be forced to mark such edits as not minor; the definition of minor edit varies among wikis etc.
Comment 0 introduces the problem as caused by the "Mark all edits minor by
default"; the solution is therefore "Do not mark edits as minor by default on new section or new page creation", because that can be indeed be a not-intended behaviour for newbies who don't understand the feature.
Bug 5754 had already been marked as invalid, and the change should be reverted.

Also, it's been noticed on #wikimedia-tech that this is not clearly noted in the changelog.

By the way, this seems to be perceived as a problem only by, and bug 24313 has been fixed after this was submitted.

I also dislike this change... I edit several wikis where new pages can be minor edits and should be marked as such.

This was a very bad idea and I noticed it shortly after it was implemented but didn't know the cause. On Wikisources this is very undesirable. Now it is impossible to create a new page from OCR in the pagespace and mark it as minor, unless it's done by a bot. Creation of a page (as in a pagespace page) is almost always minor. On many projects too, the creation of redirects is minor. The "fix" of course also prevents this on non-WMF instances of mediawiki. This should be reverted.

fabrice.laussy wrote:

This is also bad for me, I use minor edits to prevent announcement of important changes on my wiki:

Now with 1.18 and this new "feature", an essentially empty page such as:

is trumpeted in my

I wish there is the option to mark as minor a newly created page.

Since this has been deployed for a while, I don't think I would want to just revert it.

A possible solution would be to add another global and check that with the isNew() check. This would allow sites to set this on a per-site basis. enwiki could have a different policy than zhwiki then.


fabrice.laussy wrote:

Yes, a per-site basis would be the best option. I understand that on certain wikis, the creation of a new page should never be regarded as minor but on others this could even be the general rule.

I disagree. What project wants this? Comment 3 mentions enwiki but I don't even understand why they would want this and would appreciate a link to the discussion on enwiki where they decided this. Certainly redirects and maybe dabs are minor as are the creation of new user subpages, at the very least.

There was never any reason to make this change. The correct change as noted by Nemo_bis, was to uncheck the box by default and possibly remove the option to change this to checked by default, not remove the box from new pages altogether. Nobody ever really asked for that change; two alternatives were presented and one was simply implemented without comment as to why that was perceived as the better alternative.

Additionally, the original problem was characterized as being for making a "New Section" not creating a page, a new section to an already existing page is actually less likely to be minor than a new page is. This should be reverted unless there is a wiki that thinks it actually needs it to be turned on - that is that they never have minor page creations even for redirects - unless you're a bot, bots can still create new pages as minor.

This bug is fixed and already released, please open a new bug, when a global is needed to disable this "feature". Thanks.