Page MenuHomePhabricator
Create Task
Maniphest T298609

Table with generated cells explodes when clicked
Closed, ResolvedPublic
Actions

Description

Open the tables demo in standalone demo and scroll to the "Alien table":

image.png (181×125 px, 5 KB)

Click on the "I J K L" row, observe the "H" cell jumps out of the table:

image.png (181×161 px, 6 KB)

Inspecting the DOM it looks like <div> cursor holders are getting inserted into the table.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (bbdba097b)mediawiki/extensions/VisualEditormaster+1 -1
Re-apply "Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused"VisualEditor/VisualEditormaster+19 -12
Revert "Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused"VisualEditor/VisualEditormaster+12 -19
Update VE core submodule to master (6282889f4)mediawiki/extensions/VisualEditormaster+1 -1
Update VE core submodule to origin/wmf/1.38.0-wmf.18mediawiki/extensions/VisualEditorwmf/1.38.0-wmf.18+1 -1
Revert "Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused"VisualEditor/VisualEditorwmf/1.38.0-wmf.18+12 -19
Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focusedVisualEditor/VisualEditormaster+19 -12
Update VE core submodule to master (ad9958477)mediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

• Esanders created this task.Jan 5 2022, 1:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 5 2022, 1:45 PM
• Esanders added a comment.Jan 5 2022, 2:10 PM

The "I J K L" should actually be selectable, as it used to be:

image.png (181×134 px, 6 KB)

• Esanders added a project: Regression.Jan 5 2022, 2:15 PM

After some bisecting this is a regression introduced in https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/381235

gerritbot added a comment.Jan 5 2022, 3:19 PM

Change 751753 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused

https://gerrit.wikimedia.org/r/751753

gerritbot added a project: Patch-For-Review.Jan 5 2022, 3:19 PM
gerritbot added a comment.Jan 14 2022, 5:07 PM

Change 751753 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused

https://gerrit.wikimedia.org/r/751753

Maintenance_bot removed a project: Patch-For-Review.Jan 14 2022, 5:10 PM
gerritbot added a comment.Jan 14 2022, 5:18 PM

Change 754000 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ad9958477)

https://gerrit.wikimedia.org/r/754000

gerritbot added a project: Patch-For-Review.Jan 14 2022, 5:18 PM
matmarex added a project: Editing-team (Kanban Board).Jan 14 2022, 5:25 PM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex moved this task from Incoming to Ready for Sign Off on the Editing-team (Kanban Board) board.
matmarex edited projects, added Skipped QA; removed Patch-For-Review.
gerritbot added a comment.Jan 14 2022, 5:39 PM

Change 754000 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ad9958477)

https://gerrit.wikimedia.org/r/754000

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.18; 2022-01-17).Jan 14 2022, 6:00 PM
ppelberg closed this task as Resolved.Jan 21 2022, 4:04 AM
ppelberg claimed this task.
gerritbot added a comment.Jan 24 2022, 6:07 PM

Change 756582 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@master] Revert \"Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused\"

https://gerrit.wikimedia.org/r/756582

gerritbot added a project: Patch-For-Review.Jan 24 2022, 6:07 PM
matmarex reopened this task as Open.Jan 24 2022, 6:13 PM
matmarex moved this task from Ready for Sign Off to Blocked / Needs More Work on the Editing-team (Kanban Board) board.
matmarex removed projects: Patch-For-Review, Skipped QA.
matmarex subscribed.

Reverted, caused T299730.

gerritbot added a comment.Jan 24 2022, 6:15 PM

Change 756582 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Revert \"Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused\"

https://gerrit.wikimedia.org/r/756582

gerritbot added a comment.Jan 24 2022, 6:19 PM

Change 756584 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@wmf/1.38.0-wmf.18] Revert \"Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused\"

https://gerrit.wikimedia.org/r/756584

gerritbot added a project: Patch-For-Review.Jan 24 2022, 6:19 PM
gerritbot added a comment.Jan 24 2022, 6:23 PM

Change 756640 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6282889f4)

https://gerrit.wikimedia.org/r/756640

gerritbot added a comment.Jan 24 2022, 7:11 PM

Change 756584 merged by jenkins-bot:

[VisualEditor/VisualEditor@wmf/1.38.0-wmf.18] Revert \"Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused\"

https://gerrit.wikimedia.org/r/756584

gerritbot added a comment.Jan 24 2022, 7:18 PM

Change 756650 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.18] Update VE core submodule to origin/wmf/1.38.0-wmf.18

https://gerrit.wikimedia.org/r/756650

gerritbot added a comment.Jan 24 2022, 7:43 PM

Change 756650 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.18] Update VE core submodule to origin/wmf/1.38.0-wmf.18

https://gerrit.wikimedia.org/r/756650

Stashbot mentioned this in T299730: VE: Elements placed in bulleted list (* or #) aren't editable by mouse.Jan 24 2022, 7:47 PM

Mentioned in SAL (#wikimedia-operations) [2022-01-24T19:47:03Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.18/extensions/VisualEditor/lib/ve/: a369e0a: Revert "Follow-up I0802440d9: Allow alien <tr>/<td> s to be focused" (deployed via rEVEDe09d79dd748b; T298609; T299730) (duration: 00m 49s)

gerritbot added a comment.Jan 24 2022, 10:48 PM

Change 756640 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6282889f4)

https://gerrit.wikimedia.org/r/756640

gerritbot added a comment.Jan 25 2022, 7:28 PM

Change 756694 had a related patch set uploaded (by Bartosz Dziewoński; author: Esanders):

[VisualEditor/VisualEditor@master] Re-apply \"Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused\"

https://gerrit.wikimedia.org/r/756694

gerritbot added a comment.Jan 25 2022, 7:33 PM

Change 756694 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Re-apply \"Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused\"

https://gerrit.wikimedia.org/r/756694

gerritbot added a comment.Jan 25 2022, 7:58 PM

Change 757074 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bbdba097b)

https://gerrit.wikimedia.org/r/757074

gerritbot added a comment.Jan 25 2022, 8:11 PM

Change 757074 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bbdba097b)

https://gerrit.wikimedia.org/r/757074

matmarex moved this task from Blocked / Needs More Work to Ready for Sign Off on the Editing-team (Kanban Board) board.Jan 25 2022, 8:32 PM
matmarex edited projects, added Skipped QA; removed Patch-For-Review.
ppelberg closed this task as Resolved.Jan 29 2022, 1:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits