Page MenuHomePhabricator

Table with generated cells explodes when clicked
Closed, ResolvedPublic

Description

Open the tables demo in standalone demo and scroll to the "Alien table":

image.png (181×125 px, 5 KB)

Click on the "I J K L" row, observe the "H" cell jumps out of the table:

image.png (181×161 px, 6 KB)

Inspecting the DOM it looks like <div> cursor holders are getting inserted into the table.

Event Timeline

The "I J K L" should actually be selectable, as it used to be:

image.png (181×134 px, 6 KB)

Change 751753 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused

https://gerrit.wikimedia.org/r/751753

Change 751753 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused

https://gerrit.wikimedia.org/r/751753

Change 754000 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ad9958477)

https://gerrit.wikimedia.org/r/754000

Change 754000 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ad9958477)

https://gerrit.wikimedia.org/r/754000

ppelberg claimed this task.

Change 756582 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@master] Revert \"Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused\"

https://gerrit.wikimedia.org/r/756582

Change 756582 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Revert \"Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused\"

https://gerrit.wikimedia.org/r/756582

Change 756584 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@wmf/1.38.0-wmf.18] Revert \"Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused\"

https://gerrit.wikimedia.org/r/756584

Change 756640 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6282889f4)

https://gerrit.wikimedia.org/r/756640

Change 756584 merged by jenkins-bot:

[VisualEditor/VisualEditor@wmf/1.38.0-wmf.18] Revert \"Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused\"

https://gerrit.wikimedia.org/r/756584

Change 756650 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.18] Update VE core submodule to origin/wmf/1.38.0-wmf.18

https://gerrit.wikimedia.org/r/756650

Change 756650 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.18] Update VE core submodule to origin/wmf/1.38.0-wmf.18

https://gerrit.wikimedia.org/r/756650

Mentioned in SAL (#wikimedia-operations) [2022-01-24T19:47:03Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.18/extensions/VisualEditor/lib/ve/: a369e0a: Revert "Follow-up I0802440d9: Allow alien <tr>/<td> s to be focused" (deployed via e09d79d; T298609; T299730) (duration: 00m 49s)

Change 756640 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6282889f4)

https://gerrit.wikimedia.org/r/756640

Change 756694 had a related patch set uploaded (by Bartosz Dziewoński; author: Esanders):

[VisualEditor/VisualEditor@master] Re-apply \"Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused\"

https://gerrit.wikimedia.org/r/756694

Change 756694 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Re-apply \"Follow-up I0802440d9: Allow alien <tr>/<td>'s to be focused\"

https://gerrit.wikimedia.org/r/756694

Change 757074 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bbdba097b)

https://gerrit.wikimedia.org/r/757074

Change 757074 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bbdba097b)

https://gerrit.wikimedia.org/r/757074