Page MenuHomePhabricator
Create Task
Maniphest T298828

There's no way to delete a template transclusion in mobile web
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Description

To reproduce:

Whenever I try to delete a template transclusion, the template gets selected and the keyboard disappears. A template editing panel appears, but it doesn't have a button to delete the transclusion.

I'm testing on these:

  • Device: Samsung Galaxy S21 FE
  • Browser: Firefox and Chrome
  • Keyboard apps: Gboard and Samsung Keyboard

The results are the same everywhere.

Details

SubjectRepoBranchLines +/-
Restore a way to delete transclusions on mobilemediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.Jan 8 2022, 11:16 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 8 2022, 11:16 AM
matmarex subscribed.Jan 8 2022, 1:00 PM

This might ironically be a regression from T274263: Add button to delete template in the context menu. We used to show a delete button for templates on mobile, but not on desktop. Now the plan (T286990) is to show it everywhere, but it looks like in the process, it has been made consistent first.

Amire80 added a comment.Jan 8 2022, 1:42 PM

LOL :)

I like that button on the desktop, and I thought that putting it everywhere is a good solution, but I didn't think that it's also the cause!

gerritbot added a comment.Jan 20 2022, 9:42 PM

Change 755799 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Restore a way to delete transclusions on mobile

https://gerrit.wikimedia.org/r/755799

gerritbot added a project: Patch-For-Review.Jan 20 2022, 9:42 PM
matmarex claimed this task.Jan 20 2022, 9:42 PM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex added a project: Editing-team (Kanban Board).
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
thiemowmde added a project: Regression.Jan 21 2022, 4:13 PM
thiemowmde added projects: WMDE-TechWish-Sprint-2022-01-19, Unplanned-Sprint-Work.
thiemowmde moved this task from Sprint Backlog to Demo on the WMDE-TechWish-Sprint-2022-01-19 board.
gerritbot added a comment.Jan 21 2022, 4:31 PM

Change 755799 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Restore a way to delete transclusions on mobile

https://gerrit.wikimedia.org/r/755799

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 21 2022, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 21 2022, 5:10 PM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Jan 21 2022, 8:16 PM
matmarex added a project: Editing QA.
EAkinloose subscribed.Jan 29 2022, 3:44 AM

Delete button is now displayed. See:

IMG_3353.PNG (2×1 px, 341 KB)

IMG_3352.PNG (2×1 px, 304 KB)

EAkinloose edited projects, added Verified; removed Editing QA.Jan 29 2022, 3:44 AM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
Amire80 added a comment.Jan 29 2022, 7:13 AM

Thanks! ❤️

WMDE-Fisch set the point value for this task to 1.Jan 31 2022, 1:29 PM
thiemowmde moved this task from Demo to Watching / Epic / Stalled on the WMDE-TechWish-Sprint-2022-01-19 board.Feb 1 2022, 9:10 AM
WMDE-Fisch moved this task from Watching / Epic / Stalled to Done on the WMDE-TechWish-Sprint-2022-01-19 board.Feb 1 2022, 9:12 AM
WMDE-Fisch closed this task as Resolved.Feb 4 2022, 10:37 AM
WMDE-Fisch subscribed.

Seems solved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits