Page MenuHomePhabricator

There's no way to delete a template transclusion in mobile web
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

To reproduce:

Whenever I try to delete a template transclusion, the template gets selected and the keyboard disappears. A template editing panel appears, but it doesn't have a button to delete the transclusion.

I'm testing on these:

  • Device: Samsung Galaxy S21 FE
  • Browser: Firefox and Chrome
  • Keyboard apps: Gboard and Samsung Keyboard

The results are the same everywhere.

Event Timeline

This might ironically be a regression from T274263: Add button to delete template in the context menu. We used to show a delete button for templates on mobile, but not on desktop. Now the plan (T286990) is to show it everywhere, but it looks like in the process, it has been made consistent first.

LOL :)

I like that button on the desktop, and I thought that putting it everywhere is a good solution, but I didn't think that it's also the cause!

Change 755799 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Restore a way to delete transclusions on mobile

https://gerrit.wikimedia.org/r/755799

Change 755799 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Restore a way to delete transclusions on mobile

https://gerrit.wikimedia.org/r/755799

Delete button is now displayed. See:

IMG_3353.PNG (2×1 px, 341 KB)

IMG_3352.PNG (2×1 px, 304 KB)

WMDE-Fisch set the point value for this task to 1.Jan 31 2022, 1:29 PM
WMDE-Fisch added a subscriber: WMDE-Fisch.

Seems solved.