Page MenuHomePhabricator

Visual diffs sometimes missing TemplateStyles
Open, Needs TriagePublic

Description

Visual diffs are missing TemplateStyles when the first occurence of a template defining these styles has been elided as part of the diff context.

Example: https://en.wikipedia.org/w/index.php?title=Trojan_horse_(computing)&diff=1049394934&oldid=1049278594&diffmode=visual

image.png (2×3 px, 530 KB)

Compare to the rendering of the sidebar templates in the article:

image.png (2×3 px, 587 KB)

Event Timeline

Change 751453 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Re-duplicate deduplicated TemplateStyles

https://gerrit.wikimedia.org/r/751453

Change 751453 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Re-duplicate deduplicated TemplateStyles

https://gerrit.wikimedia.org/r/751453

Screenshot 2022-01-19 at 03.24.00.png (2×3 px, 1 MB)

Screenshot 2022-01-19 at 03.24.11.png (2×3 px, 991 KB)

templateStyles remain intact in visual diffs.

Change 756005 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Revert \"Re-duplicate deduplicated TemplateStyles\"

https://gerrit.wikimedia.org/r/756005

Change 756066 had a related patch set uploaded (by Brennen Bearnes; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.18] Revert \"Re-duplicate deduplicated TemplateStyles\"

https://gerrit.wikimedia.org/r/756066

Change 756005 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Revert \"Re-duplicate deduplicated TemplateStyles\"

https://gerrit.wikimedia.org/r/756005

Change 756066 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.18] Revert \"Re-duplicate deduplicated TemplateStyles\"

https://gerrit.wikimedia.org/r/756066

Mentioned in SAL (#wikimedia-operations) [2022-01-21T21:38:56Z] <brennen@deploy1002> Synchronized php-1.38.0-wmf.18/extensions/VisualEditor/modules/ve-mw: Backport: [[gerrit:756066|Revert "Re-duplicate deduplicated TemplateStyles" (T287675 T299251 T299767)]] (duration: 00m 49s)

Change 756682 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Re-apply \"Re-duplicate deduplicated TemplateStyles\"

https://gerrit.wikimedia.org/r/756682