Page MenuHomePhabricator
Create Task
Maniphest T299251

Visual diffs sometimes missing TemplateStyles
Closed, ResolvedPublic
Actions

Assigned To
matmarex
Authored By
matmarex
Jan 14 2022, 9:34 PM
Tags
Referenced Files
F34922360: Screenshot 2022-01-19 at 03.24.00.png
Jan 19 2022, 2:51 AM
F34922361: Screenshot 2022-01-19 at 03.24.11.png
Jan 19 2022, 2:51 AM
F34918580: image.png
Jan 14 2022, 9:34 PM
F34918582: image.png
Jan 14 2022, 9:34 PM
Subscribers
Aklapper
EAkinloose
• Esanders
matmarex

Description

Visual diffs are missing TemplateStyles when the first occurence of a template defining these styles has been elided as part of the diff context.

Example: https://en.wikipedia.org/w/index.php?title=Trojan_horse_(computing)&diff=1049394934&oldid=1049278594&diffmode=visual

image.png (2×3 px, 530 KB)

Compare to the rendering of the sidebar templates in the article:

image.png (2×3 px, 587 KB)

Details

SubjectRepoBranchLines +/-
Re-apply "Re-duplicate deduplicated TemplateStyles"mediawiki/extensions/VisualEditormaster+195 -0
Revert "Re-duplicate deduplicated TemplateStyles"mediawiki/extensions/VisualEditormaster+0 -76
Revert "Re-duplicate deduplicated TemplateStyles"mediawiki/extensions/VisualEditorwmf/1.38.0-wmf.18+0 -76
Re-duplicate deduplicated TemplateStylesmediawiki/extensions/VisualEditormaster+76 -0
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Jan 14 2022, 9:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 14 2022, 9:34 PM
matmarex claimed this task.Jan 14 2022, 9:35 PM
matmarex added a project: Editing-team (Kanban Board).
matmarex added a subscriber: • Esanders.
gerritbot added a comment.Jan 14 2022, 9:35 PM

Change 751453 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Re-duplicate deduplicated TemplateStyles

https://gerrit.wikimedia.org/r/751453

gerritbot added a project: Patch-For-Review.Jan 14 2022, 9:35 PM
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Jan 14 2022, 9:35 PM
Maintenance_bot added a project: VisualEditor.Jan 14 2022, 9:45 PM
gerritbot added a comment.Jan 16 2022, 12:24 AM

Change 751453 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Re-duplicate deduplicated TemplateStyles

https://gerrit.wikimedia.org/r/751453

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.18; 2022-01-17).Jan 16 2022, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 16 2022, 1:10 AM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.Jan 16 2022, 1:59 AM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.
matmarex added a project: Editing QA.
• Esanders moved this task from Backlog to In progress on the VisualEditor-VisualDiffs board.Jan 19 2022, 1:40 AM
matmarex moved this task from Inbox to Low Priority on the Editing QA board.Jan 19 2022, 2:50 AM
EAkinloose subscribed.Jan 19 2022, 2:51 AM

Screenshot 2022-01-19 at 03.24.00.png (2×3 px, 1 MB)

Screenshot 2022-01-19 at 03.24.11.png (2×3 px, 991 KB)

templateStyles remain intact in visual diffs.

EAkinloose edited projects, added Verified; removed Editing QA.Jan 19 2022, 2:52 AM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
ppelberg closed this task as Resolved.Jan 21 2022, 3:59 AM
gerritbot added a comment.Jan 21 2022, 9:10 PM

Change 756005 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Revert \"Re-duplicate deduplicated TemplateStyles\"

https://gerrit.wikimedia.org/r/756005

gerritbot added a project: Patch-For-Review.Jan 21 2022, 9:10 PM
gerritbot added a comment.Jan 21 2022, 9:16 PM

Change 756066 had a related patch set uploaded (by Brennen Bearnes; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.18] Revert \"Re-duplicate deduplicated TemplateStyles\"

https://gerrit.wikimedia.org/r/756066

gerritbot added a comment.Jan 21 2022, 9:29 PM

Change 756005 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Revert \"Re-duplicate deduplicated TemplateStyles\"

https://gerrit.wikimedia.org/r/756005

gerritbot added a comment.Jan 21 2022, 9:34 PM

Change 756066 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.18] Revert \"Re-duplicate deduplicated TemplateStyles\"

https://gerrit.wikimedia.org/r/756066

Stashbot mentioned this in T287675: De-duplicated TemplateStyles missing when editing a section in visual section editing.Jan 21 2022, 9:38 PM
Stashbot mentioned this in T299767: Triggering Infobox duplication: Adds a large block of source text.

Mentioned in SAL (#wikimedia-operations) [2022-01-21T21:38:56Z] <brennen@deploy1002> Synchronized php-1.38.0-wmf.18/extensions/VisualEditor/modules/ve-mw: Backport: [[gerrit:756066|Revert "Re-duplicate deduplicated TemplateStyles" (T287675 T299251 T299767)]] (duration: 00m 49s)

matmarex reopened this task as Open.Jan 21 2022, 9:43 PM
matmarex moved this task from Ready for Sign Off to Blocked / Needs More Work on the Editing-team (Kanban Board) board.
matmarex removed projects: Patch-For-Review, Verified, MW-1.38-notes (1.38.0-wmf.18; 2022-01-17).

Reverted, the fix caused T299767.

gerritbot added a comment.Jan 24 2022, 9:37 PM

Change 756682 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Re-apply \"Re-duplicate deduplicated TemplateStyles\"

https://gerrit.wikimedia.org/r/756682

gerritbot added a project: Patch-For-Review.Jan 24 2022, 9:37 PM
matmarex moved this task from Blocked / Needs More Work to Code Review on the Editing-team (Kanban Board) board.Jan 24 2022, 9:50 PM
gerritbot added a comment.Feb 1 2022, 11:36 PM

Change 756682 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Re-apply \"Re-duplicate deduplicated TemplateStyles\"

https://gerrit.wikimedia.org/r/756682

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.21; 2022-02-07).Feb 2 2022, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 2 2022, 12:10 AM
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Feb 2 2022, 12:28 AM
matmarex added a project: Editing QA.
matmarex moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.May 23 2022, 5:32 PM
matmarex edited projects, added Skipped QA; removed Editing QA.
ppelberg closed this task as Resolved.Jun 3 2022, 11:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits