Page MenuHomePhabricator

Add Login button to pages without one
Closed, ResolvedPublic

Description

Some pages on The Wikipedia Library are viewable by users who aren't logged in, but there are no obvious ways for them to initiate the login process.

When the user isn't logged in, the header should have a blue button (like the one used for linking to a logged in user's profile) at the right end which says 'Login' and will initiate the login sequence. Users should be redirected back to the page they were on.

Event Timeline

I'm sorry I'm new but I want to ask how can I start working on this issue.

Hi @ShailRT, thanks for your interest in contributing!

You can find guidance on getting set up with contributing to the library at https://github.com/WikipediaLibrary/TWLight/wiki

Please let me know if you have any questions :)

Thanks @Samwalton9, I'll get to it ASAP and I also wanted to know how should I ask questions on Phabricator

@Samwalton9 it seems that to setup on Pycharm I need to have a licensed version of it. Can I use any other editor like vscode.

Yes of course, we included step-by-step instructions for PyCharm but you can set the tool up using any software you like :)

I am editing html file in templates named as header_partial_b4.html and adding a condition which will display login button if user is not logged in.
am I on right track?

@Samwalton9 I think I have done it how can I send the push request?

I think I have done it how can I send the push request?

@ShailRT, follow the instructions here, in sections 7 or 9, which ever feels best for you.

@Samwalton9 I think I have done it how can I send the push request?

That's great @ShailRT! Please push your changes to GitHub and file a Pull Request to the master branch: https://github.com/WikipediaLibrary/TWLight.

Thanks for the input @Klein, but the Library-Card-Platform doesn't use Gerrit :)

@Samwalton9 Sorry this was my first contribution so I think I messed up the first time but I have filed a pull request on the master branch.
Request link: https://github.com/WikipediaLibrary/TWLight/pull/950

Hello @Samwalton9 is this issue is still open? or I can't work on this unless it is assigned to me? I want to contribute in this issue.

Hello @Samwalton9 can i work on this issue , if you haven't any problem please give me this task and i am excited about this task and if yes then guide me and reply as soon as possible.

Hi, this task was being worked on by @ShailRT but it seems like no changes have been made recently.

Please feel free to work on it.

Ankit18gupta subscribed.

Hi @Samwalton9

Filed the PR #974. :)

Please review it.

Hi, @Samwalton9 is this task is still open, should I go ahead to work on it?

Hi @abhigya_pandey - this task has been worked on and is awaiting review, sorry.

I don't see this on production (e.g. if I navigate to https://wikipedialibrary.wmflabs.org/about/ while logged out). Do you know why?

@Samwalton9 that's on me; the image didn't get built due to my work on the travis build issue. Fix is in the pipeline!

Now live and looking good!