Page MenuHomePhabricator
Create Task
Maniphest T300340

Use Memcached with Quibble
Closed, ResolvedPublic
Actions

Description

In theory this would help with performance on api-testing and browser tests, and requires a minimum amount of configuration, so might be worth the effort to do.

Details

SubjectRepoBranchLines +/-
jjb: update MediaWiki jobs to Quibble 1.4.5 imageintegration/configmaster+15 -13
jjb: switch wmf-quibble jobs to Quibble 1.4.5integration/configmaster+4 -2
jjb: update wikibase jobs to Quibble 1.4.5integration/configmaster+2 -1
jjb: update coverage jobs to Quibble image 1.4.5integration/configmaster+16 -6
jjb: update codehealth patches to Quibble image 1.4.5integration/configmaster+4 -2
jjb: update Phan jobs to Quibble 1.4.5 imageintegration/configmaster+5 -5
jjb: update api-testing jobs to Quibble 1.4.5 imageintegration/configmaster+2 -2
jjb: update fundraising jobs to Quibble 1.4.5 imageintegration/configmaster+6 -2
jjb: update quibble-daily jobs to Quibble 1.4.5 imageintegration/configmaster+2 -1
jjb: update integration/quibble job to 1.4.5 imageintegration/configmaster+4 -4
jjb: switch jobs to Quibble 1.4.4integration/configmaster+32 -32
jjb: Bump Quibble jobs to use memcachedintegration/configmaster+32 -32
dockerfiles: update to Quibble 1.4.4integration/configmaster+55 -1
release: Quibble 1.4.4integration/quibblemaster+8 -3
LocalSettings: Move Memcached block and define MemCachedServersintegration/quibblemaster+7 -5
dockerfiles: Install memcached and php-memcached for Quibbleintegration/configmaster+74 -1
jjb: update Quibble jobs from 1.3.0 to 1.4.3integration/configmaster+32 -32
jjb: update Quibble jobs from 1.3.0 to 1.4.0integration/configmaster+28 -28
release: Quibble 1.4.0integration/quibblemaster+27 -3
Set Memcached as main cache type if extension is loadedintegration/quibblemaster+5 -0
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.Jan 28 2022, 9:30 AM
gerritbot added a comment.Jan 28 2022, 9:31 AM

Change 757844 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/quibble@master] Set Memcached as main cache type if extension is loaded

https://gerrit.wikimedia.org/r/757844

gerritbot added a project: Patch-For-Review.Jan 28 2022, 9:31 AM
gerritbot added a comment.Jan 28 2022, 9:37 AM

Change 757867 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/config@master] dockerfiles: Install memcached and php-memcached for Quibble

https://gerrit.wikimedia.org/r/757867

Krinkle subscribed.EditedJan 30 2022, 3:27 AM

Given we have only a single local server in CI, I'm not sure Memcached would help compared to php-apcu. Memcached is more advanced for sure in keeping hot objects (LRU) instead of resetting when it is full, but given little to no concurrency that's unlikely to make a difference.

During PHPUnit runs we currently (and should) disable all such caching already, so it wouldn't help there. For QUnit we only make 1 or 2 requests. For Selenium, it might help a bit to have wgMainCacheType set to something other than "none", e.g. apcu might make a difference. Worth a try I suppose to see if it makes a difference.

I don't mind Memcached being added. It might help to make it a bit more production-like. On the other hand, it would also make it therefore less like most local dev environments, which might make debugging harder when behaviour is differnet, and it makes the Quibble stack more complex and maintenance heavy which I don't know if we want to do, unless we're sure that it speeds up CI. The call on whether to take it on (after initial experiment) is up to RelEng I think.

I propose we try apcu first to see if it speeds up Selenium, and then with memcached to see if it speeds it up even more.

gerritbot added a comment.Jan 31 2022, 12:18 PM

Change 757844 merged by jenkins-bot:

[integration/quibble@master] Set Memcached as main cache type if extension is loaded

https://gerrit.wikimedia.org/r/757844

gerritbot added a comment.Feb 1 2022, 7:37 PM

Change 758952 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/quibble@master] release: Quibble 1.4.0

https://gerrit.wikimedia.org/r/758952

gerritbot added a comment.Feb 3 2022, 1:34 PM

Change 758952 merged by jenkins-bot:

[integration/quibble@master] release: Quibble 1.4.0

https://gerrit.wikimedia.org/r/758952

Stashbot mentioned this in T225730: Reduce runtime of MW shared gate Jenkins jobs to 5 min.Feb 3 2022, 1:51 PM
Stashbot mentioned this in T291549: Evaluate phpbench for benchmarking and guarding against performance regressions.

Mentioned in SAL (#wikimedia-releng) [2022-02-03T13:51:27Z] <kostajh> Tag Quibble 1.4.0 @ 4231bc2832395d94e29a332fe8d863301a0cd441 # T300340 T291549 T225730

gerritbot added a comment.Feb 17 2022, 4:52 PM

Change 763559 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: update Quibble jobs from 1.3.0 to 1.4.0

https://gerrit.wikimedia.org/r/763559

Stashbot added a comment.Feb 21 2022, 7:31 AM

Mentioned in SAL (#wikimedia-releng) [2022-02-21T07:31:03Z] <hashar> Switching Quibble jobs from Quibble 1.3.0 to 1.4.0 # T300340 T291549 T225730

gerritbot added a comment.Feb 21 2022, 7:34 AM

Change 763559 merged by jenkins-bot:

[integration/config@master] jjb: update Quibble jobs from 1.3.0 to 1.4.0

https://gerrit.wikimedia.org/r/763559

gerritbot added a comment.Mar 3 2022, 11:59 AM

Change 767749 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: update Quibble jobs from 1.3.0 to 1.4.3

https://gerrit.wikimedia.org/r/767749

gerritbot added a comment.Mar 3 2022, 1:03 PM

Change 767749 merged by jenkins-bot:

[integration/config@master] jjb: update Quibble jobs from 1.3.0 to 1.4.3

https://gerrit.wikimedia.org/r/767749

gerritbot added a comment.Mar 14 2022, 9:47 AM

Change 757867 merged by jenkins-bot:

[integration/config@master] dockerfiles: Install memcached and php-memcached for Quibble

https://gerrit.wikimedia.org/r/757867

Stashbot added a comment.Mar 14 2022, 9:52 AM

Mentioned in SAL (#wikimedia-releng) [2022-03-14T09:52:02Z] <hashar> Building Quibble Docker images for https://gerrit.wikimedia.org/r/757867 | T300340

hashar subscribed.Mar 14 2022, 10:29 AM
Successfully published image docker-registry.discovery.wmnet/releng/quibble-buster-php74:1.4.3-s3
Successfully published image docker-registry.discovery.wmnet/releng/quibble-buster-php72:1.4.3-s2
Successfully published image docker-registry.discovery.wmnet/releng/quibble-buster-php73:1.4.3-s3
Successfully published image docker-registry.discovery.wmnet/releng/quibble-buster:1.4.3-s2
Successfully published image docker-registry.discovery.wmnet/releng/quibble-fresnel:1.4.3-s2
Successfully published image docker-registry.discovery.wmnet/releng/quibble-buster-php73-coverage:1.4.3-s3
Successfully published image docker-registry.discovery.wmnet/releng/quibble-buster-php80:1.4.3-s3
Successfully published image docker-registry.discovery.wmnet/releng/quibble-buster-php72-bundle:1.4.3-s2
Successfully published image docker-registry.discovery.wmnet/releng/quibble-buster-php81:1.4.3-s3
gerritbot added a comment.Mar 14 2022, 10:55 AM

Change 770468 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/config@master] jjb: Bump Quibble jobs to 1.4.3-s3

https://gerrit.wikimedia.org/r/770468

gerritbot added a comment.Mar 14 2022, 2:49 PM

Change 770518 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/quibble@master] LocalSettings: Define MemCachedServers when memcached is loaded

https://gerrit.wikimedia.org/r/770518

gerritbot added a comment.Mar 17 2022, 8:56 AM

Change 770518 merged by jenkins-bot:

[integration/quibble@master] LocalSettings: Move Memcached block and define MemCachedServers

https://gerrit.wikimedia.org/r/770518

Stashbot added a comment.Mar 17 2022, 4:25 PM

Mentioned in SAL (#wikimedia-releng) [2022-03-17T16:25:02Z] <hashar> Switching Quibble jobs to use memcached rather than APCu | https://gerrit.wikimedia.org/r/c/integration/config/+/770468 | T300340

gerritbot added a comment.Mar 17 2022, 4:35 PM

Change 771636 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/quibble@master] release: Quibble 1.4.4

https://gerrit.wikimedia.org/r/771636

gerritbot added a comment.Mar 17 2022, 4:42 PM

Change 771639 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] dockerfiles: update to Quibble 1.4.4

https://gerrit.wikimedia.org/r/771639

gerritbot added a comment.Mar 17 2022, 4:48 PM

Change 771640 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: switch jobs to Quibble 1.4.4

https://gerrit.wikimedia.org/r/771640

gerritbot added a comment.Mar 17 2022, 5:08 PM

Change 771636 merged by jenkins-bot:

[integration/quibble@master] release: Quibble 1.4.4

https://gerrit.wikimedia.org/r/771636

Stashbot added a comment.Mar 17 2022, 7:06 PM

Mentioned in SAL (#wikimedia-releng) [2022-03-17T19:06:07Z] <hashar> Tag Quibble 1.4.4 @ 56b2c9ba52c # T300340

gerritbot added a comment.Mar 17 2022, 7:09 PM

Change 771639 merged by jenkins-bot:

[integration/config@master] dockerfiles: update to Quibble 1.4.4

https://gerrit.wikimedia.org/r/771639

gerritbot added a comment.Mar 18 2022, 8:12 AM

Change 771640 merged by jenkins-bot:

[integration/config@master] jjb: switch jobs to Quibble 1.4.4

https://gerrit.wikimedia.org/r/771640

gerritbot added a comment.Mar 18 2022, 8:41 AM

Change 770468 abandoned by Kosta Harlan:

[integration/config@master] jjb: Bump Quibble jobs to use memcached

Reason:

https://gerrit.wikimedia.org/r/770468

kostajh mentioned this in T304147: jenkis CI wikibase-repo-docker failing with new quibble version.Mar 18 2022, 10:50 AM
kostajh added a subtask: T304147: jenkis CI wikibase-repo-docker failing with new quibble version.Mar 24 2022, 8:46 PM
gerritbot added a comment.Apr 28 2022, 12:55 PM

Change 787492 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: update integration/quibble job to 1.4.5 image

https://gerrit.wikimedia.org/r/787492

gerritbot added a comment.Apr 28 2022, 12:55 PM

Change 787493 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: update quibble-daily jobs to Quibble 1.4.5 image

https://gerrit.wikimedia.org/r/787493

gerritbot added a comment.Apr 28 2022, 12:55 PM

Change 787494 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: update fundraising jobs to Quibble 1.4.5 image

https://gerrit.wikimedia.org/r/787494

hashar added a parent task: T294260: Upgrade dockerfiles to use composer 2.1.9 per CVE-2021-41116.Apr 28 2022, 12:56 PM
hashar mentioned this in T294260: Upgrade dockerfiles to use composer 2.1.9 per CVE-2021-41116.
gerritbot added a comment.May 9 2022, 12:17 PM

Change 787492 merged by jenkins-bot:

[integration/config@master] jjb: update integration/quibble job to 1.4.5 image

https://gerrit.wikimedia.org/r/787492

gerritbot added a comment.May 9 2022, 12:47 PM

Change 787493 merged by jenkins-bot:

[integration/config@master] jjb: update quibble-daily jobs to Quibble 1.4.5 image

https://gerrit.wikimedia.org/r/787493

gerritbot added a comment.May 9 2022, 1:48 PM

Change 787494 merged by jenkins-bot:

[integration/config@master] jjb: update fundraising jobs to Quibble 1.4.5 image

https://gerrit.wikimedia.org/r/787494

gerritbot added a comment.May 9 2022, 1:54 PM

Change 790370 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: update api-testing jobs to Quibble 1.4.5 image

https://gerrit.wikimedia.org/r/790370

gerritbot added a comment.May 9 2022, 2:09 PM

Change 790370 merged by jenkins-bot:

[integration/config@master] jjb: update api-testing jobs to Quibble 1.4.5 image

https://gerrit.wikimedia.org/r/790370

gerritbot added a comment.May 9 2022, 2:12 PM

Change 790377 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: update Phan jobs to Quibble 1.4.5 image

https://gerrit.wikimedia.org/r/790377

gerritbot added a comment.May 9 2022, 2:19 PM

Change 790380 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: update codehealth patches to Quibble image 1.4.5

https://gerrit.wikimedia.org/r/790380

gerritbot added a comment.May 9 2022, 2:20 PM

Change 790381 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: update coverage jobs to Quibble image 1.4.5

https://gerrit.wikimedia.org/r/790381

gerritbot added a comment.May 10 2022, 8:24 AM

Change 790377 merged by jenkins-bot:

[integration/config@master] jjb: update Phan jobs to Quibble 1.4.5 image

https://gerrit.wikimedia.org/r/790377

gerritbot added a comment.May 10 2022, 8:26 AM

Change 790380 merged by jenkins-bot:

[integration/config@master] jjb: update codehealth patches to Quibble image 1.4.5

https://gerrit.wikimedia.org/r/790380

gerritbot added a comment.May 10 2022, 8:34 AM

Change 790381 merged by jenkins-bot:

[integration/config@master] jjb: update coverage jobs to Quibble image 1.4.5

https://gerrit.wikimedia.org/r/790381

gerritbot added a comment.May 10 2022, 8:35 AM

Change 790621 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: update wikibase jobs to Quibble 1.4.5

https://gerrit.wikimedia.org/r/790621

hashar closed subtask T304147: jenkis CI wikibase-repo-docker failing with new quibble version as Resolved.May 10 2022, 8:42 AM
gerritbot added a comment.May 10 2022, 8:44 AM

Change 790621 merged by jenkins-bot:

[integration/config@master] jjb: update wikibase jobs to Quibble 1.4.5

https://gerrit.wikimedia.org/r/790621

gerritbot added a comment.May 10 2022, 10:35 AM

Change 790638 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: switch wmf-quibble jobs to Quibble 1.4.5

https://gerrit.wikimedia.org/r/790638

gerritbot added a comment.May 10 2022, 10:39 AM

Change 790641 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: update MediaWiki jobs to Quibble 1.4.5 image

https://gerrit.wikimedia.org/r/790641

gerritbot added a comment.May 10 2022, 11:20 AM

Change 790638 merged by jenkins-bot:

[integration/config@master] jjb: switch wmf-quibble jobs to Quibble 1.4.5

https://gerrit.wikimedia.org/r/790638

Stashbot added a comment.May 10 2022, 12:06 PM

Mentioned in SAL (#wikimedia-releng) [2022-05-10T12:06:28Z] <hashar> Updating Quibble jobs to image 1.4.5 with Memcached enabled | https://gerrit.wikimedia.org/r/c/integration/config/+/790641 | T300340

hashar closed this task as Resolved.May 10 2022, 12:23 PM
hashar assigned this task to kostajh.

It is finally fully deployed

kostajh added a comment.May 10 2022, 12:25 PM
In T300340#7917210, @hashar wrote:

It is finally fully deployed

✨ thank you @hashar!

kostajh updated the task description. (Show Details)May 10 2022, 12:25 PM
gerritbot added a comment.May 10 2022, 1:55 PM

Change 790641 merged by jenkins-bot:

[integration/config@master] jjb: update MediaWiki jobs to Quibble 1.4.5 image

https://gerrit.wikimedia.org/r/790641

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL