Page MenuHomePhabricator

Specifically note that user's email address may be shared with external organisation in application form for EMAIL partners
Closed, ResolvedPublic

Description

For resources which have the EMAIL access method, it may not be obvious to users that we will use their email address to set up access with the partner.

In the terms of use we have written:

we will share your information with the publishers whom you specifically select in order to provide you with access to resources. Otherwise, your information will not be shared with third parties, with the exception of the circumstances described below.

But this requires reading the TOU to understand.

We could add a line to the top of the application form, only if the partner has the EMAIL authorization method, which states:

If your application is successful we may share your email address with <PARTNER NAME>. This is required to set up your access to their resources. By submitting this form you agree to allow your email address to be shared with <PARTNER NAME> if your application is successful, for the purposes of account setup.

Event Timeline

Ankit18gupta subscribed.

Greetings!!
I am new here. So for the very first contribution I need some guidance. I want to work on this issue. Please help me get started.

Greetings!!
Could you please guide me to the target file where the changes are supposed to be made?

@Samwalton9 Is This issue solved ? if not can I work on this ?

Hi @ShailRT, @Ankit18gupta is working on this task. Perhaps you could work on T299883?

Hi @Samwalton9 , I have sent you a mail regarding this. Please check it. Actually I was stuck so mailed you and I was waiting for reply from you.

Hi @Samwalton9 , for this task do you want the line written just below the yellow alert? Also should the line come up as the same yellow alert?(image attached)

application.png (830×1 px, 102 KB)

Yes, I think the message being below the yellow alert makes sense. It shouldn't be in an alert, just normal text. It could be in italics, to make it clear it's an additional note.

This looks good!

It looks like the partner name isn't coming through, however. Where I wrote <PARTNER NAME> in my description, you should add the required text to import the resource name, which may require editing the view code.

I notice I linked the wrong view earlier, I think this is the correct one: https://github.com/WikipediaLibrary/TWLight/blob/master/TWLight/applications/views.py#L122

You may need to add additional context data to that view so that you can access the partner name: https://docs.djangoproject.com/en/3.2/topics/class-based-views/generic-display/#adding-extra-context

Hi @Samwalton9 , adding partner name is troubling me. How to access the partner name in views.py?

This looks good!

It looks like the partner name isn't coming through, however. Where I wrote <PARTNER NAME> in my description, you should add the required text to import the resource name, which may require editing the view code.

I notice I linked the wrong view earlier, I think this is the correct one: https://github.com/WikipediaLibrary/TWLight/blob/master/TWLight/applications/views.py#L122

You may need to add additional context data to that view so that you can access the partner name: https://docs.djangoproject.com/en/3.2/topics/class-based-views/generic-display/#adding-extra-context

How to access the partner name?

Hi @Ankit18gupta - No need to send multiple messages, I'll get back to you before too long :)

I think the approach might be to add get_context_data to SubmitSingleApplicationView per the explanation at https://docs.djangoproject.com/en/3.2/topics/class-based-views/generic-display/#adding-extra-context. You can get the partner the user is currently applying for in the view with partner = self._get_partners()[0]

Scardenasmolinar subscribed.

@Ankit18gupta, your PR has been reviewed! Let me know if you have any questions.