Maniphest T300446

Standardise type for timestamp columns in OAuth extension
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	Jan 29 2022, 9:49 PM

Tags

Referenced Files

None

Subscribers

Description

According to T42626 the timestamp should be adjust from varbinary(14) to binary(14) because there is no need to hold infinite.

Affected columns:

oauth_registered_consumer.oarc_email_authenticated
oauth_registered_consumer.oarc_registration
oauth_registered_consumer.oarc_stage_timestamp
oauth_accepted_consumer.oaac_accepted

Unaffected, because it has to hold infinite

oaat_expires.oauth2_access_tokens

Details

	Subject	Repo	Branch	Lines +/-
	Standardise type for timestamp columns	mediawiki/extensions/OAuth	master	+57 -4

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Ladsgroup	T191231 RFC: Abstract schemas and schema changes
		Open		None	T259374 Convert extensions to using abstract schema
		Resolved		None	T261912 Convert WMF Deployed Extensions to Abstract Schema
		Resolved		Umherirrender	T268565 Convert OAuth to AbstractSchema
		Resolved		Umherirrender	T300446 Standardise type for timestamp columns in OAuth extension

Event Timeline

Umherirrender created this task.Jan 29 2022, 9:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 29 2022, 9:49 PM

Reedy moved this task from Unsorted to Change on the Schema-change board.Jan 29 2022, 9:50 PM

Change 758066 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/OAuth@master] Standardise type for timestamp columns

https://gerrit.wikimedia.org/r/758066

gerritbot added a project: Patch-For-Review.Jan 29 2022, 9:52 PM

Umherirrender claimed this task.Jan 31 2022, 9:55 PM

Umherirrender triaged this task as Lowest priority.

Umherirrender added a parent task: T268565: Convert OAuth to AbstractSchema.Jun 12 2022, 8:56 PM

Change 758066 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] Standardise type for timestamp columns

https://gerrit.wikimedia.org/r/758066

Jdforrester-WMF closed this task as Resolved.Jul 13 2022, 5:49 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 13 2022, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 13 2022, 6:31 PM

Umherirrender mentioned this in T312977: Adjust the field type of oauth_accepted_consumer.oaac_accepted to fixed binary on wmf wikis.Jul 13 2022, 6:47 PM

Umherirrender mentioned this in T312978: Adjust the field type of oauth_registered_consumer timestamps to fixed binary on wmf wikis.