Page MenuHomePhabricator

Split out OAuth v1 and v2 forms
Closed, ResolvedPublic2 Estimated Story Points

Description

Currently, there is a lot of conditional logic in the OAuth extension formi when toggling between OAuth version 1 and version 2. In particular, a bug with the conditional hide/disable logic (T297888). As the logic may get more complex, we should simplify the code and split out the forms into 2 separate form pages.
Currently, the form is located at Special:OAuthConsumerRegistration/propose.
Instead, the v1 form could live at Special:OAuthConsumerRegistration/propose/v1 and v2 could live at Special:OAuthConsumerRegistration/propose/v2.

Event Timeline

This would also be useful for tailoring form presentation better to the protocol version (more specific documentation links, handle differences in vocabulary such as grant vs. scope).

When we look at this, let's make sure we consider T288981

DAbad set the point value for this task to 2.

Change 770607 had a related patch set uploaded (by TChin; author: TChin):

[mediawiki/extensions/OAuth@master] Split OAuth consumer registration form into two distinct forms for OAuth 1.0a and OAuth 2.0

https://gerrit.wikimedia.org/r/770607

DAbad subscribed.

team will take a look at this week

BPirkle added a subscriber: tchin.

Switching roles - chatted with Thomas outside Phab. I'll finish the coding work and Thomas will review.

Change 770607 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] Split OAuth consumer registration form into two distinct forms for OAuth 1.0a and OAuth 2.0

https://gerrit.wikimedia.org/r/770607