Page MenuHomePhabricator
Create Task
Maniphest T300962

Add regression tests for missing analytics parameters in SpecialHomepage
Closed, ResolvedPublic
Actions

Description

After merging https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/758458 in the context of T264460: Enable users to open the first suggested article directly from the mobile task preview links for task cards in the SuggestedEditsModule and PostEditPanel (small task card) didn't have a newcomer task token to be added to impressions data.

Our testing setup currently doesn't catch regressions where client-side or server-side code omits important analytics parameters from the newcomer task card. Let's add some tests to guard against regressions.

Details

SubjectRepoBranchLines +/-
SpecialHomepage: Check analytics parametersmediawiki/extensions/GrowthExperimentsmaster+174 -6
Post edit panel: add getCard testmediawiki/extensions/GrowthExperimentsmaster+100 -0
Add unit test for NewcomerTaskLoggermediawiki/extensions/GrowthExperimentsmaster+75 -0
Customize query in gerrit

Related Objects

Event Timeline

• kostajh created this task.Feb 4 2022, 11:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 4 2022, 11:00 AM
gerritbot added a comment.Feb 4 2022, 11:00 AM

Change 759685 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] SpecialHomepage: Check analytics parameters

https://gerrit.wikimedia.org/r/759685

gerritbot added a project: Patch-For-Review.Feb 4 2022, 11:00 AM
gerritbot added a comment.Feb 4 2022, 11:19 AM

Change 759682 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Post edit panel: add getCard test

https://gerrit.wikimedia.org/r/759682

Sgs claimed this task.Feb 4 2022, 11:41 AM
gerritbot added a comment.Feb 4 2022, 11:42 AM

Change 755443 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Add unit test for NewcomerTaskLogger

https://gerrit.wikimedia.org/r/755443

Sgs removed Sgs as the assignee of this task.Feb 4 2022, 12:06 PM
Sgs updated the task description. (Show Details)
Sgs subscribed.
gerritbot added a comment.Feb 4 2022, 12:43 PM

Change 755443 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add unit test for NewcomerTaskLogger

https://gerrit.wikimedia.org/r/755443

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.21; 2022-02-07).Feb 4 2022, 1:00 PM
gerritbot added a comment.Feb 7 2022, 11:16 AM

Change 759682 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Post edit panel: add getCard test

https://gerrit.wikimedia.org/r/759682

• kostajh changed the task status from Open to In Progress.Feb 7 2022, 11:25 AM
• kostajh claimed this task.
• kostajh moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
• kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 7 2022, 12:54 PM
Tgr changed the task status from In Progress to Open.Feb 10 2022, 2:51 AM
Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Feb 10 2022, 3:11 AM

Change 759685 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] SpecialHomepage: Check analytics parameters

https://gerrit.wikimedia.org/r/759685

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.22; 2022-02-14); removed MW-1.38-notes (1.38.0-wmf.21; 2022-02-07).Feb 10 2022, 4:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 10 2022, 4:10 AM
• kostajh triaged this task as Medium priority.Mar 2 2022, 1:57 PM
Etonkovidova closed this task as Resolved.Mar 2 2022, 11:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits