Page MenuHomePhabricator
Create Task
Maniphest T301061

Escaped HTML is displayed instead of a link in the Wikimedia Incubator Getting started wizard
Closed, ResolvedPublic
Actions

Description

This translation has issue in the user page link at https://incubator.wikimedia.org/wiki/Special:IncubatorFirstSteps. It displays:
"Please now create your userpage <a href="/wiki/User:Example" title="User:Example">Example</a> with some basic info about yourself. You can also see a link to it at the top of this page."
("Example" is an username) with an error. More details can be found at screenshot below.

Incubatorerror.PNG (593×1 px, 50 KB)

To reproduce yourself:

Observe: The step "Create your userpage" shows escaped HTML.

Message URL: https://translatewiki.net/w/i.php?title=Special:Translate&showMessage=wminc-fs-userpage-text&group=ext-wikimediaincubator

Details

SubjectRepoBranchLines +/-
Fix escaped HTML showing on Special:IncubatorFirstStepsmediawiki/extensions/WikimediaIncubatormaster+1 -1
Customize query in gerrit

Event Timeline

Nghiemtrongdai_VN created this task.Feb 6 2022, 8:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2022, 8:11 AM
Nghiemtrongdai_VN added a subscriber: MF-Warburg.Feb 6 2022, 8:23 AM
Reedy added a project: incubator.wikimedia.org.Feb 6 2022, 12:54 PM
Reedy removed a subscriber: incubator.wikimedia.org.
MarcoAurelio edited projects, added MediaWiki-extensions-WikimediaIncubator; removed incubator.wikimedia.org.EditedFeb 9 2022, 10:27 AM
MarcoAurelio subscribed.

Looks like it's not a message issue but a coding one.

$link = $linkRenderer->makeLink( $this->getUser()->getUserPage(), $this->getUser()->getName() );

Is missing the local server name apparently?

Would this work?

$link = $linkRenderer->makeLink( $this->getSourceURL()->getUserPage(), $this->getUser()->getName() );

Or use makeKnownLink instead of makeLink.

Amire80 renamed this task from [[MediaWiki:Wminc-fs-userpage-text/en]] translation issue to Escaped HTML is displayed instead of a link in the Wikimedia Incubator Getting started wizard.Feb 15 2022, 9:09 AM
Amire80 updated the task description. (Show Details)
jhsoby subscribed.Feb 15 2022, 11:43 AM
gerritbot added a comment.Feb 22 2022, 9:10 AM

Change 764721 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/WikimediaIncubator@master] Fix escaped HTML showing on Special:IncubatorFirstSteps

https://gerrit.wikimedia.org/r/764721

gerritbot added a project: Patch-For-Review.Feb 22 2022, 9:10 AM
jhsoby claimed this task.Feb 22 2022, 9:11 AM
jhsoby moved this task from Backlog to In progress on the MediaWiki-extensions-WikimediaIncubator board.Feb 22 2022, 10:45 AM
gerritbot added a comment.Feb 22 2022, 1:12 PM

Change 764721 merged by jenkins-bot:

[mediawiki/extensions/WikimediaIncubator@master] Fix escaped HTML showing on Special:IncubatorFirstSteps

https://gerrit.wikimedia.org/r/764721

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Feb 22 2022, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 22 2022, 2:10 PM
jhsoby closed this task as Resolved.Feb 22 2022, 2:34 PM

Marking as resolved; the change should appear on Incubator on Wednesday next week.

mxn subscribed.Mar 11 2022, 8:15 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL