Page MenuHomePhabricator

Show date headers on Special:Contributions page in Minerva skin
Closed, ResolvedPublic3 Estimated Story PointsFeature

Description

Feature summary (what you would like to be able to do and where):

In T300185 the mobile version of the Special:Contributions was replaced with the desktop version. This led to an unexpected interface change for many users. One of the unexpected interface changes was the loss of groupings.

In T298638 headers were added to the desktop contributions page to support grouping changes by date on the contributions page.
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Contributions/Jdlrobson

We should display headers in both views of this page. It would be beneficial for AMC users as well as users of the old version of the page.

The technical change that is required is very small.

Current viewProposed view afrer this change
Screen Shot 2022-02-15 at 8.31.07 AM.png (1×2 px, 365 KB)
Screen Shot 2022-02-15 at 8.35.40 AM.png (1×2 px, 359 KB)

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):

When going down the list of changes, I want to be able to see all the changes for a given day easily.

Benefits (why should this be implemented?):

  • Better visual scanning of changes
  • Easier to identify changes closer together as only need to parse the time mentally.

Acceptance criteria

On Minerva skin we should:

  • Show the date header (.mw-index-pager-list-header)
  • Style the header as we used to (using MobileFrontend styles for mobile history page)
  • Hide the date inside the change row itself (mw-changeslist-date)
  • Show the time (mw-changeslist-time)
  • Change should not impact desktop version of contributions page
  • Change should be scoped to contributions page. Change should not impact mobile version of history page.

QA

Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Contributions/Jdlrobson

Expected: Headers are present grouping edits by date

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Special:Contributions/Jdlrobson

Expected: Headers are not present grouping edits by date

Developer notes

See CSS in https://en.m.wikipedia.org/wiki/User:Jdlrobson/mobilecontribs.css

QA Results - Beta

ACStatusDetails
1T301798#7818324
2T301798#7818324

Event Timeline

Jdlrobson renamed this task from Show date headers on Special:Contributions page in Minervca to Show date headers on Special:Contributions page in Minerva skin.Feb 15 2022, 4:38 PM
Jdlrobson added a project: Web-Team-Backlog.
Jdlrobson updated the task description. (Show Details)

Also remove the extra date lines on desktop skins (not just hide them)

Change 772872 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Show the mw-index-pager-list-header

https://gerrit.wikimedia.org/r/772872

Change 772873 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Move mw-index-pager-list-header rule to changeslist

https://gerrit.wikimedia.org/r/772873

Change 772872 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Show the mw-index-pager-list-header

https://gerrit.wikimedia.org/r/772872

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: cjming.

Change 772873 merged by jenkins-bot:

[mediawiki/core@master] Move mw-index-pager-list-header rule to changeslist

https://gerrit.wikimedia.org/r/772873

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Contributions/Jdlrobson

✅ AC1: Expected: Headers are present grouping edits by date

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Special:Contributions/Jdlrobson

✅ AC2: Expected: Headers are not present grouping edits by date

Jdlrobson added a subscriber: Edtadros.

Change 775900 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Contributions headings should be border box

https://gerrit.wikimedia.org/r/775900

Change 775900 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Contributions headings should be border box

https://gerrit.wikimedia.org/r/775900

Contributions page and follow-up tasks now completed