Change 768708 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/IPInfo@master] IPInfo popup: Adjust content padding

https://gerrit.wikimedia.org/r/768708

@Prtksxna should the padding on this ticket be on the popup div or on properties inside... please see comments on this patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/IPInfo/+/768708/

Sorry, I didn't mean to suggest that we use only padding. Whatever is the best technical way to achieve this effective padding should be alright.

@Prtksxna Do we want to add extra space between the items, or is this task only to fix the space around the outside?

In T301939#7763973, @Tchanders wrote:

@Prtksxna Do we want to add extra space between the items, or is this task only to fix the space around the outside?

Yep, this task is only for the space between the content and the edge of the popup.

In T301939#7764058, @Prtksxna wrote:

In T301939#7763973, @Tchanders wrote:

@Prtksxna Do we want to add extra space between the items, or is this task only to fix the space around the outside?

Yep, this task is only for the space between the content and the edge of the popup.

So the space between content is what value? Padding 16px?

Or is padding 16px for the edge of the popup?

Sounds like we need two different pieces of information. Or is it padding 16px for the content + 16px for the edge of the popup?

In T301939#7765297, @AGueyte wrote:

In T301939#7764058, @Prtksxna wrote:

In T301939#7763973, @Tchanders wrote:

@Prtksxna Do we want to add extra space between the items, or is this task only to fix the space around the outside?

Yep, this task is only for the space between the content and the edge of the popup.

So the space between content is what value? Padding 16px?

Or is padding 16px for the edge of the popup?

Sounds like we need two different pieces of information. Or is it padding 16px for the content + 16px for the edge of the popup?

@AGueyte Since the task is just for the space between the content and the edge of the pop-up, we can assume that the space between the content shouldn't change.

In T301939#7766222, @Tchanders wrote:

In T301939#7765297, @AGueyte wrote:

In T301939#7764058, @Prtksxna wrote:

In T301939#7763973, @Tchanders wrote:

@Prtksxna Do we want to add extra space between the items, or is this task only to fix the space around the outside?

Yep, this task is only for the space between the content and the edge of the popup.

So the space between content is what value? Padding 16px?

Or is padding 16px for the edge of the popup?

Sounds like we need two different pieces of information. Or is it padding 16px for the content + 16px for the edge of the popup?

@AGueyte Since the task is just for the space between the content and the edge of the pop-up, we can assume that the space between the content shouldn't change.

Thank you!

Just padding 16px for the popup and not the inside content.

Change 768708 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] IPInfo popup: Adjust content padding

https://gerrit.wikimedia.org/r/768708

@Prtksxna There are some inconsistencies between how this looks on different skins. Do we want to make them all the same?

Vector (and MonoBook and Timeless) has a slightly bigger "effective" padding at the top and bottom (as shown in screenshot) of the popup:

This is because in the existing stylesheet the <dl> element has:

margin-top: 0.2em;
margin-bottom: 0.5em;

Minerva has a significantly bigger effective padding to the left:

This is because in the existing stylesheet the <dl> element has:

margin-left: 1em;

In T301939#7788226, @dom_walden wrote:

@Prtksxna There are some inconsistencies between how this looks on different skins. Do we want to make them all the same?

Thanks Dom! Yep, the effective padding should remain the same on both (all) skins.

In T301939#7791496, @Prtksxna wrote:

In T301939#7788226, @dom_walden wrote:

@Prtksxna There are some inconsistencies between how this looks on different skins. Do we want to make them all the same?

Thanks Dom! Yep, the effective padding should remain the same on both (all) skins.

Thanks. I am going to move this back into Ready as there is some more dev work to be done.

Change 772396 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/IPInfo@master] Ensure the space around the content in the popup is consistent

https://gerrit.wikimedia.org/r/772396

Change 772396 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Ensure the space around the content in the popup is consistent

https://gerrit.wikimedia.org/r/772396

Here is how the popup looks in different skins:

Vector 2022	Vector 2010	Minerva	Monobook	Timeless

They all have 16px of padding between the content and the border of the popup.

I cannot see any differences between Vectors, Minerva and Monobook (other than possibly the latter two have smaller fonts by default?)

On Timeless, you will notice the gap between the different content inside the popup is bigger than 16px (and therefore the popup is taller). This is because the <dd> element has a larger margin-bottom. @Prtksxna If this is a problem I can raise a separate bug.

A taller popup on Timeless is alright. Thank you for sharing the screenshots @dom_walden!