Page MenuHomePhabricator
Create Task
Maniphest T302000

Fix messages for Special:Log/ipinfo log lines
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Special:Log shows some log lines relating to users accessing sensitive data via IPInfo.

This task is spun out from T295017#7683855 and T292842#7713520 to decide what the log lines should say, and to implement this.

EventLog line
User enables IP Info access$timestamp User:A enabled their own access to IP Info
User disables IP Info access$timestamp User:A disabled their own access to IP Info
User accesses popup$timestamp User:A viewed IP Information popup for 1.1.1.1. Limited/Full access.
User accesses infobox$timestamp User:A viewed IP Information infobox for 1.1.1.1. Limited/Full access.

Details

SubjectRepoBranchLines +/-
Update ipinfo log line copymediawiki/extensions/IPInfomaster+21 -17
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Feb 17 2022, 4:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 17 2022, 4:17 PM
Tchanders mentioned this in T292842: Log when the user's access level changes.Feb 17 2022, 4:18 PM
Tchanders mentioned this in T295017: Display ipinfo log lines on Special:Log.Feb 17 2022, 4:20 PM
Tchanders added subscribers: Niharika, • Prtksxna, STran.Feb 17 2022, 4:34 PM

@Niharika @Prtksxna I created this task because I wondered if it might be easier to define the copy for all of these lines at once?

Niharika triaged this task as Medium priority.Feb 18 2022, 11:21 PM
Niharika updated the task description. (Show Details)

@Tchanders does the task description correctly capture the events we need to review log lines for and their respective current copies? I pulled this in from the tasks you linked to.

ARamirez_WMF moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Feb 22 2022, 6:40 PM
ARamirez_WMF set the point value for this task to 2.Feb 22 2022, 6:47 PM
ARamirez_WMF moved this task from Triage/To be Estimated to AHaT Sprint 2: The Pork Pie on the Anti-Harassment board.
ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 2: The Pork Pie); removed Anti-Harassment.
Niharika added a comment.Feb 22 2022, 6:48 PM

@Prtksxna need your thoughts on this task please.

ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Needs Design/Product 🎨 on the Anti-Harassment (AHaT Sprint 2: The Pork Pie) board.Feb 22 2022, 6:48 PM
Niharika moved this task from Needs Design/Product 🎨 to Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) on the Anti-Harassment (AHaT Sprint 2: The Pork Pie) board.Feb 23 2022, 5:41 AM

@Prtksxna said the messages look okay to him so this task is unblocked and ready to go.

STran claimed this task.Feb 23 2022, 2:20 PM
STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 2: The Pork Pie) board.
gerritbot added a comment.Feb 23 2022, 2:49 PM

Change 765278 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/IPInfo@master] Update ipinfo log line copy

https://gerrit.wikimedia.org/r/765278

gerritbot added a project: Patch-For-Review.Feb 23 2022, 2:49 PM
STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 2: The Pork Pie) board.Feb 23 2022, 2:54 PM
gerritbot added a comment.Feb 25 2022, 7:18 PM

Change 765278 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Update ipinfo log line copy

https://gerrit.wikimedia.org/r/765278

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Feb 25 2022, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 25 2022, 8:10 PM
Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 2: The Pork Pie) board.Feb 28 2022, 12:41 PM
• imaigwilo subscribed.EditedMar 2 2022, 3:16 PM

Screen Shot 2022-03-02 at 10.00.39 AM.png (1×2 px, 446 KB)

@STran
I performed the disabled, and enable event of my IP info rights(Admin user) and I did not see that log line: $timestamp User:A enabled their own access to IP Info

• imaigwilo added a comment.Mar 2 2022, 4:33 PM

@STran
Never mind, it miraculously started working now, after I did git pull on my local box again today. See attached screen shot.

Screen Shot 2022-03-02 at 11.29.17 AM.png (1×2 px, 480 KB)

• imaigwilo moved this task from QA/Testing 🐞 to Done Q3 2022 on the Anti-Harassment (AHaT Sprint 2: The Pork Pie) board.Mar 2 2022, 4:34 PM
ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 3: Lady Dimitrescu); removed Anti-Harassment (AHaT Sprint 2: The Pork Pie).Mar 7 2022, 7:35 PM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Done Q3 2022 on the Anti-Harassment (AHaT Sprint 3: Lady Dimitrescu) board.Mar 7 2022, 7:39 PM
ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 2: The Pork Pie); removed Anti-Harassment (AHaT Sprint 3: Lady Dimitrescu).Mar 7 2022, 8:05 PM
Niharika closed this task as Resolved.Mar 8 2022, 12:29 AM
Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits