Page MenuHomePhabricator

Fix messages for Special:Log/ipinfo log lines
Closed, ResolvedPublic2 Estimated Story Points

Description

Special:Log shows some log lines relating to users accessing sensitive data via IPInfo.

This task is spun out from T295017#7683855 and T292842#7713520 to decide what the log lines should say, and to implement this.

EventLog line
User enables IP Info access$timestamp User:A enabled their own access to IP Info
User disables IP Info access$timestamp User:A disabled their own access to IP Info
User accesses popup$timestamp User:A viewed IP Information popup for 1.1.1.1. Limited/Full access.
User accesses infobox$timestamp User:A viewed IP Information infobox for 1.1.1.1. Limited/Full access.

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptFeb 17 2022, 4:17 PM

@Niharika @Prtksxna I created this task because I wondered if it might be easier to define the copy for all of these lines at once?

Niharika triaged this task as Medium priority.Feb 18 2022, 11:21 PM
Niharika updated the task description. (Show Details)

@Tchanders does the task description correctly capture the events we need to review log lines for and their respective current copies? I pulled this in from the tasks you linked to.

@Prtksxna need your thoughts on this task please.

Change 765278 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/IPInfo@master] Update ipinfo log line copy

https://gerrit.wikimedia.org/r/765278

Change 765278 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Update ipinfo log line copy

https://gerrit.wikimedia.org/r/765278

Screen Shot 2022-03-02 at 10.00.39 AM.png (1ร—2 px, 446 KB)

@STran
I performed the disabled, and enable event of my IP info rights(Admin user) and I did not see that log line: $timestamp User:A enabled their own access to IP Info

@STran
Never mind, it miraculously started working now, after I did git pull on my local box again today. See attached screen shot.

Screen Shot 2022-03-02 at 11.29.17 AM.png (1ร—2 px, 480 KB)