Page MenuHomePhabricator
Create Task
Maniphest T302096

Escape key instantly closes VE and discards changes with no confirmation
Closed, ResolvedPublic
Actions

Description

In T52868#7720620, @Alex42 wrote:

This feature worked as expected until now. The last time i remember it working correctly is a few month ago.

But now it is broken and no dialog "Are you sure?" is shown any more, when pressing Esc key once. Yesterday i lost a hour of work.

Tested in main view of VisualEditor on fr-, de- and en-wiki with Firefox 97.0 (64-Bit) on Win10.

See also this disussion: en-wiki:User_talk:Nick_Moyes#ESC_key_in_VisualEditor

Details

SubjectRepoBranchLines +/-
Don't suppress teardown prompt when pressing escapemediawiki/extensions/VisualEditorwmf/1.38.0-wmf.22+2 -2
Don't suppress teardown prompt when pressing escapemediawiki/extensions/VisualEditormaster+2 -2
Only teardown with no prompt on escape while loadingmediawiki/extensions/VisualEditormaster+3 -1
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Feb 18 2022, 5:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 18 2022, 5:53 PM
matmarex mentioned this in T52868: Escape key inside the main editor should cancel VE mode and return to action=view.Feb 18 2022, 5:53 PM
matmarex added a subscriber: Esanders.Feb 18 2022, 5:56 PM

This may be a bug in recent refactoring we've done while working on the editing loading transitions (T299907), maybe rEVEDfb8815f6583d: Fix some behaviour when user aborts VE loading with escape?

ppelberg triaged this task as High priority.Feb 18 2022, 5:57 PM
ppelberg added a project: Editing-team (Kanban Board).
ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.
gerritbot added a comment.Feb 18 2022, 6:13 PM

Change 763799 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Only teardown with no prompt on escape while loading

https://gerrit.wikimedia.org/r/763799

gerritbot added a project: Patch-For-Review.Feb 18 2022, 6:13 PM

Change 763800 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Don't suppress teardown prompt when pressing escape

https://gerrit.wikimedia.org/r/763800

gerritbot added a comment.Feb 18 2022, 6:24 PM

Change 763799 abandoned by DLynch:

[mediawiki/extensions/VisualEditor@master] Only teardown with no prompt on escape while loading

Reason:

I60fcddee7bf0dfb3a39e92d26898da2963861c19 is simpler

https://gerrit.wikimedia.org/r/763799

gerritbot added a comment.Feb 18 2022, 9:44 PM

Change 763800 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Don't suppress teardown prompt when pressing escape

https://gerrit.wikimedia.org/r/763800

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.23; 2022-02-21).Feb 18 2022, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 18 2022, 10:10 PM
matmarex moved this task from Ready to Be Worked On to Doing on the Editing-team (Kanban Board) board.Feb 19 2022, 9:43 PM

We'll deploy the fix to all Wikimedia wikis on Monday. Sorry about the issue.

matmarex moved this task from To Triage to Triaged on the VisualEditor board.Feb 19 2022, 9:43 PM
MarMi_wiki subscribed.Feb 20 2022, 4:56 PM
matmarex added a comment.Feb 21 2022, 7:47 AM

Actually, we can't deploy today, because it's a holiday in the US and so non-emergency deployments are not allowed. Tuesday then, I guess…

gerritbot added a comment.Feb 21 2022, 8:37 PM

Change 764396 had a related patch set uploaded (by Bartosz Dziewoński; author: Esanders):

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.22] Don't suppress teardown prompt when pressing escape

https://gerrit.wikimedia.org/r/764396

gerritbot added a project: Patch-For-Review.Feb 21 2022, 8:37 PM
ppelberg subscribed.Feb 21 2022, 10:47 PM
In T302096#7724770, @matmarex wrote:

Actually, we can't deploy today, because it's a holiday in the US and so non-emergency deployments are not allowed. Tuesday then, I guess…

Noted.

gerritbot added a comment.Feb 22 2022, 8:16 AM

Change 764396 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.38.0-wmf.22] Don't suppress teardown prompt when pressing escape

https://gerrit.wikimedia.org/r/764396

Stashbot added a comment.Feb 22 2022, 8:20 AM

Mentioned in SAL (#wikimedia-operations) [2022-02-22T08:20:52Z] <taavi@deploy1002> Synchronized php-1.38.0-wmf.22/extensions/VisualEditor/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js: Backport: Revert: [[gerrit:764396|Don't suppress teardown prompt when pressing escape (T302096)]] (duration: 00m 49s)

matmarex moved this task from Doing to QA on the Editing-team (Kanban Board) board.Feb 22 2022, 8:43 AM
matmarex edited projects, added Editing QA; removed Patch-For-Review.

Fix deployed on all wikis.

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.22; 2022-02-14); removed MW-1.38-notes (1.38.0-wmf.23; 2022-02-21).Feb 22 2022, 9:00 AM
Alex42 added a comment.Feb 22 2022, 11:46 AM

Thanks for the fast bug fix.

EAkinloose subscribed.Feb 28 2022, 9:18 PM

I'll go ahead to verify this. Escape key triggers the confirmation dialog as expected if the key is pressed after one or more edits.

EAkinloose edited projects, added Verified; removed Editing QA.Feb 28 2022, 9:19 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
ppelberg closed this task as Resolved.Mar 18 2022, 2:02 AM
ppelberg claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL