Page MenuHomePhabricator

Date headings on Special:Contributions don't work well for Flow edits
Closed, ResolvedPublic

Assigned To
Authored By
matmarex
Feb 22 2022, 8:25 PM
Referenced Files
F34962814: image.png
Feb 23 2022, 8:46 AM
F34962816: image.png
Feb 23 2022, 8:46 AM
F34962259: image.png
Feb 22 2022, 8:25 PM
F34962257: image.png
Feb 22 2022, 8:25 PM

Description

Date headings on Special:Contributions (added in T298638) don't work well for Flow edits.

Steps to reproduce:

  1. Visit https://www.mediawiki.org/wiki/Special:Contributions/Matma_Rex
    1. The first few edits on the list have different bullet points, apparently because they're not wrapped in <ul>…</ul>:
      image.png (2×3 px, 648 KB)
  2. Run the following to display the hidden headings: mw.util.addCSS( '.mw-index-pager-list-header { display: block !important; }' );
    1. There are no headings above Flow edits:
      image.png (2×3 px, 505 KB)

Event Timeline

Change 764893 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] [WIP] ReverseChronologicalPager: Fix displaying headings for things that are not revisions

https://gerrit.wikimedia.org/r/764893

Change 764893 merged by jenkins-bot:

[mediawiki/core@master] ReverseChronologicalPager: Fix displaying date headers for non-revisions

https://gerrit.wikimedia.org/r/764893

Change 764841 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@wmf/1.38.0-wmf.23] ReverseChronologicalPager: Fix displaying date headers for non-revisions

https://gerrit.wikimedia.org/r/764841

Change 764841 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.23] ReverseChronologicalPager: Fix displaying date headers for non-revisions

https://gerrit.wikimedia.org/r/764841

Mentioned in SAL (#wikimedia-operations) [2022-02-23T08:29:40Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.23/includes/actions/pagers/HistoryPager.php: rMW38f33d34817b: ReverseChronologicalPager: Fix displaying date headers for non-revisions (T302343; 1/5) (duration: 00m 49s)

Mentioned in SAL (#wikimedia-operations) [2022-02-23T08:30:29Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.23/includes/specials/pagers/ContribsPager.php: rMW38f33d34817b: ReverseChronologicalPager: Fix displaying date headers for non-revisions (T302343; 2/5) (duration: 00m 49s)

Mentioned in SAL (#wikimedia-operations) [2022-02-23T08:31:19Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.23/includes/specials/pagers/MergeHistoryPager.php: rMW38f33d34817b: ReverseChronologicalPager: Fix displaying date headers for non-revisions (T302343; 3/5) (duration: 00m 49s)

Mentioned in SAL (#wikimedia-operations) [2022-02-23T08:32:13Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.23/includes/pager/ReverseChronologicalPager.php: rMW38f33d34817b: ReverseChronologicalPager: Fix displaying date headers for non-revisions (T302343; 4/5) (duration: 00m 53s)

Mentioned in SAL (#wikimedia-operations) [2022-02-23T08:33:02Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.23/includes/pager/IndexPager.php: rMW38f33d34817b: ReverseChronologicalPager: Fix displaying date headers for non-revisions (T302343; 5/5) (duration: 00m 48s)