Page MenuHomePhabricator
Create Task
Maniphest T302343

Date headings on Special:Contributions don't work well for Flow edits
Closed, ResolvedPublic
Actions

Assigned To
matmarex
Authored By
matmarex
Feb 22 2022, 8:25 PM
Tags
Referenced Files
F34962814: image.png
Feb 23 2022, 8:46 AM
F34962816: image.png
Feb 23 2022, 8:46 AM
F34962259: image.png
Feb 22 2022, 8:25 PM
F34962257: image.png
Feb 22 2022, 8:25 PM
Subscribers
Aklapper
Jdlrobson
matmarex

Description

Date headings on Special:Contributions (added in T298638) don't work well for Flow edits.

Steps to reproduce:

  1. Visit https://www.mediawiki.org/wiki/Special:Contributions/Matma_Rex
    1. The first few edits on the list have different bullet points, apparently because they're not wrapped in <ul>…</ul>:
      image.png (2×3 px, 648 KB)
  2. Run the following to display the hidden headings: mw.util.addCSS( '.mw-index-pager-list-header { display: block !important; }' );
    1. There are no headings above Flow edits:
      image.png (2×3 px, 505 KB)

Details

SubjectRepoBranchLines +/-
ReverseChronologicalPager: Fix displaying date headers for non-revisionsmediawiki/corewmf/1.38.0-wmf.23+18 -2
ReverseChronologicalPager: Fix displaying date headers for non-revisionsmediawiki/coremaster+18 -2
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Feb 22 2022, 8:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 22 2022, 8:25 PM
matmarex claimed this task.Feb 22 2022, 8:25 PM
gerritbot added a comment.Feb 22 2022, 8:54 PM

Change 764893 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] [WIP] ReverseChronologicalPager: Fix displaying headings for things that are not revisions

https://gerrit.wikimedia.org/r/764893

gerritbot added a project: Patch-For-Review.Feb 22 2022, 8:54 PM
matmarex mentioned this in T300199: 1.38.0-wmf.23 deployment blockers.Feb 22 2022, 9:55 PM
gerritbot added a comment.Feb 22 2022, 11:18 PM

Change 764893 merged by jenkins-bot:

[mediawiki/core@master] ReverseChronologicalPager: Fix displaying date headers for non-revisions

https://gerrit.wikimedia.org/r/764893

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Feb 23 2022, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 23 2022, 12:10 AM
gerritbot added a comment.Feb 23 2022, 7:49 AM

Change 764841 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@wmf/1.38.0-wmf.23] ReverseChronologicalPager: Fix displaying date headers for non-revisions

https://gerrit.wikimedia.org/r/764841

gerritbot added a project: Patch-For-Review.Feb 23 2022, 7:49 AM
gerritbot added a comment.Feb 23 2022, 8:17 AM

Change 764841 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.23] ReverseChronologicalPager: Fix displaying date headers for non-revisions

https://gerrit.wikimedia.org/r/764841

Stashbot added a comment.Feb 23 2022, 8:29 AM

Mentioned in SAL (#wikimedia-operations) [2022-02-23T08:29:40Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.23/includes/actions/pagers/HistoryPager.php: rMW38f33d34817b: ReverseChronologicalPager: Fix displaying date headers for non-revisions (T302343; 1/5) (duration: 00m 49s)

Stashbot added a comment.Feb 23 2022, 8:30 AM

Mentioned in SAL (#wikimedia-operations) [2022-02-23T08:30:29Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.23/includes/specials/pagers/ContribsPager.php: rMW38f33d34817b: ReverseChronologicalPager: Fix displaying date headers for non-revisions (T302343; 2/5) (duration: 00m 49s)

Stashbot added a comment.Feb 23 2022, 8:31 AM

Mentioned in SAL (#wikimedia-operations) [2022-02-23T08:31:19Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.23/includes/specials/pagers/MergeHistoryPager.php: rMW38f33d34817b: ReverseChronologicalPager: Fix displaying date headers for non-revisions (T302343; 3/5) (duration: 00m 49s)

Stashbot added a comment.Feb 23 2022, 8:32 AM

Mentioned in SAL (#wikimedia-operations) [2022-02-23T08:32:13Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.23/includes/pager/ReverseChronologicalPager.php: rMW38f33d34817b: ReverseChronologicalPager: Fix displaying date headers for non-revisions (T302343; 4/5) (duration: 00m 53s)

Stashbot added a comment.Feb 23 2022, 8:33 AM

Mentioned in SAL (#wikimedia-operations) [2022-02-23T08:33:02Z] <urbanecm@deploy1002> Synchronized php-1.38.0-wmf.23/includes/pager/IndexPager.php: rMW38f33d34817b: ReverseChronologicalPager: Fix displaying date headers for non-revisions (T302343; 5/5) (duration: 00m 48s)

matmarex closed this task as Resolved.Feb 23 2022, 8:46 AM

After the fix: https://www.mediawiki.org/wiki/Special:Contributions/Matma_Rex

BeforeAfter
image.png (2×3 px, 648 KB)
image.png (2×3 px, 584 KB)
image.png (2×3 px, 505 KB)
image.png (2×3 px, 407 KB)
ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.23; 2022-02-21); removed MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Feb 23 2022, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 23 2022, 9:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits