Page MenuHomePhabricator
Create Task
Maniphest T302956

Tab uses "change protection settings for this page" even when the page isn't protected
Closed, ResolvedPublic
Actions

Description

The protection tab label is now always "change protection settings for this page", even if the page isn't protected. Previously the label would be "protect" if the page was not protected, and then "change protection settings for this page". I think this is a regressoin from 4776bed220a0c03647131804af26b53f6f7accdc / T301203: Update skin-specific menu labels to be more predictable, intuitive with better default values.

Screenshot 2022-03-02 at 23-13-23 Change protection settings for User Legoktm - MediaWiki.png (1×2 px, 245 KB)

The longer text both takes up a bunch of space as well as making it harder for admins to quickly at a glance see if a page is already protected.

Related Objects

Event Timeline

Legoktm created this task.Mar 3 2022, 7:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2022, 7:14 AM
Legoktm added a parent task: T300200: 1.38.0-wmf.24 deployment blockers.Mar 3 2022, 7:14 AM
Ammarpad edited projects, added MonoBook, Modern, CologneBlue; removed MediaWiki-Page-protection, MediaWiki-User-Interface (actions).Mar 3 2022, 8:13 AM
Ammarpad subscribed.

I don't think this should block the train, per the resolution of T300169. This only affects non-default skins.

Ammarpad added a comment.EditedMar 3 2022, 8:27 AM

It can be temporarily fixed by creating the messages
https://www.mediawiki.org/wiki/MediaWiki:{skinname}-action-protect

Wargo subscribed.Mar 3 2022, 11:54 AM

And on monobook all the tabs (now on mediawiki.org)

brennen added subscribers: Jdlrobson, brennen.Mar 3 2022, 5:21 PM

@Jdlrobson - thoughts here?

Jdlrobson removed a parent task: T300200: 1.38.0-wmf.24 deployment blockers.Mar 3 2022, 6:30 PM
Jdlrobson closed this task as Resolved.Mar 3 2022, 6:38 PM
Jdlrobson claimed this task.

We don't block the train for non-default skins and this is not a "Major stylistic problems affecting all pages" [1]

We're in the process of updating all the defaults for these messages, and this problematic message has been updated for next week's train which will fix Modern, CologneBlue, Modern and Vector 2022.

[1] https://wikitech.wikimedia.org/wiki/Deployments/Holding_the_train#Issues_that_hold_the_train

Jdlrobson mentioned this in T301203: Update skin-specific menu labels to be more predictable, intuitive with better default values.Mar 3 2022, 9:14 PM
GereonK subscribed.Mar 3 2022, 9:23 PM

Half my pull down menues are in very bad German now. This has to be changed back to the correct version at once. It is not accetable that this glitch now stays for hours.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits