Page MenuHomePhabricator
Create Task
Maniphest T302961

Use API endpoint when creating a new Lexeme
Closed, ResolvedPublic
Actions

Description

We decided we want the vue app to create Lexemes via a POST request with mw.api to the action API.

Acceptance criteria:

  • the new Lexeme is created without the page being reloaded
  • it uses mw.api that is injected into the app

Open questions:

  • what tags should we add now? – same as the current special page
  • does this also include redirecting to a newly created Lexeme? – no

Notes:

  • This does not yet include error handling, it is fine to log them into the console for now

Details

SubjectRepoBranchLines +/-
Pass tags into NewLexemeAlphamediawiki/extensions/WikibaseLexememaster+8 -6
Stop passing token into NewLexemeAlphamediawiki/extensions/WikibaseLexememaster+9 -12
Set up init() as the new app entrypointmediawiki/extensions/WikibaseLexememaster+10 -19
Customize query in gerrit

Related Objects
Search...

Event Timeline

Michael created this task.Mar 3 2022, 9:43 AM
karapayneWMDE moved this task from Special:NewLexeme revival - sprint 2 to Special:NewLexeme revival - sprint 3 on the Special:NewLexeme revival board.Mar 9 2022, 1:49 PM
karapayneWMDE edited projects, added Special:NewLexeme revival (Special:NewLexeme revival - sprint 3); removed Special:NewLexeme revival (Special:NewLexeme revival - sprint 2).
noarave added subscribers: Lydia_Pintscher, noarave.Mar 10 2022, 9:40 AM

Task Breakdown Note:
We decided not to open a dedicated task for injecting mw.api into the app, the corresponding acceptance criteria in this task should do.
mw.api should be used as discussed in the meeting notes.

  • we need input from @Lydia_Pintscher regarding which tags to use in the new lexeme page.
  • in order to keep this task focused we decided against including redirecting to newly created lexemes as part of this task.
gerritbot added a comment.Mar 10 2022, 2:14 PM

Change 769702 had a related patch set uploaded (by Noa wmde; author: Noa wmde):

[mediawiki/extensions/WikibaseLexeme@master] Set up init() as the new app entrypoint

https://gerrit.wikimedia.org/r/769702

gerritbot added a project: Patch-For-Review.Mar 10 2022, 2:14 PM
Lydia_Pintscher added a comment.Mar 10 2022, 3:34 PM
In T302961#7766524, @noarave wrote:
  • we need input from @Lydia_Pintscher regarding which tags to use in the new lexeme page.

We want to continue with the same tag that the current page uses: Wikidata User Interface (example)

gerritbot added a comment.Mar 10 2022, 4:21 PM

Change 769702 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Set up init() as the new app entrypoint

https://gerrit.wikimedia.org/r/769702

Maintenance_bot removed a project: Patch-For-Review.Mar 10 2022, 5:10 PM
noarave moved this task from To Do to Doing on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 3) board.Mar 11 2022, 9:16 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Mar 15 2022, 2:38 PM
noarave moved this task from Doing to Peer Review on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 3) board.Mar 16 2022, 1:26 PM
gerritbot added a comment.Mar 16 2022, 3:50 PM

Change 771371 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Pass tags into NewLexemeAlpha

https://gerrit.wikimedia.org/r/771371

gerritbot added a project: Patch-For-Review.Mar 16 2022, 3:50 PM
gerritbot added a comment.Mar 16 2022, 4:46 PM

Change 771380 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Stop passing token into NewLexemeAlpha

https://gerrit.wikimedia.org/r/771380

Lucas_Werkmeister_WMDE mentioned this in T298153: ‘Submit’ Button functionality to create the new Lexeme.Mar 17 2022, 11:40 AM
gerritbot added a comment.Mar 18 2022, 8:33 AM

Change 771380 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Stop passing token into NewLexemeAlpha

https://gerrit.wikimedia.org/r/771380

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.1; 2022-03-21-early).Mar 18 2022, 9:00 AM
gerritbot added a comment.Mar 18 2022, 10:03 AM

Change 771371 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Pass tags into NewLexemeAlpha

https://gerrit.wikimedia.org/r/771371

noarave added a comment.Mar 18 2022, 10:08 AM

Adding the merged PR for documentation purposes: https://github.com/wmde/new-lexeme-special-page/pull/84

Lucas_Werkmeister_WMDE closed this task as Resolved.Mar 18 2022, 3:30 PM
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 3) board.
Lucas_Werkmeister_WMDE subscribed.

I think this is done (but see T298153#7785202).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits