‘Submit’ Button functionality to create the new Lexeme
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

As a user, when I finish filling out the new Lexeme form I would like to create a new lexeme by clicking on the ‘Create Lexeme’ button in order to save my contribution.

Problem:
We need to let editors submit the data for the new Lexeme that is supposed to be created and then create the Lexeme.

Screenshots/mockups:
https://www.figma.com/file/XoYktoKEBnC0VIf1SRuxJK/Lexicographical-Data-UI?node-id=493%3A3179

BDD
GIVEN the special page to create new Lexemes
AND the input fields are filled out
WHEN clicking “Submit”
THEN the input is validated
AND the new Lexeme created if validation was successful

Acceptance criteria:

input is validated
Lexeme is created if input is valid

Notes:

Button Copy: Create Lexeme
Wikit component Button: progressive
Errors (pre submit): no entities selected in the entity selectors, invalid input in the entity selectors, Lemma field is empty, spelling variant is invalid, Lemma is too long
validation should be included in serverside, improved validation (if desired) should be in a new task

error post submit (permission errors) to be handled here: T302264 design / T303393 implementation
error "spelling variant is invalid" added to spelling variant field creation task: T298145

Details

	Subject	Repo	Branch	Lines +/-
	Add missing Special:NewLexemeAlpha i18n messages	mediawiki/extensions/WikibaseLexeme	master	+6 -0
	Let Special:NewLexemeAlpha create lexemes	mediawiki/extensions/WikibaseLexeme	master	+560 -12

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Lydia_Pintscher	T298134 Input of data about the new Lexeme
Resolved	Lucas_Werkmeister_WMDE	T298153 ‘Submit’ Button functionality to create the new Lexeme
Resolved	Lucas_Werkmeister_WMDE	T302001 Add CSRF token to new lexeme form
Invalid	None	T302070 Ensure proper validation for the submitted data
Resolved	Lucas_Werkmeister_WMDE	T302961 Use API endpoint when creating a new Lexeme

Event Timeline

Lydia_Pintscher created this task.Dec 21 2021, 8:39 PM

Lydia_Pintscher moved this task from Backlog to milestone 1 on the Special:NewLexeme revival board.

Lydia_Pintscher added a project: Wikidata Lexicographical data.Dec 21 2021, 8:49 PM

Lydia_Pintscher triaged this task as Medium priority.Dec 21 2021, 8:54 PM

Lydia_Pintscher moved this task from incoming to features/bugs for next release (Special:NewLexeme) on the Wikidata Lexicographical data board.

Maintenance_bot added a project: Wikidata.Dec 21 2021, 9:47 PM

So9q subscribed.Feb 8 2022, 8:03 AM

karapayneWMDE mentioned this in T301234: Create basic form with text inputs.Feb 8 2022, 11:35 AM

karapayneWMDE renamed this task from ‘Submit’ Button to create the new Lexeme to ‘Submit’ Button functionality to create the new Lexeme.Feb 8 2022, 12:09 PM

karapayneWMDE updated the task description. (Show Details)

karapayneWMDE set the point value for this task to 8.

guergana.tzatchkova moved this task from milestone 1 to Special:NewLexeme revival - sprint 1 on the Special:NewLexeme revival board.Feb 17 2022, 10:53 AM

guergana.tzatchkova edited projects, added Special:NewLexeme revival (Special:NewLexeme revival - sprint 1); removed Special:NewLexeme revival.

Lucas_Werkmeister_WMDE mentioned this in rNLSP12cdab4674ef: POC: Submit to Special:NewLexeme.Feb 17 2022, 4:12 PM

Proof of concept: https://github.com/wmde/new-lexeme-special-page/pull/50

Change 763719 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/WikibaseLexeme@master] Allow no lexeme input handling by adding noscript skeleton form

https://gerrit.wikimedia.org/r/763719

gerritbot added a project: Patch-For-Review.Feb 18 2022, 12:22 PM

Lucas_Werkmeister_WMDE mentioned this in rNLSP1c0b97b3d32d: Add lemma language input and submit form.Feb 21 2022, 5:23 PM

karapayneWMDE moved this task from Special:NewLexeme revival - sprint 1 to Special:NewLexeme revival - sprint 2 on the Special:NewLexeme revival board.Feb 22 2022, 10:09 AM

karapayneWMDE edited projects, added Special:NewLexeme revival (Special:NewLexeme revival - sprint 2); removed Special:NewLexeme revival (Special:NewLexeme revival - sprint 1).

karapayneWMDE moved this task from To Do to Parents / Waiting on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 2) board.

Lucas_Werkmeister_WMDE closed subtask T302001: Add CSRF token to new lexeme form as Resolved.Feb 22 2022, 10:10 AM

karapayneWMDE updated the task description. (Show Details)Feb 22 2022, 10:43 AM

https://github.com/wmde/new-lexeme-special-page/pull/55

Task Breakdown Notes:

What was done:

CSRF Token Injection into Vue App (merged)
Provide CSRF token from the WikibaseLexeme.git PATCH
<noscript> version of form, with the required fields PATCH Note for future: T302070
Action handler on Server side: re-renders form (with error messages that might be displayed with JS disabled) PATCH
Make vue form submittable in a way that is compatible with server side form action handling. PATCH

What's left to do

With a minimal version (without validation messages), the only thing left to do is to review.

With validation messages, we can already handle field errors on the client side:

Define validation logic for each of the following errors:
- Required fields (all)
- Invalid ItemId format (regex for now ⇒ language, lexical category)
- Max length for lemma (Involves resolving a long-standing to-do in the current Lexeme data model: 1000 chars. @Lydia_Pintscher is this correct? The current value is hard-coded)

Display messages (as shown in Figma) below invalid fields. @Erdinc_Ciftci_WMDE @Lydia_Pintscher Do we have the copy for all of these messages?

Open Questions: should we send the form via the browser with the traditional form action, or should we submit it with an XHR?

@Lydia_Pintscher @karapayneWMDE There is an open question regarding the scope of this task. Should it also include error signaling or not? Validation (on the server side - is already done, in the way that it prevents Lexeme creation rather than signaling errors). Can you please shed some light on this? Do we expect errors to be displayed to the user as part of this task?

ItamarWMDE added a subscriber: Erdinc_Ciftci_WMDE.Feb 23 2022, 10:40 AM

ItamarWMDE closed subtask T302070: Ensure proper validation for the submitted data as Invalid.Feb 23 2022, 10:47 AM

ItamarWMDE mentioned this in T302070: Ensure proper validation for the submitted data.

@ItamarWMDE you mean telling the editor what the specific error is that prevented the creation of the Lexeme? I initially included it here but let's leave it out of this ticket now and create a new one once T302264 is done.

Yes, I mean displaying messages to the user. But I agree on the scope reduction. We can look at the newly created ticket in the backlog grooming.

Lucas_Werkmeister_WMDE mentioned this in rNLSP29836f2ab9a3: Add lemma language input and submit form.Feb 28 2022, 5:53 PM

Urbanecm reopened subtask T302001: Add CSRF token to new lexeme form as Open.Mar 1 2022, 8:35 AM

Lucas_Werkmeister_WMDE closed subtask T302001: Add CSRF token to new lexeme form as Resolved.Mar 1 2022, 2:06 PM

Change 763719 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Let Special:NewLexemeAlpha create lexemes

https://gerrit.wikimedia.org/r/763719

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.25; 2022-03-07).Mar 2 2022, 1:00 PM

Works on beta, see https://wikidata.beta.wmflabs.org/wiki/Special:NewLexemeAlpha. (Though we forgot to include the i18n messages in the ResourceLoader module.) https://wikidata.beta.wmflabs.org/wiki/Lexeme:L36707 was created successfully.

Lucas_Werkmeister_WMDE moved this task from Peer Review to Doing on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 2) board.Mar 2 2022, 1:52 PM

Change 767517 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Add missing Special:NewLexemeAlpha i18n messages

https://gerrit.wikimedia.org/r/767517

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 2) board.Mar 2 2022, 1:59 PM

Change 767517 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Add missing Special:NewLexemeAlpha i18n messages

https://gerrit.wikimedia.org/r/767517

Lucas_Werkmeister_WMDE moved this task from Peer Review to Parents / Waiting on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 2) board.Mar 3 2022, 9:59 AM

karapayneWMDE updated the task description. (Show Details)Mar 9 2022, 1:15 PM

karapayneWMDE edited projects, added Special:NewLexeme revival (Special:NewLexeme revival - sprint 3); removed Special:NewLexeme revival (Special:NewLexeme revival - sprint 2).Mar 9 2022, 1:49 PM

karapayneWMDE moved this task from To Do to Parents / Waiting on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 3) board.

karapayneWMDE mentioned this in T298145: Spelling variant of the Lemma - Showing language related variants when the user makes the lookup field active.Mar 9 2022, 1:53 PM

karapayneWMDE updated the task description. (Show Details)

karapayneWMDE mentioned this in T298143: Spelling variant of the Lemma - basic lookup for picking the spelling variant.Mar 9 2022, 1:56 PM

karapayneWMDE updated the task description. (Show Details)Mar 10 2022, 4:00 PM

@Lydia_Pintscher: In the task breakdown, we decided that redirecting to the new lexeme would not be part of the subtask T302961: Use API endpoint when creating a new Lexeme (T302961#7766524). Should that functionality be part of this story (new subtask, probably still part of the sprint), or do you want to track it separately?