Page MenuHomePhabricator
Create Task
Maniphest T303029

Revert ParsoidSiteConfigInit hook creation
Closed, ResolvedPublic
Actions

Description

We don't want to have https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/758527 in 1.38.0, so we need to remove it from the code base before that happens.

Prerequisites:

  • bugfixes on 1.36 and 1.37 out (end of March 2022)
  • Translate extension able to register without that hook (will need to modify Translate registration for that.)

Details

SubjectRepoBranchLines +/-
Revert "Add temporary ParsoidSiteConfigInit hook"mediawiki/services/parsoidREL1_38+3 -16
Revert "Add temporary ParsoidSiteConfigInit hook"mediawiki/coremaster+3 -16
Remove the usage of the onParsoidSiteConfigInitHookmediawiki/extensions/TranslateREL1_38+3 -18
Revert "Add temporary ParsoidSiteConfigInit hook"mediawiki/services/parsoidmaster+3 -16
Remove the usage of the onParsoidSiteConfigInitHookmediawiki/extensions/TranslateREL1_38+3 -18
Remove the usage of the onParsoidSiteConfigInitHookmediawiki/extensions/Translatemaster+3 -18
Customize query in gerrit

Related Objects

Event Timeline

ihurbain created this task.Mar 4 2022, 8:55 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 4 2022, 8:55 AM
Pginer-WMF moved this task from Backlog to cross projects on the MediaWiki-extensions-Translate board.Mar 28 2022, 11:28 AM
gerritbot added a comment.Apr 1 2022, 1:47 PM

Change 776197 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Translate@master] Removing the usage of the onParsoidSiteConfigInitHook

https://gerrit.wikimedia.org/r/776197

gerritbot added a project: Patch-For-Review.Apr 1 2022, 1:47 PM
gerritbot added a comment.Apr 1 2022, 2:18 PM

Change 776208 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@master] Revert "Add temporary ParsoidSiteConfigInit hook"

https://gerrit.wikimedia.org/r/776208

gerritbot added a comment.Apr 7 2022, 10:09 AM

Change 778255 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Revert "Add temporary ParsoidSiteConfigInit hook"

https://gerrit.wikimedia.org/r/778255

gerritbot added a comment.Apr 7 2022, 5:47 PM

Change 776197 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Remove the usage of the onParsoidSiteConfigInitHook

https://gerrit.wikimedia.org/r/776197

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.7; 2022-04-11).Apr 7 2022, 6:00 PM
cscott merged a task: T300546: Remove ParsoidSiteConfigInit hook once backport to 1.35 is done.Apr 7 2022, 8:06 PM
cscott subscribed.
gerritbot added a comment.Apr 7 2022, 8:08 PM

Change 778233 had a related patch set uploaded (by C. Scott Ananian; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Translate@REL1_38] Remove the usage of the onParsoidSiteConfigInitHook

https://gerrit.wikimedia.org/r/778233

gerritbot added a comment.Apr 7 2022, 8:14 PM

Change 778350 had a related patch set uploaded (by C. Scott Ananian; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Translate@REL1_38] Remove the usage of the onParsoidSiteConfigInitHook

https://gerrit.wikimedia.org/r/778350

gerritbot added a comment.Apr 7 2022, 8:15 PM

Change 778233 abandoned by C. Scott Ananian:

[mediawiki/extensions/Translate@REL1_38] Remove the usage of the onParsoidSiteConfigInitHook

Reason:

Cloned as I060742a51c2af4e70b97fd9bf1e4fa840fe8d307. Depending on a cherry-picked patch is confusing jenkins. :(

https://gerrit.wikimedia.org/r/778233

gerritbot added a comment.Apr 7 2022, 8:33 PM

Change 778255 merged by jenkins-bot:

[mediawiki/core@master] Revert "Add temporary ParsoidSiteConfigInit hook"

https://gerrit.wikimedia.org/r/778255

gerritbot added a comment.Apr 7 2022, 8:35 PM

Change 778234 had a related patch set uploaded (by C. Scott Ananian; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@REL1_38] Revert "Add temporary ParsoidSiteConfigInit hook"

https://gerrit.wikimedia.org/r/778234

gerritbot added a comment.Apr 7 2022, 8:39 PM

Change 776208 abandoned by C. Scott Ananian:

[mediawiki/services/parsoid@master] Revert "Add temporary ParsoidSiteConfigInit hook"

Reason:

Chery-picked as-is to REL1_38 of Parsoid, but replaced by 0548babd463941826adc6df3da890f61694c8749 in core and If019d037587db45d6b1ba60bdc0f8d8df78ccaff in Parsoid.

https://gerrit.wikimedia.org/r/776208

gerritbot added a comment.Apr 7 2022, 8:56 PM

Change 778350 merged by jenkins-bot:

[mediawiki/extensions/Translate@REL1_38] Remove the usage of the onParsoidSiteConfigInitHook

https://gerrit.wikimedia.org/r/778350

gerritbot added a comment.Apr 7 2022, 9:00 PM

Change 778234 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_38] Revert "Add temporary ParsoidSiteConfigInit hook"

https://gerrit.wikimedia.org/r/778234

Maintenance_bot removed a project: Patch-For-Review.Apr 7 2022, 9:31 PM
• ssastry closed this task as Resolved.Apr 12 2022, 6:16 AM
• ssastry assigned this task to ihurbain.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits