Page MenuHomePhabricator
Create Task
Maniphest T303251

Error: exception of type Error: Cannot unpack array with string keys
Closed, ResolvedPublic
Actions

Description

This is showing up on apitesting test jobs for all GrowthExperiments patches:

{
  "message": "Error: exception of type Error: Cannot unpack array with string keys",
  "exception": {
    "id": "0cae2c086252421d907e9a53",
    "type": "Error",
    "file": "/workspace/src/includes/GlobalFunctions.php",
    "line": 1179,
    "message": "Cannot unpack array with string keys",
    "code": 0,
    "url": "/rest.php/growthexperiments/v0/quickstarttips/minerva/visualeditor/copyedit/en",
    "caught_by": "other",
    "backtrace": [
      {
        "file": "/workspace/src/includes/context/DerivativeContext.php",
        "line": 288,
        "function": "wfMessage",
        "args": [
          "array"
        ]
      },
      {
        "file": "/workspace/src/extensions/GrowthExperiments/includes/HelpPanel/Tips/TipNodeRenderer.php",
        "line": 207,
        "function": "msg",
        "class": "DerivativeContext",
        "type": "->",
        "args": [
          "array"
        ]
      },
      {
        "function": "GrowthExperiments\\HelpPanel\\Tips\\{closure}",
        "class": "GrowthExperiments\\HelpPanel\\Tips\\TipNodeRenderer",
        "type": "->",
        "args": [
          "array"
        ]
      },
      {
        "file": "/workspace/src/extensions/GrowthExperiments/includes/HelpPanel/Tips/TipNodeRenderer.php",
        "line": 226,
        "function": "array_map",
        "args": [
          "Closure",
          "array"
        ]
      },
      {
        "file": "/workspace/src/extensions/GrowthExperiments/includes/HelpPanel/Tips/TipNodeRenderer.php",
        "line": 110,
        "function": "getMessageParameters",
        "class": "GrowthExperiments\\HelpPanel\\Tips\\TipNodeRenderer",
        "type": "->",
        "args": [
          "GrowthExperiments\\HelpPanel\\Tips\\TipNode",
          "string"
        ]
      },
      {
        "file": "/workspace/src/extensions/GrowthExperiments/includes/HelpPanel/Tips/TipNodeRenderer.php",
        "line": 69,
        "function": "mainAndTextRender",
        "class": "GrowthExperiments\\HelpPanel\\Tips\\TipNodeRenderer",
        "type": "->",
        "args": [
          "GrowthExperiments\\HelpPanel\\Tips\\TipNode",
          "string"
        ]
      },
      {
        "file": "/workspace/src/extensions/GrowthExperiments/includes/HelpPanel/Tips/TipNodeRenderer.php",
        "line": 53,
        "function": "buildHtml",
        "class": "GrowthExperiments\\HelpPanel\\Tips\\TipNodeRenderer",
        "type": "->",
        "args": [
          "GrowthExperiments\\HelpPanel\\Tips\\TipNode",
          "string",
          "string"
        ]
      },
      {
        "function": "GrowthExperiments\\HelpPanel\\Tips\\{closure}",
        "class": "GrowthExperiments\\HelpPanel\\Tips\\TipNodeRenderer",
        "type": "->",
        "args": [
          "GrowthExperiments\\HelpPanel\\Tips\\TipNode"
        ]
      },
      {
        "file": "/workspace/src/extensions/GrowthExperiments/includes/HelpPanel/Tips/TipNodeRenderer.php",
        "line": 54,
        "function": "array_map",
        "args": [
          "Closure",
          "array"
        ]
      },
      {
        "file": "/workspace/src/extensions/GrowthExperiments/includes/HelpPanel/Tips/TipsAssembler.php",
        "line": 71,
        "function": "render",
        "class": "GrowthExperiments\\HelpPanel\\Tips\\TipNodeRenderer",
        "type": "->",
        "args": [
          "array",
          "string",
          "string"
        ]
      },
      {
        "function": "GrowthExperiments\\HelpPanel\\Tips\\{closure}",
        "class": "GrowthExperiments\\HelpPanel\\Tips\\TipsAssembler",
        "type": "->",
        "args": [
          "array"
        ]
      },
      {
        "file": "/workspace/src/extensions/GrowthExperiments/includes/HelpPanel/Tips/TipsAssembler.php",
        "line": 72,
        "function": "array_map",
        "args": [
          "Closure",
          "array"
        ]
      },
      {
        "file": "/workspace/src/extensions/GrowthExperiments/includes/Rest/Handler/TipsHandler.php",
        "line": 70,
        "function": "getTips",
        "class": "GrowthExperiments\\HelpPanel\\Tips\\TipsAssembler",
        "type": "->",
        "args": [
          "string",
          "string",
          "array",
          "string",
          "string"
        ]
      },
      {
        "file": "/workspace/src/includes/Rest/SimpleHandler.php",
        "line": 38,
        "function": "run",
        "class": "GrowthExperiments\\Rest\\Handler\\TipsHandler",
        "type": "->",
        "args": [
          "string",
          "string",
          "string",
          "string"
        ]
      },
      {
        "file": "/workspace/src/includes/Rest/Router.php",
        "line": 414,
        "function": "execute",
        "class": "MediaWiki\\Rest\\SimpleHandler",
        "type": "->",
        "args": []
      },
      {
        "file": "/workspace/src/includes/Rest/Router.php",
        "line": 338,
        "function": "executeHandler",
        "class": "MediaWiki\\Rest\\Router",
        "type": "->",
        "args": [
          "GrowthExperiments\\Rest\\Handler\\TipsHandler"
        ]
      },
      {
        "file": "/workspace/src/includes/Rest/EntryPoint.php",
        "line": 167,
        "function": "execute",
        "class": "MediaWiki\\Rest\\Router",
        "type": "->",
        "args": [
          "MediaWiki\\Rest\\RequestFromGlobals"
        ]
      },
      {
        "file": "/workspace/src/includes/Rest/EntryPoint.php",
        "line": 132,
        "function": "execute",
        "class": "MediaWiki\\Rest\\EntryPoint",
        "type": "->",
        "args": []
      },
      {
        "file": "/workspace/src/rest.php",
        "line": 31,
        "function": "main",
        "class": "MediaWiki\\Rest\\EntryPoint",
        "type": "::",
        "args": []
      }
    ]
  },
  "httpCode": 500,
  "httpReason": "Internal Server Error"
}

It's not from anything we've changed.

Details

SubjectRepoBranchLines +/-
TipNodeRenderer: Ensure array of messages doesn't have string keysmediawiki/extensions/GrowthExperimentsmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• kostajh triaged this task as Unbreak Now! priority.Mar 8 2022, 10:44 AM
• kostajh created this task.
Restricted Application added a project: Growth-Team. · View Herald TranscriptMar 8 2022, 10:44 AM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript
• kostajh claimed this task.Mar 8 2022, 10:45 AM
• kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
• kostajh moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
• kostajh added a parent task: T300201: 1.38.0-wmf.25 deployment blockers.Mar 8 2022, 10:48 AM
• kostajh added a comment.Mar 8 2022, 11:03 AM

Unable to reproduce it locally so far.

matmarex subscribed.Mar 8 2022, 11:22 AM

Looks like you're passing an associative array to msg() somewhere instead of a list, which (surprisingly to me) seems to have worked correctly before, although nothing in the documentation suggested that it would. I can make it work again if it would be tedious to fix in GrowthExperiments.

matmarex added a comment.Mar 8 2022, 11:23 AM

(This is caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/768837, but this change wasn't the focus of that patch)

• kostajh added a comment.Mar 8 2022, 11:25 AM
In T303251#7759588, @matmarex wrote:

(This is caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/768837, but this change wasn't the focus of that patch)

I'm confused as to why I can't reproduce this locally with that core patch, though.

matmarex added a comment.Mar 8 2022, 11:25 AM

If you're running a more recent version of PHP, then unpacking an array with string keys is no longer impossible! :D

• kostajh added a comment.Mar 8 2022, 11:25 AM
In T303251#7759589, @kostajh wrote:
In T303251#7759588, @matmarex wrote:

(This is caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/768837, but this change wasn't the focus of that patch)

I'm confused as to why I can't reproduce this locally with that core patch, though.

Oh, sorry. Confusingly, the issue only occurs for some task types, but not all. I can reproduce with http://localhost:8080/w/rest.php/growthexperiments/v0/quickstarttips/minerva/visualeditor/copyedit/en . Let me see if I can fix this easily in GrowthExperiments.

• kostajh edited parent tasks, added: T300202: 1.38.0-wmf.26 deployment blockers; removed: T300201: 1.38.0-wmf.25 deployment blockers.Mar 8 2022, 11:27 AM
matmarex added a comment.Mar 8 2022, 11:27 AM

I think this line:

$parameterMessageKey = $nodeConfig['variant'][$skinName] ?? $nodeConfig['data'];

should be:

$parameterMessageKey = $nodeConfig['variant'][$skinName]['data'] ?? $nodeConfig['data'];

The $nodeConfig seems to be coming from TipTree::getEditMessageTipConfigData().

gerritbot added a comment.Mar 8 2022, 11:32 AM

Change 769030 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] TipNodeRenderer: Ensure array of messages doesn't have string keys

https://gerrit.wikimedia.org/r/769030

gerritbot added a project: Patch-For-Review.Mar 8 2022, 11:32 AM
• kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 8 2022, 11:33 AM
In T303251#7759611, @matmarex wrote:

I think this line:

$parameterMessageKey = $nodeConfig['variant'][$skinName] ?? $nodeConfig['data'];

should be:

$parameterMessageKey = $nodeConfig['variant'][$skinName]['data'] ?? $nodeConfig['data'];

The $nodeConfig seems to be coming from TipTree::getEditMessageTipConfigData().

Indeed. Thanks for looking.

• kostajh mentioned this in T303255: Core apitests job should run extension/skin api tests as well.Mar 8 2022, 11:35 AM
gerritbot added a comment.Mar 8 2022, 12:06 PM

Change 769030 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] TipNodeRenderer: Ensure array of messages doesn't have string keys

https://gerrit.wikimedia.org/r/769030

• kostajh closed this task as Resolved.Mar 8 2022, 12:07 PM

Follow-up task is T303255: Core apitests job should run extension/skin api tests as well

Maintenance_bot removed a project: Patch-For-Review.Mar 8 2022, 12:10 PM
hashar subscribed.Mar 8 2022, 12:52 PM

Thank you @matmarex and @kostajh !

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.26; 2022-03-14).Mar 8 2022, 1:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL