Page MenuHomePhabricator
Create Task
Maniphest T303261

After reloading from the new comment (edit conflict) warning message, the tool highlights one comment too many
Closed, ResolvedPublic
Actions

Description

After reloading from the new comment (edit conflict) warning message, the tool highlights one comment too many: in addition to the new comments, also the latest previously existing comment is highlighted.

Details

SubjectRepoBranchLines +/-
Fix highlighting of comments when reloadingmediawiki/extensions/DiscussionToolswmf/1.38.0-wmf.25+5 -17
Fix highlighting of comments when reloadingmediawiki/extensions/DiscussionToolsmaster+5 -17
Customize query in gerrit

Event Timeline

matmarex created this task.Mar 8 2022, 12:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 8 2022, 12:41 PM
gerritbot added a comment.Mar 8 2022, 11:13 PM

Change 769136 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Fix highlighting of comments when reloading

https://gerrit.wikimedia.org/r/769136

gerritbot added a project: Patch-For-Review.Mar 8 2022, 11:13 PM
gerritbot added a comment.Mar 9 2022, 10:44 PM

Change 769136 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix highlighting of comments when reloading

https://gerrit.wikimedia.org/r/769136

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.26; 2022-03-14).Mar 9 2022, 11:00 PM
matmarex added a project: Editing-team (Kanban Board).Mar 9 2022, 11:09 PM
matmarex moved this task from Backlog to Triaged on the DiscussionTools board.
matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.
matmarex edited projects, added Editing QA; removed Patch-For-Review.
gerritbot added a comment.Mar 10 2022, 8:44 PM

Change 769559 had a related patch set uploaded (by Bartosz Dziewoński; author: Esanders):

[mediawiki/extensions/DiscussionTools@wmf/1.38.0-wmf.25] Fix highlighting of comments when reloading

https://gerrit.wikimedia.org/r/769559

gerritbot added a project: Patch-For-Review.Mar 10 2022, 8:44 PM
gerritbot added a comment.Mar 10 2022, 9:19 PM

Change 769559 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.38.0-wmf.25] Fix highlighting of comments when reloading

https://gerrit.wikimedia.org/r/769559

Stashbot added a comment.Mar 10 2022, 9:34 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-10T21:34:54Z] <rzl@deploy1002> Synchronized php-1.38.0-wmf.25/extensions/DiscussionTools/modules/controller.js: Backport: [[gerrit:769559|Fix highlighting of comments when reloading (T303261)]] (duration: 00m 47s)

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.25; 2022-03-07); removed MW-1.38-notes (1.38.0-wmf.26; 2022-03-14).Mar 10 2022, 10:00 PM
matmarex moved this task from Inbox to Low Priority on the Editing QA board.May 23 2022, 5:35 PM
EAkinloose edited projects, added Verified; removed Editing QA.Jul 16 2022, 10:26 PM
EAkinloose subscribed.

No comments are highlighted on reload - https://photos.app.goo.gl/3GQpQMXAtss4so1NA and only the new comment is highlighted when you try again without manual reload - https://photos.app.goo.gl/b4M9dJkBHKDtth3s5

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Jul 16 2022, 10:26 PM
ppelberg closed this task as Resolved.Jul 22 2022, 1:37 AM
ppelberg claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits