Page MenuHomePhabricator
Create Task
Maniphest T303885

Wikimedia\Rdbms\DBUnexpectedError: MWExceptionHandler::rollbackPrimaryChangesAndLog: Database is owned by ID '1923155107' (got '')
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   Wikimedia\Rdbms\DBUnexpectedError: MWExceptionHandler::rollbackPrimaryChangesAndLog: Database is owned by ID '1923155107' (got '')
exception.trace
from /srv/mediawiki/php-1.38.0-wmf.26/includes/libs/rdbms/database/Database.php(4764)
#0 /srv/mediawiki/php-1.38.0-wmf.26/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1936): Wikimedia\Rdbms\Database->flushSession(string)
#1 /srv/mediawiki/php-1.38.0-wmf.26/includes/libs/rdbms/loadbalancer/LoadBalancer.php(2239): Wikimedia\Rdbms\LoadBalancer::Wikimedia\Rdbms\{closure}(Wikimedia\Rdbms\DatabaseMysqli)
#2 /srv/mediawiki/php-1.38.0-wmf.26/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1937): Wikimedia\Rdbms\LoadBalancer->forEachOpenPrimaryConnection(Closure)
#3 /srv/mediawiki/php-1.38.0-wmf.26/includes/libs/rdbms/lbfactory/LBFactory.php(250): Wikimedia\Rdbms\LoadBalancer->flushPrimarySessions(string, integer)
#4 /srv/mediawiki/php-1.38.0-wmf.26/includes/libs/rdbms/lbfactory/LBFactoryMulti.php(230): Wikimedia\Rdbms\LBFactory::Wikimedia\Rdbms\{closure}(Wikimedia\Rdbms\LoadBalancer, string, array)
#5 /srv/mediawiki/php-1.38.0-wmf.26/includes/libs/rdbms/lbfactory/LBFactory.php(252): Wikimedia\Rdbms\LBFactoryMulti->forEachLB(Closure, array)
#6 /srv/mediawiki/php-1.38.0-wmf.26/includes/libs/rdbms/lbfactory/LBFactory.php(346): Wikimedia\Rdbms\LBFactory->forEachLBCallMethod(string, array)
#7 /srv/mediawiki/php-1.38.0-wmf.26/includes/exception/MWExceptionHandler.php(138): Wikimedia\Rdbms\LBFactory->flushPrimarySessions(string)
#8 /srv/mediawiki/php-1.38.0-wmf.26/includes/exception/MWExceptionHandler.php(203): MWExceptionHandler::rollbackPrimaryChangesAndLog(Wikimedia\Rdbms\DBTransactionError, string)
#9 /srv/mediawiki/php-1.38.0-wmf.26/includes/exception/MWExceptionHandler.php(172): MWExceptionHandler::handleException(Wikimedia\Rdbms\DBTransactionError, string)
#10 [internal function]: MWExceptionHandler::handleUncaughtException(Wikimedia\Rdbms\DBTransactionError)
#11 {main}
Impact
Notes

Details

Request URL
https://test.wikipedia.org/w/api.php
SubjectRepoBranchLines +/-
rdbms: provide $owner argument in LoadBalancer::flushPrimarySessions()mediawiki/corewmf/1.38.0-wmf.26+7 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

jeena created this task.Mar 15 2022, 8:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2022, 8:50 PM
jeena added a parent task: T300202: 1.38.0-wmf.26 deployment blockers.Mar 15 2022, 8:50 PM
gerritbot added a comment.Mar 15 2022, 8:52 PM

Change 770935 had a related patch set uploaded (by Zabe; author: Aaron Schulz):

[mediawiki/core@wmf/1.38.0-wmf.26] rdbms: provide $owner argument in LoadBalancer::flushPrimarySessions()

https://gerrit.wikimedia.org/r/770935

gerritbot added a project: Patch-For-Review.Mar 15 2022, 8:52 PM
Zabe subscribed.Mar 15 2022, 8:53 PM
jeena mentioned this in T303887: Wikimedia\Rdbms\DBTransactionError: Transaction round stage must be 'cursory' (not 'within-rollback-session').Mar 15 2022, 8:56 PM
gerritbot added a comment.Mar 15 2022, 9:26 PM

Change 770935 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.26] rdbms: provide $owner argument in LoadBalancer::flushPrimarySessions()

https://gerrit.wikimedia.org/r/770935

Stashbot added a comment.Mar 15 2022, 9:27 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-15T21:27:48Z] <ladsgroup@deploy1002> Synchronized php-1.38.0-wmf.26/includes/libs/rdbms/loadbalancer/LoadBalancer.php: Backport: [[gerrit:770935|rdbms: provide $owner argument in LoadBalancer::flushPrimarySessions() (T303885)]] (duration: 00m 53s)

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.26; 2022-03-14).Mar 15 2022, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 15 2022, 10:10 PM
gerritbot added a comment.Mar 15 2022, 11:18 PM

Change 771081 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] rdbms: use the LoadBalancer id in flushPrimarySessions()

https://gerrit.wikimedia.org/r/771081

gerritbot added a project: Patch-For-Review.Mar 15 2022, 11:18 PM
Krinkle added a project: MediaWiki-libs-Rdbms.Mar 16 2022, 3:37 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptMar 16 2022, 3:37 PM
jeena triaged this task as Unbreak Now! priority.Mar 16 2022, 5:13 PM
Ladsgroup closed this task as Resolved.Mar 17 2022, 9:06 PM
Ladsgroup claimed this task.
Ladsgroup subscribed.

Reverted the whole thing. Please do not re-apply the patch without major rethinking of how it should be done and how it should be deployed. I try to find a place to write an essay about this.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptMar 17 2022, 9:06 PM
Maintenance_bot moved this task from Incoming to Done on the User-Ladsgroup board.Mar 17 2022, 9:15 PM
Krinkle mentioned this in T281451: Wikimedia\Rdbms\DBTransactionError: Transaction round stage must be 'cursory' (not 'within-rollback-callbacks').Mar 18 2022, 1:21 PM
Krinkle moved this task from Untriaged to Mar 2022 on the Wikimedia-production-error board.Mar 22 2022, 1:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL